From patchwork Wed Aug 23 16:14:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Francis Laniel X-Patchwork-Id: 13362814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD374EE49A0 for ; Wed, 23 Aug 2023 16:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237472AbjHWQOf (ORCPT ); Wed, 23 Aug 2023 12:14:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbjHWQOf (ORCPT ); Wed, 23 Aug 2023 12:14:35 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E527EE68; Wed, 23 Aug 2023 09:14:32 -0700 (PDT) Received: from pwmachine.numericable.fr (85-170-34-233.rev.numericable.fr [85.170.34.233]) by linux.microsoft.com (Postfix) with ESMTPSA id 2BAF52126CC6; Wed, 23 Aug 2023 09:14:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2BAF52126CC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1692807272; bh=GSsNCY8KC3V4foUT3nbiUGYLIoC98erD7H+/xMZ+8ak=; h=From:To:Cc:Subject:Date:From; b=PGHxj2s3KGO/aDOT8e3A3dEB0bl4FEId6QFVk6ZDcCNTPezF/pVEj8NZ6ItuixOLq ty8r3yFrD5utQiwPmbaBwXIWyRZXbBlOGcf5ZdDCdyTn9Nx0zdrvll9k/Yz2nQwizz //HUw4orHvGlb8txQqMK+UeNDrZRNy2V+3FtPr48= From: Francis Laniel To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Francis Laniel Subject: [RFC PATCH v1 0/1] Return ENAMESVRLSYMS when func matches several symbols during PMU kprobe creation Date: Wed, 23 Aug 2023 18:14:09 +0200 Message-Id: <20230823161410.103489-1-flaniel@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org Hi. In the kernel source code, it exists different functions which share the same name but which have, of course, different addresses as they can be defined in different modules: root@vm-amd64:~# grep ntfs_file_write_iter /proc/kallsyms ffffffff814ce3c0 t __pfx_ntfs_file_write_iter ffffffff814ce3d0 t ntfs_file_write_iter ffffffff814fc8a0 t __pfx_ntfs_file_write_iter ffffffff814fc8b0 t ntfs_file_write_iter This can be source of troubles when you create a PMU kprobe for such a function, as it will only install one for the first address (e.g. 0xffffffff814ce3d0 in the above). This could lead to some troubles were BPF based tools does not report any event because the second function is not called: root@vm-amd64:/mnt# mount | grep /mnt /foo.img on /mnt type ntfs3 (rw,relatime,uid=0,gid=0,iocharset=utf8) # ig is a tool which installs a PMU kprobe on ntfs_file_write_iter(). root@vm-amd64:/mnt# ig trace fsslower -m 0 -f ntfs3 --host &> /tmp/foo & [1] 207 root@vm-amd64:/mnt# dd if=./foo of=./bar count=3 3+0 records in 3+0 records out 1536 bytes (1.5 kB, 1.5 KiB) copied, 0.00543323 s, 283 kB/s root@vm-amd64:/mnt# fg ig trace fsslower -m 0 -f ntfs3 --host &> /tmp/foo ^Croot@vm-amd64:/mnt# more /tmp/foo RUNTIME.CONTAINERNAME RUNTIME.CONTAIN… PID COMM T BYTES OFFSET LAT FILE 214 dd R 512 0 766 foo 214 dd R 512 512 9 foo 214 dd As you can see in the above, only read events are reported and no write because the kprobe is installed for the old ntfs_file_write_iter() and not the ntfs3 one. In this contribution, I modified create_local_trace_kprobe() to test if the function name given as argument matches several symbols. If this is the case ENAMESVRLSYMS, a new error code, is returned to indicate the user to use addr and offs to remove this ambiguity. So, when the above BPF tool is run, the following error message is printed: root@vm-amd64:~# ig trace fsslower -m 0 -f ntfs3 --host &> /tmp/foo root@vm-amd64:~# more /tmp/foo RUNTIME.CONTAINERNAME RUNTIME.CONTAIN… PID COMM T BYTES OFFSET LAT FILE Error: running gadget: running gadget: installing tracer: attaching kprobe: crea ting perf_kprobe PMU (arch-specific fallback for "ntfs_file_write_iter"): token ntfs_file_write_iter: opening perf event: errno 134 Note that, this contribution is the conclusion of a previous RFC which intended to install a PMU kprobe for all matching symbols [1, 2]. If you see any way to improve this contribution, particularly if you have an idea to add a test for this behavior, please share your feedback. Francis Laniel (1): tracing/kprobes: Return ENAMESVRLSYMS when func matches several symbols arch/alpha/include/uapi/asm/errno.h | 2 ++ arch/mips/include/uapi/asm/errno.h | 2 ++ arch/parisc/include/uapi/asm/errno.h | 2 ++ arch/sparc/include/uapi/asm/errno.h | 2 ++ include/uapi/asm-generic/errno.h | 2 ++ kernel/trace/trace_kprobe.c | 26 ++++++++++++++++++++++ tools/arch/alpha/include/uapi/asm/errno.h | 2 ++ tools/arch/mips/include/uapi/asm/errno.h | 2 ++ tools/arch/parisc/include/uapi/asm/errno.h | 2 ++ tools/arch/sparc/include/uapi/asm/errno.h | 2 ++ tools/include/uapi/asm-generic/errno.h | 2 ++ 11 files changed, 46 insertions(+) Best regards and thank you in advance. --- [1]: https://lore.kernel.org/lkml/20230816163517.112518-1-flaniel@linux.microsoft.com/ [2]: https://lore.kernel.org/lkml/20230819101105.b0c104ae4494a7d1f2eea742@kernel.org/ -- 2.34.1