[v5,0/2] Update mce_record tracepoint

Message

Avadhut Naik March 28, 2024, 6:04 p.m. UTC

This patchset updates the mce_record tracepoint so that the recently added
fields of struct mce are exported through it to userspace.

The first patch adds PPIN (Protected Processor Inventory Number) field to
the tracepoint.

The second patch adds the microcode field (Microcode Revision) to the
tracepoint.

Changes in v2:
 - Export microcode field (Microcode Revision) through the tracepoiont in
   addition to PPIN.

Changes in v3:
 - Change format specifier for microcode revision from %u to %x
 - Fix tab alignments
 - Add Reviewed-by: Sohil Mehta <[e-mail]>

Changes in v4:
 - Update commit messages to reflect the reason for the fields being
   added to the tracepoint.
 - Add comment to explicitly state the type of information that should
   be added to the tracepoint.
 - Add Reviewed-by: Steven Rostedt (Google) <[e-mail]>

Changes in v5:
 - Changed "MICROCODE REVISION" to just "MICROCODE".
 - Changed words which are not acronyms from ALL CAPS to no caps.
 - Added Reviewed-by: Tony Luck <[e-mail]>

[NOTE:

 - Since only caps of words which are not acronyms have been changed in
   this version and the word "REVISION" has been removed i.e. changes are
   very minor, have retained the the below tags received for previous
   versions:
    Reviewed-by: Sohil Mehta <[e-mail]>
    Reviewed-by: Steven Rostedt (Google) <[e-mail]>
    Reviewed-by: Tony Luck <[e-mail]>]

Avadhut Naik (2):
  tracing: Include PPIN in mce_record tracepoint
  tracing: Include Microcode Revision in mce_record tracepoint

 include/trace/events/mce.h | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)


base-commit: 9699768066a9b12db247d5ee9276cf298b67528d

Comments

Sohil Mehta March 28, 2024, 6:14 p.m. UTC | #1

On 3/28/2024 11:04 AM, Avadhut Naik wrote:

>  - Since only caps of words which are not acronyms have been changed in
>    this version and the word "REVISION" has been removed i.e. changes are
>    very minor, have retained the the below tags received for previous
>    versions:
>     Reviewed-by: Sohil Mehta <[e-mail]>

> Avadhut Naik (2):
>   tracing: Include PPIN in mce_record tracepoint
>   tracing: Include Microcode Revision in mce_record tracepoint


The patches look good to me.

Naik, Avadhut March 29, 2024, 12:13 a.m. UTC | #2

On 3/28/2024 13:14, Sohil Mehta wrote:
> On 3/28/2024 11:04 AM, Avadhut Naik wrote:
> 
>>  - Since only caps of words which are not acronyms have been changed in
>>    this version and the word "REVISION" has been removed i.e. changes are
>>    very minor, have retained the the below tags received for previous
>>    versions:
>>     Reviewed-by: Sohil Mehta <[e-mail]>
> 
>> Avadhut Naik (2):
>>   tracing: Include PPIN in mce_record tracepoint
>>   tracing: Include Microcode Revision in mce_record tracepoint
> 
> 
> The patches look good to me.

Kindly ignore this set.

As pointed out by Sohit, have missed adding [e-mail]

Will resend the set.