Message ID | 20230130181915.1113313-9-zwisler@google.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | use canonical ftrace path whenever possible | expand |
On Mon, Jan 30, 2023 at 11:19:14AM -0700, Ross Zwisler wrote: > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > scripts/leaking_addresses.pl only skipped this older debugfs path, so > let's add the canonical path as well. > > Signed-off-by: Ross Zwisler <zwisler@google.com> > --- > scripts/leaking_addresses.pl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl > index 8f636a23bc3f..e695634d153d 100755 > --- a/scripts/leaking_addresses.pl > +++ b/scripts/leaking_addresses.pl > @@ -61,6 +61,7 @@ my @skip_abs = ( > '/proc/device-tree', > '/proc/1/syscall', > '/sys/firmware/devicetree', > + '/sys/kernel/tracing/trace_pipe', > '/sys/kernel/debug/tracing/trace_pipe', > '/sys/kernel/security/apparmor/revision'); Thanks. Acked-by: Tycho Andersen <tycho@tycho.pizza>
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 8f636a23bc3f..e695634d153d 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -61,6 +61,7 @@ my @skip_abs = ( '/proc/device-tree', '/proc/1/syscall', '/sys/firmware/devicetree', + '/sys/kernel/tracing/trace_pipe', '/sys/kernel/debug/tracing/trace_pipe', '/sys/kernel/security/apparmor/revision');
The canonical location for the tracefs filesystem is at /sys/kernel/tracing. But, from Documentation/trace/ftrace.rst: Before 4.1, all ftrace tracing control files were within the debugfs file system, which is typically located at /sys/kernel/debug/tracing. For backward compatibility, when mounting the debugfs file system, the tracefs file system will be automatically mounted at: /sys/kernel/debug/tracing scripts/leaking_addresses.pl only skipped this older debugfs path, so let's add the canonical path as well. Signed-off-by: Ross Zwisler <zwisler@google.com> --- scripts/leaking_addresses.pl | 1 + 1 file changed, 1 insertion(+)