From patchwork Tue Feb 7 18:51:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13132011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A30CC636D4 for ; Tue, 7 Feb 2023 18:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbjBGSv6 (ORCPT ); Tue, 7 Feb 2023 13:51:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232361AbjBGSvz (ORCPT ); Tue, 7 Feb 2023 13:51:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 270B317CFE; Tue, 7 Feb 2023 10:51:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E688B81AB7; Tue, 7 Feb 2023 18:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89E53C433EF; Tue, 7 Feb 2023 18:51:50 +0000 (UTC) Date: Tue, 7 Feb 2023 13:51:47 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Shuah Khan , Shuah Khan , Peter Zijlstra Subject: [PATCH] tracing/selftests: Ignore __pfx_ symbols in kprobe test Message-ID: <20230207135147.5ce618d6@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org From: "Steven Rostedt (Google)" The kprobe probepoint.tc test started failing because of the added __pfx_ symbols that were added because of -fpatchable-function-entry=X,Y causing unwinders to see them as part of the previous functions. But kprobes can not be added on top of them. The selftest looks for tracefs_create_dir and picks it and the previous and following functions to add at their address. This caused it to include __pfx_tracefs_create_dir which is invalid to attach a kprobe to and caused the test to fail. Fixes: 9f2899fe36a62 ("objtool: Add option to generate prefix symbols") Signed-off-by: Steven Rostedt (Google) Acked-by: --- tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc b/tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc index 624269c8d534..e1b7506c1b11 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc @@ -21,7 +21,7 @@ set_offs() { # prev target next # We have to decode symbol addresses to get correct offsets. # If the offset is not an instruction boundary, it cause -EILSEQ. -set_offs `grep -A1 -B1 ${TARGET_FUNC} /proc/kallsyms | cut -f 1 -d " " | xargs` +set_offs `grep -v __pfx_ /proc/kallsyms | grep -A1 -B1 ${TARGET_FUNC} | cut -f 1 -d " " | xargs` UINT_TEST=no # printf "%x" -1 returns (unsigned long)-1.