| Message ID | 20230215223350.2658616-5-zwisler@google.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | use canonical ftrace path whenever possible | expand |
On Wed, 15 Feb 2023 15:33:48 -0700 Ross Zwisler <zwisler@chromium.org> wrote: > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > A comment in kvm_stat still refers to this older debugfs path, so let's > update it to avoid confusion. > > Signed-off-by: Ross Zwisler <zwisler@google.com> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve
On 2/15/23 23:33, Ross Zwisler wrote: > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > A comment in kvm_stat still refers to this older debugfs path, so let's > update it to avoid confusion. > > Signed-off-by: Ross Zwisler <zwisler@google.com> > --- > tools/kvm/kvm_stat/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat > index 6f28180ffeea..15bf00e79e3f 100755 > --- a/tools/kvm/kvm_stat/kvm_stat > +++ b/tools/kvm/kvm_stat/kvm_stat > @@ -627,7 +627,7 @@ class TracepointProvider(Provider): > name)'. > > All available events have directories under > - /sys/kernel/debug/tracing/events/ which export information > + /sys/kernel/tracing/events/ which export information > about the specific event. Therefore, listing the dirs gives us > a list of all available events. > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
On 2/16/2023 4:03 AM, Ross Zwisler wrote: > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > A comment in kvm_stat still refers to this older debugfs path, so let's > update it to avoid confusion. > > Signed-off-by: Ross Zwisler <zwisler@google.com> > --- > tools/kvm/kvm_stat/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat > index 6f28180ffeea..15bf00e79e3f 100755 > --- a/tools/kvm/kvm_stat/kvm_stat > +++ b/tools/kvm/kvm_stat/kvm_stat > @@ -627,7 +627,7 @@ class TracepointProvider(Provider): > name)'. > > All available events have directories under > - /sys/kernel/debug/tracing/events/ which export information > + /sys/kernel/tracing/events/ which export information > about the specific event. Therefore, listing the dirs gives us > a list of all available events. > Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -Mukesh
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat index 6f28180ffeea..15bf00e79e3f 100755 --- a/tools/kvm/kvm_stat/kvm_stat +++ b/tools/kvm/kvm_stat/kvm_stat @@ -627,7 +627,7 @@ class TracepointProvider(Provider): name)'. All available events have directories under - /sys/kernel/debug/tracing/events/ which export information + /sys/kernel/tracing/events/ which export information about the specific event. Therefore, listing the dirs gives us a list of all available events.
The canonical location for the tracefs filesystem is at /sys/kernel/tracing. But, from Documentation/trace/ftrace.rst: Before 4.1, all ftrace tracing control files were within the debugfs file system, which is typically located at /sys/kernel/debug/tracing. For backward compatibility, when mounting the debugfs file system, the tracefs file system will be automatically mounted at: /sys/kernel/debug/tracing A comment in kvm_stat still refers to this older debugfs path, so let's update it to avoid confusion. Signed-off-by: Ross Zwisler <zwisler@google.com> --- tools/kvm/kvm_stat/kvm_stat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)