| Message ID | 20230418143854.8vHWQKLM@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2951580ba6adb082bb6b7154a5ecb24e7c1f7569 |
| Headers | show |
| Series | tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode(). | expand |
On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote: > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > since these modes are not decoded. The author was not aware of the fancy > decoding function which makes the life easier. > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > modes. > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Good catch. Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -Mukesh > --- > include/trace/events/timer.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h > index 2e713a7d9aa3a..5d43751a766c6 100644 > --- a/include/trace/events/timer.h > +++ b/include/trace/events/timer.h > @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel, > { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \ > { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \ > { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \ > - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }) > + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \ > + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \ > + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \ > + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \ > + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" }) > > /** > * hrtimer_init - called when the hrtimer is initialized
On Tue, 18 Apr 2023 16:38:54 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > since these modes are not decoded. The author was not aware of the fancy > decoding function which makes the life easier. > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > modes. > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve
On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote: > On Tue, 18 Apr 2023 16:38:54 +0200 > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > > since these modes are not decoded. The author was not aware of the fancy > > decoding function which makes the life easier. > > > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > > modes. > > > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> Could this be either routed via the tracing tree or the tip tree but please route this :) Sebastian
On Wed, 24 May 2023 17:39:28 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote: > > On Tue, 18 Apr 2023 16:38:54 +0200 > > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > > > since these modes are not decoded. The author was not aware of the fancy > > > decoding function which makes the life easier. > > > > > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > > > modes. > > > > > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > > > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> > > Could this be either routed via the tracing tree or the tip tree but > please route this :) > Events are normally owned by the subsystem they are used in. So it should go through tip. But if I get an ack from the subsystem maintainer, I can route it through tracing. -- Steve
On Wed, 24 May 2023 20:25:26 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > Events are normally owned by the subsystem they are used in. So it > should go through tip. But if I get an ack from the subsystem > maintainer, I can route it through tracing. Thomas, care to give me an ack? Or do you want to take it? -- Steve
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h index 2e713a7d9aa3a..5d43751a766c6 100644 --- a/include/trace/events/timer.h +++ b/include/trace/events/timer.h @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel, { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \ { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \ { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \ - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }) + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \ + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \ + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \ + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \ + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" }) /** * hrtimer_init - called when the hrtimer is initialized
The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number since these modes are not decoded. The author was not aware of the fancy decoding function which makes the life easier. Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD modes. Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- include/trace/events/timer.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)