| Message ID | 20230426032257.3157247-1-lyenting@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | adace4408252cc1c9913958d71e81a688af90a30 |
| Headers | show |
| Series | tracing: Add missing spaces in trace_print_hex_seq() | expand |
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index bd475a00f96d..6e45cf18d816 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -221,8 +221,11 @@ trace_print_hex_seq(struct trace_seq *p, const unsigned char *buf, int buf_len, const char *ret = trace_seq_buffer_ptr(p); const char *fmt = concatenate ? "%*phN" : "%*ph"; - for (i = 0; i < buf_len; i += 16) + for (i = 0; i < buf_len; i += 16) { + if (!concatenate && i != 0) + trace_seq_putc(p, ' '); trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]); + } trace_seq_putc(p, 0); return ret;
If the buffer length is larger than 16 and concatenate is set to false, there would be missing spaces every 16 bytes. Example: Before: c5 11 10 50 05 4d 31 40 00 40 00 40 00 4d 31 4000 40 00 After: c5 11 10 50 05 4d 31 40 00 40 00 40 00 4d 31 40 00 40 00 Signed-off-by: Ken Lin <lyenting@google.com> --- kernel/trace/trace_output.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)