diff mbox series

[v3,2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test

Message ID 20230621063438.154271-1-sunliming@kylinos.cn (mailing list archive)
State Superseded
Headers show
Series None | expand

Commit Message

sunliming June 21, 2023, 6:34 a.m. UTC 
The user_event has not be enabled in write_fault test in ftrace
self-test, Just enable it.

Signed-off-by: sunliming <sunliming@kylinos.cn>
---
 tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Beau Belgrave June 22, 2023, 8:24 p.m. UTC | #1 
On Wed, Jun 21, 2023 at 02:34:38PM +0800, sunliming wrote:
> The user_event has not be enabled in write_fault test in ftrace
> self-test, Just enable it.
> 
> Signed-off-by: sunliming <sunliming@kylinos.cn>

Good catch.

Acked-by: Beau Belgrave <beaub@linux.microsoft.com>

Thanks!

> ---
>  tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
> index abfb49558a26..d33bd31425db 100644
> --- a/tools/testing/selftests/user_events/ftrace_test.c
> +++ b/tools/testing/selftests/user_events/ftrace_test.c
> @@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
>  	ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, &reg));
>  	ASSERT_EQ(0, reg.write_index);
>  
> +	/* Enable event */
> +	self->enable_fd = open(enable_file, O_RDWR);
> +	ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
> +
>  	/* Write should work normally */
>  	ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));
>  
> -- 
> 2.25.1
diff mbox series

Patch

diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
index abfb49558a26..d33bd31425db 100644
--- a/tools/testing/selftests/user_events/ftrace_test.c
+++ b/tools/testing/selftests/user_events/ftrace_test.c
@@ -373,6 +373,10 @@  TEST_F(user, write_fault) {
 	ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, &reg));
 	ASSERT_EQ(0, reg.write_index);
 
+	/* Enable event */
+	self->enable_fd = open(enable_file, O_RDWR);
+	ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
+
 	/* Write should work normally */
 	ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));