| Message ID | 20230809040937.1011766-1-liaoyu15@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] rv/include: set variable 'da_mon_##name' to static | expand |
On Wed, 9 Aug 2023 12:09:37 +0800 Yu Liao <liaoyu15@huawei.com> wrote: > @@ -262,7 +262,7 @@ static inline void da_monitor_destroy_##name(void) \ > /* \ > * per-cpu monitor variables \ > */ \ > -DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ > +static DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ You need to fix the backslash when you add text. -- Steve > \ > /* \
On 2023/8/22 22:11, Steven Rostedt wrote: > On Wed, 9 Aug 2023 12:09:37 +0800 > Yu Liao <liaoyu15@huawei.com> wrote: > >> @@ -262,7 +262,7 @@ static inline void da_monitor_destroy_##name(void) \ >> /* \ >> * per-cpu monitor variables \ >> */ \ >> -DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ >> +static DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ > > You need to fix the backslash when you add text. > > -- Steve Thank you for the review. I'll make the suggested changes and send you the V2. Best regards, Yu > >> \ >> /* \ >
diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h index 9eb75683e012..dfab1a586cdc 100644 --- a/include/rv/da_monitor.h +++ b/include/rv/da_monitor.h @@ -262,7 +262,7 @@ static inline void da_monitor_destroy_##name(void) \ /* \ * per-cpu monitor variables \ */ \ -DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ +static DEFINE_PER_CPU(struct da_monitor, da_mon_##name); \ \ /* \ * da_get_monitor_##name - return current CPU monitor address \
gcc with W=1 reports kernel/trace/rv/monitors/wip/wip.c:20:1: sparse: sparse: symbol 'da_mon_wip' was not declared. Should it be static? The per-cpu variable 'da_mon_##name' is only used in its defining file, so it should be static. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202307280030.7EjUG9gR-lkp@intel.com/ Signed-off-by: Yu Liao <liaoyu15@huawei.com> --- include/rv/da_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)