| Message ID | 20230919012823.7815-1-zeming@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9efd24ec5599ed485b7c4d9aeb731141f6285167 |
| Delegated to: | Masami Hiramatsu |
| Headers | show |
| Series | kprobes: Remove unnecessary initial values of variables | expand |
On Tue, 19 Sep 2023 09:28:23 +0800 Li zeming <zeming@nfschina.com> wrote: > ri and sym is assigned first, so it does not need to initialize the > assignment. > Yes, thanks for fixing! Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> > Signed-off-by: Li zeming <zeming@nfschina.com> > --- > kernel/kprobes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index ca385b61d546..82b2a366d496 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1990,7 +1990,7 @@ NOKPROBE_SYMBOL(__kretprobe_find_ret_addr); > unsigned long kretprobe_find_ret_addr(struct task_struct *tsk, void *fp, > struct llist_node **cur) > { > - struct kretprobe_instance *ri = NULL; > + struct kretprobe_instance *ri; > kprobe_opcode_t *ret; > > if (WARN_ON_ONCE(!cur)) > @@ -2817,7 +2817,7 @@ static int show_kprobe_addr(struct seq_file *pi, void *v) > { > struct hlist_head *head; > struct kprobe *p, *kp; > - const char *sym = NULL; > + const char *sym; > unsigned int i = *(loff_t *) v; > unsigned long offset = 0; > char *modname, namebuf[KSYM_NAME_LEN]; > -- > 2.18.2 >
diff --git a/kernel/kprobes.c b/kernel/kprobes.c index ca385b61d546..82b2a366d496 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1990,7 +1990,7 @@ NOKPROBE_SYMBOL(__kretprobe_find_ret_addr); unsigned long kretprobe_find_ret_addr(struct task_struct *tsk, void *fp, struct llist_node **cur) { - struct kretprobe_instance *ri = NULL; + struct kretprobe_instance *ri; kprobe_opcode_t *ret; if (WARN_ON_ONCE(!cur)) @@ -2817,7 +2817,7 @@ static int show_kprobe_addr(struct seq_file *pi, void *v) { struct hlist_head *head; struct kprobe *p, *kp; - const char *sym = NULL; + const char *sym; unsigned int i = *(loff_t *) v; unsigned long offset = 0; char *modname, namebuf[KSYM_NAME_LEN];
ri and sym is assigned first, so it does not need to initialize the assignment. Signed-off-by: Li zeming <zeming@nfschina.com> --- kernel/kprobes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)