| Message ID | 20240613132056.608-9-honggyu.kim@sk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | DAMON based tiered memory management for CXL memory | expand |
Hi Honggyu, On Thu, 13 Jun 2024 22:20:55 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote: > This patch adds damon description for "migrate_hot" and "migrate_cold" > actions for both usage and design documents as long as a new > "target_nid" knob to set the migration target node. > > Signed-off-by: Honggyu Kim <honggyu.kim@sk.com> > --- > Documentation/admin-guide/mm/damon/usage.rst | 8 +++++++- > Documentation/mm/damon/design.rst | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst > index 7bff54963975..84d62d16c9f9 100644 > --- a/Documentation/admin-guide/mm/damon/usage.rst > +++ b/Documentation/admin-guide/mm/damon/usage.rst > @@ -300,6 +300,10 @@ from the file and their meaning are same to those of the list on > The ``apply_interval_us`` file is for setting and getting the scheme's > :ref:`apply_interval <damon_design_damos>` in microseconds. > > +The ``target_nid`` file is for setting the migration target node, which is > +only meaningful when the ``action`` is either ``migrate_hot`` or > +``migrate_cold``. > + > .. _sysfs_access_pattern: > > schemes/<N>/access_pattern/ > @@ -759,7 +763,9 @@ list on :ref:`design doc <damon_design_damos_action>`. > - 4: ``nohugepage`` > - 5: ``lru_prio`` > - 6: ``lru_deprio`` > - - 7: ``stat`` > + - 7: ``migrate_hot`` > + - 8: ``migrate_cold`` > + - 9: ``stat`` This section is for DAMON debugfs interface. And to my understanding, this patchset is not adding support of migrate_{hot,cold} DAMOS actions on DAMON debugfs interface. So I think this part should be removed. > > Quota > ~~~~~ > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst > index 3df387249937..3f12c884eb3a 100644 > --- a/Documentation/mm/damon/design.rst > +++ b/Documentation/mm/damon/design.rst > @@ -325,6 +325,10 @@ that supports each action are as below. > Supported by ``paddr`` operations set. > - ``lru_deprio``: Deprioritize the region on its LRU lists. > Supported by ``paddr`` operations set. > + - ``migrate_hot``: Migrate the regions prioritizing warmer regions. > + Supported by ``paddr`` operations set. > + - ``migrate_cold``: Migrate the regions prioritizing colder regions. > + Supported by ``paddr`` operations set. > - ``stat``: Do nothing but count the statistics. > Supported by all operations sets. Except the DAMON debugfs interface section, this patch looks good to me. Thanks, SJ [...]
On Thu, 13 Jun 2024 07:07:29 -0700 SeongJae Park <sj@kernel.org> wrote: > Hi Honggyu, > > On Thu, 13 Jun 2024 22:20:55 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote: > > > This patch adds damon description for "migrate_hot" and "migrate_cold" > > actions for both usage and design documents as long as a new > > "target_nid" knob to set the migration target node. [...] > Except the DAMON debugfs interface section, this patch looks good to me. One more thing. I'd prefer making the subject more specific. What about, "Docs/damon: document damos_migrate_{hot,cold}"? Thanks, SJ [...]
diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 7bff54963975..84d62d16c9f9 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -300,6 +300,10 @@ from the file and their meaning are same to those of the list on The ``apply_interval_us`` file is for setting and getting the scheme's :ref:`apply_interval <damon_design_damos>` in microseconds. +The ``target_nid`` file is for setting the migration target node, which is +only meaningful when the ``action`` is either ``migrate_hot`` or +``migrate_cold``. + .. _sysfs_access_pattern: schemes/<N>/access_pattern/ @@ -759,7 +763,9 @@ list on :ref:`design doc <damon_design_damos_action>`. - 4: ``nohugepage`` - 5: ``lru_prio`` - 6: ``lru_deprio`` - - 7: ``stat`` + - 7: ``migrate_hot`` + - 8: ``migrate_cold`` + - 9: ``stat`` Quota ~~~~~ diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index 3df387249937..3f12c884eb3a 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -325,6 +325,10 @@ that supports each action are as below. Supported by ``paddr`` operations set. - ``lru_deprio``: Deprioritize the region on its LRU lists. Supported by ``paddr`` operations set. + - ``migrate_hot``: Migrate the regions prioritizing warmer regions. + Supported by ``paddr`` operations set. + - ``migrate_cold``: Migrate the regions prioritizing colder regions. + Supported by ``paddr`` operations set. - ``stat``: Do nothing but count the statistics. Supported by all operations sets.
This patch adds damon description for "migrate_hot" and "migrate_cold" actions for both usage and design documents as long as a new "target_nid" knob to set the migration target node. Signed-off-by: Honggyu Kim <honggyu.kim@sk.com> --- Documentation/admin-guide/mm/damon/usage.rst | 8 +++++++- Documentation/mm/damon/design.rst | 4 ++++ 2 files changed, 11 insertions(+), 1 deletion(-)