From patchwork Fri Jun 28 00:32:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 13715303 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F73117999 for ; Fri, 28 Jun 2024 00:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719534790; cv=none; b=DnAo1uj2Jhlh6RoAgEkNfJWWLhtVC+fcEvFYWklMKqNlmr1byaXPiDlvJRPcxSNhhGu6HgqunNJuJ+mV6v/q5sunFRy4/4ulm2uZdsYnwMmC2KEkqhWogVnligbYVKfQt4SX6Aqx8RG0ngIdiK2pNKjlpRpnbp2/C7qHsXfJvWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719534790; c=relaxed/simple; bh=CJGq9swnF+nT4D9drA75dHGVMpCaSajJW5UVJYWywTY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NbUh+0lCyD9E8EhhY+t9Ii4oU9hZjevkvhdbEOh5Ka/BVcmtNFeZ9+aFREUiIoLi5Fl60zHNm+A4sXcQ/NLvw7ZLdRd6JDGQujq08+adeWrT8m7Owo+GqB4KhOKZ0L7PknXd1qsCKha/yvrSFfJcLx/0nT9Tr6xRAUszP5+Afog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ux8Ult7e; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ux8Ult7e" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-64aac532a60so1322097b3.0 for ; Thu, 27 Jun 2024 17:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719534784; x=1720139584; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Xi+F7PLx6UQxtCBHf6WgXD4506DRzmtVHOZna7yX+Fo=; b=ux8Ult7eVSBB1BXWoLRkdxOV4/cozOPA3oQ88O+YwtsceXaViD9k1+Ui4RsQTviNtN x+o+ZtyHarJuMWiekrrSkrCTQ/lhhmLwO4ETYFWzwH/L47RZFyIVwF0ydz2UZyl396mC WKGZlncmbUY1a5Hp0Z+UL4yGeCzp244HvB31R6INPfTQcTSCElBuvVulHsYwhpgqTbOq Kgcb9tqC1RDHOJ5mzFTcBsacN6GR+hVyvqd/2lPuX2BR3RyFWFL6wvM73AJObVbPGsRf SglIGXTA4GH4EY7K3krOU1BbZq1zRmLUrtccivyCIi4ceYGjSKRA7Jw9JJjXYZNas904 oN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719534784; x=1720139584; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xi+F7PLx6UQxtCBHf6WgXD4506DRzmtVHOZna7yX+Fo=; b=wDgBCVNRQLhYm809XVGLsabaEcD/FkbjZ4usq5V33ta+omNuHan7guIrq9a+WCrmeE Ot4ndYVCBzTX0R7TlIfUIO0QwSKF4ifQWL6/wL4pfGyjW18kjAYs5ffle+muhbP0fY+Q K3piASbLCuWNACoZpGFNiVe1cBw529y6ztAa0jMdI4QtzXotn7A79806KK4uGbQzHe6W 6RZtsShcBR0K7rbQC6HuJighEw0Rks+daKgEOxYwd36ukZnU1hWTJEeLxvByNPXntWy+ 7szM/AVK1z+YK0gsvZ4WKEpQ3+rEKitzS4LJ8OTvNP5yE4E69PaWqKXk0ExigUPuo3rR cQ5g== X-Forwarded-Encrypted: i=1; AJvYcCX6AYb2kC2GqKnBvkw3i7k17ENiU+Zo6i3602V/5Wnz9+RGFnt+kSkX9kUkgV1sib563Dt69UCMK2IRjuUm3z5lSZFeyXCMz1Yj4vc5IMupgoEL X-Gm-Message-State: AOJu0YwZT9X3cFT6Fa0mbg30rohPCRWzKMB4QEW4UcjRbn/o2vmlj5ZL vwZ3zcYKNBpoIWCYPtkX9dvrtG4l3bxaKGT1ORWydrthtBa1k4LS7UEm5sHZJL7LMD/db+pv/0u VPt+dkbuvwpvMrmBLYYYhAg== X-Google-Smtp-Source: AGHT+IE4OMB9rpE/r790kUFAawyzJg33aCJpODYngSc2r49NiR9ooIVZi3C0qsl32jNvWx6EKLYuCxnS58+1sXWsPw== X-Received: from almasrymina.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:4bc5]) (user=almasrymina job=sendgmr) by 2002:a05:690c:610d:b0:627:c0ac:a9e7 with SMTP id 00721157ae682-643ad9a859cmr5469187b3.5.1719534783826; Thu, 27 Jun 2024 17:33:03 -0700 (PDT) Date: Fri, 28 Jun 2024 00:32:41 +0000 In-Reply-To: <20240628003253.1694510-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240628003253.1694510-1-almasrymina@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Message-ID: <20240628003253.1694510-5-almasrymina@google.com> Subject: [PATCH net-next v15 04/14] netdev: netdevice devmem allocator From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , " =?utf-8?q?Christian_K=C3=B6nig?= " , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Willem de Bruijn , Kaiyuan Zhang Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov --- v11: - Fix extraneous inline directive (Paolo) v8: - Rename netdev_dmabuf_binding -> net_devmem_dmabuf_binding to avoid patch-by-patch build error. - Move niov->pp_magic/pp/pp_ref_counter usage to later patch to avoid patch-by-patch build error. v7: - netdev_ -> net_devmem_* naming (Yunsheng). v6: - Add comment on net_iov_dma_addr to explain why we don't use niov->dma_addr (Pavel) - Refactor new functions into net/core/devmem.c (Pavel) v1: - Rename devmem -> dmabuf (David). --- include/net/devmem.h | 13 +++++++++++++ include/net/netmem.h | 18 ++++++++++++++++++ net/core/devmem.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+) diff --git a/include/net/devmem.h b/include/net/devmem.h index eaf3fd965d7a8..b65795a8f8f13 100644 --- a/include/net/devmem.h +++ b/include/net/devmem.h @@ -68,7 +68,20 @@ int net_devmem_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd, void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding); int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx, struct net_devmem_dmabuf_binding *binding); +struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding); +void net_devmem_free_dmabuf(struct net_iov *ppiov); #else +static inline struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) +{ + return NULL; +} + +static inline void net_devmem_free_dmabuf(struct net_iov *ppiov) +{ +} + static inline void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) { diff --git a/include/net/netmem.h b/include/net/netmem.h index 72e932a1a9489..01dbdd216fae7 100644 --- a/include/net/netmem.h +++ b/include/net/netmem.h @@ -14,8 +14,26 @@ struct net_iov { struct dmabuf_genpool_chunk_owner *owner; + unsigned long dma_addr; }; +static inline struct dmabuf_genpool_chunk_owner * +net_iov_owner(const struct net_iov *niov) +{ + return niov->owner; +} + +static inline unsigned int net_iov_idx(const struct net_iov *niov) +{ + return niov - net_iov_owner(niov)->niovs; +} + +static inline struct net_devmem_dmabuf_binding * +net_iov_binding(const struct net_iov *niov) +{ + return net_iov_owner(niov)->binding; +} + /* netmem */ /** diff --git a/net/core/devmem.c b/net/core/devmem.c index cfb5a2f69dcd2..aeee25c91b844 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -32,6 +32,14 @@ static void net_devmem_dmabuf_free_chunk_owner(struct gen_pool *genpool, kfree(owner); } +static dma_addr_t net_devmem_get_dma_addr(const struct net_iov *niov) +{ + struct dmabuf_genpool_chunk_owner *owner = net_iov_owner(niov); + + return owner->base_dma_addr + + ((dma_addr_t)net_iov_idx(niov) << PAGE_SHIFT); +} + void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) { size_t size, avail; @@ -54,6 +62,42 @@ void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) kfree(binding); } +struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) +{ + struct dmabuf_genpool_chunk_owner *owner; + unsigned long dma_addr; + struct net_iov *niov; + ssize_t offset; + ssize_t index; + + dma_addr = gen_pool_alloc_owner(binding->chunk_pool, PAGE_SIZE, + (void **)&owner); + if (!dma_addr) + return NULL; + + offset = dma_addr - owner->base_dma_addr; + index = offset / PAGE_SIZE; + niov = &owner->niovs[index]; + + niov->dma_addr = 0; + + net_devmem_dmabuf_binding_get(binding); + + return niov; +} + +void net_devmem_free_dmabuf(struct net_iov *niov) +{ + struct net_devmem_dmabuf_binding *binding = net_iov_binding(niov); + unsigned long dma_addr = net_devmem_get_dma_addr(niov); + + if (gen_pool_has_addr(binding->chunk_pool, dma_addr, PAGE_SIZE)) + gen_pool_free(binding->chunk_pool, dma_addr, PAGE_SIZE); + + net_devmem_dmabuf_binding_put(binding); +} + /* Protected by rtnl_lock() */ static DEFINE_XARRAY_FLAGS(net_devmem_dmabuf_bindings, XA_FLAGS_ALLOC1);