diff mbox series

[v2,6/6] vsnprintf: Silence false positive GCC warning for va_format()

Message ID 20250321144822.324050-7-andriy.shevchenko@linux.intel.com (mailing list archive)
State New
Headers show
Series vsprintf: Add __printf attribute to where it's required | expand

Commit Message

Andy Shevchenko March 21, 2025, 2:40 p.m. UTC 
va_format() is using vsnprintf(), and GCC compiler (Debian 14.2.0-17)
is not happy about this:

lib/vsprintf.c:1704:9: error: function ‘va_format’ might be a candidate for ‘gnu_print ’ format attribute [-Werror=suggest-attribute=format]

Fix the compilation errors (`make W=1` when CONFIG_WERROR=y, which is default)
by silencing the false positive GCC warning.

Suggested-by: Rasmus Villemoes <ravi@prevas.dk>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/vsprintf.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 899e14e4c469..a55e88895a64 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1692,6 +1692,10 @@  char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
 	return buf;
 }
 
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
 static char *va_format(char *buf, char *end, struct va_format *va_fmt,
 		       struct printf_spec spec)
 {
@@ -1706,6 +1710,7 @@  static char *va_format(char *buf, char *end, struct va_format *va_fmt,
 
 	return buf;
 }
+#pragma GCC diagnostic pop
 
 static noinline_for_stack
 char *uuid_string(char *buf, char *end, const u8 *addr,