| Message ID | 20250407035752.1108927-2-chen.dylane@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [bpf-next,v2,1/2] bpf: Check link_create parameter for multi_kprobe | expand |
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 5cd0af80f..0f4085e8d 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -3387,6 +3387,13 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr /* no support for 32bit archs yet */ if (sizeof(u64) != sizeof(void *)) return -EOPNOTSUPP; + /* + * The target_fd sometimes will be initialized -1 such as + * probe_uprobe_multi_link in libbpf, so do not check it at the + * current stage suggested by jiri. + */ + if (attr->link_create.flags) + return -EINVAL; if (!is_uprobe_multi(prog)) return -EINVAL;
The flags in link_create no used in multi_uprobe, return -EINVAL if they assigned, keep it same as other link attach apis. And the target_fd sometimes will be initialized -1 such as probe_uprobe_multi_link in libbpf, so do not check it at the current stage suggested by jiri. Fixes: 89ae89f53d20 ("bpf: Add multi uprobe link") Signed-off-by: Tao Chen <chen.dylane@linux.dev> --- kernel/trace/bpf_trace.c | 7 +++++++ 1 file changed, 7 insertions(+)