[v3,0/2] Disable mass storage endpoints during disconnect

Message

Wesley Cheng Oct. 27, 2021, 8:10 p.m. UTC

Changes in v3:
 - Modify statement for usb_ep_enable().
 - Add explicit statement mentioning that APIs can be called in atomic context.

Changes in v2:
 - Revised comments for usb_ep_disable() as it should be safe to be
   executed in atomic contexts as well.  Other FDs are currently
   calling ep disable during the disconnect event as well.

This series calls the usb_ep_disable() API directly from fsg_disable()
as there is a possibility that UDCs that support runtime PM may
already be in a suspended state, leading to HW access while resources
are disabled.

Wesley Cheng (2):
  usb: gadget: udc: core: Revise comments for USB ep enable/disable
  usb: gadget: f_mass_storage: Disable eps during disconnect

 drivers/usb/gadget/function/f_mass_storage.c | 10 ++++++++++
 drivers/usb/gadget/udc/core.c                |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

Comments

Alan Stern Oct. 27, 2021, 8:14 p.m. UTC | #1

On Wed, Oct 27, 2021 at 01:10:05PM -0700, Wesley Cheng wrote:
> Changes in v3:
>  - Modify statement for usb_ep_enable().
>  - Add explicit statement mentioning that APIs can be called in atomic context.
> 
> Changes in v2:
>  - Revised comments for usb_ep_disable() as it should be safe to be
>    executed in atomic contexts as well.  Other FDs are currently
>    calling ep disable during the disconnect event as well.
> 
> This series calls the usb_ep_disable() API directly from fsg_disable()
> as there is a possibility that UDCs that support runtime PM may
> already be in a suspended state, leading to HW access while resources
> are disabled.
> 
> Wesley Cheng (2):
>   usb: gadget: udc: core: Revise comments for USB ep enable/disable
>   usb: gadget: f_mass_storage: Disable eps during disconnect
> 
>  drivers/usb/gadget/function/f_mass_storage.c | 10 ++++++++++
>  drivers/usb/gadget/udc/core.c                |  4 ++--
>  2 files changed, 12 insertions(+), 2 deletions(-)

For both patches:

Acked-by: Alan Stern <[e-mail]>