mbox series

[v4,0/2] Add Richtek RT1719 USBPD controller support

Message ID 1644415355-24490-1-git-send-email-u0084500@gmail.com (mailing list archive)
Headers show
Series Add Richtek RT1719 USBPD controller support | expand

Message

ChiYuan Huang Feb. 9, 2022, 2:02 p.m. UTC 
From: ChiYuan Huang <cy_huang@richtek.com>

Since v4:
1. Add Reviewed-by in dt-binding patch.
2. Remove fw_devlink_purge_absent_suppliers.
3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.

Since v3:
1. Fix checkpatch.pl consistent space error in line 332.
2. Refine some error codes to more appropriate one.
3. In psy_set_property, except prop VOLTAGE_NOW, directly return -EINVAL.
4. Use devm_kasprintf to replace devm_kzalloc and snprintf in psy_register function.

Since v2:
1. Fix below kernel test robot build warning.
>> drivers/usb/typec/rt1719.c:492:65: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     492 |                                  RT1719_EVALMODE_MASK | src_sel + 1);
         |                                                         ~~~~~~~~^~~

ChiYuan Huang (2):
  dt-bindings: usb: rt1719: Add binding for Richtek RT1719
  usb: typec: rt1719: Add support for Richtek RT1719

 .../devicetree/bindings/usb/richtek,rt1719.yaml    |  85 ++
 drivers/usb/typec/Kconfig                          |  12 +
 drivers/usb/typec/Makefile                         |   1 +
 drivers/usb/typec/rt1719.c                         | 961 +++++++++++++++++++++
 4 files changed, 1059 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
 create mode 100644 drivers/usb/typec/rt1719.c

Comments

Greg KH Feb. 9, 2022, 2:25 p.m. UTC | #1 
On Wed, Feb 09, 2022 at 10:02:33PM +0800, cy_huang wrote:
> 3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.

Why?  Either is fine, any specific reason you changed this?

thanks,

greg k-h
Heikki Krogerus Feb. 9, 2022, 2:32 p.m. UTC | #2 
On Wed, Feb 09, 2022 at 03:25:19PM +0100, Greg KH wrote:
> On Wed, Feb 09, 2022 at 10:02:33PM +0800, cy_huang wrote:
> > 3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.
> 
> Why?  Either is fine, any specific reason you changed this?

Because I proposed it. I believe everything scripts/checkpatch.pl
tells me.

thanks,
Greg KH Feb. 9, 2022, 2:54 p.m. UTC | #3 
On Wed, Feb 09, 2022 at 04:32:34PM +0200, Heikki Krogerus wrote:
> On Wed, Feb 09, 2022 at 03:25:19PM +0100, Greg KH wrote:
> > On Wed, Feb 09, 2022 at 10:02:33PM +0800, cy_huang wrote:
> > > 3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.
> > 
> > Why?  Either is fine, any specific reason you changed this?
> 
> Because I proposed it. I believe everything scripts/checkpatch.pl
> tells me.

Ah, you believe everything a perl script says, be careful :)
Heikki Krogerus Feb. 9, 2022, 2:56 p.m. UTC | #4 
On Wed, Feb 09, 2022 at 04:32:38PM +0200, Heikki Krogerus wrote:
> On Wed, Feb 09, 2022 at 03:25:19PM +0100, Greg KH wrote:
> > On Wed, Feb 09, 2022 at 10:02:33PM +0800, cy_huang wrote:
> > > 3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.
> > 
> > Why?  Either is fine, any specific reason you changed this?
> 
> Because I proposed it. I believe everything scripts/checkpatch.pl
> tells me.

It looks like the preference on "GPL" is pretty resent. Check commit
bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2"
bogosity").

thanks,
ChiYuan Huang Feb. 9, 2022, 3:07 p.m. UTC | #5 
Hi, Greg, Heikki:
Heikki Krogerus <heikki.krogerus@linux.intel.com> 於 2022年2月9日 週三 下午10:56寫道：
>
> On Wed, Feb 09, 2022 at 04:32:38PM +0200, Heikki Krogerus wrote:
> > On Wed, Feb 09, 2022 at 03:25:19PM +0100, Greg KH wrote:
> > > On Wed, Feb 09, 2022 at 10:02:33PM +0800, cy_huang wrote:
> > > > 3. Change MODULE_LICENSE from 'GPL v2' to 'GPL'.
> > >
> > > Why?  Either is fine, any specific reason you changed this?
> >
> > Because I proposed it. I believe everything scripts/checkpatch.pl
> > tells me.
>
> It looks like the preference on "GPL" is pretty resent. Check commit
> bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2"
> bogosity").
>
> thanks,
>
It seems to revert it back to 'GPL v2' is proper.
I'll resend the v5 to change the license back to 'GPL v2'.
And add the Reviewed-by tags.
Thanks.
> --
> heikki