From patchwork Mon Mar 6 18:32:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elson Roy Serrao X-Patchwork-Id: 13162158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE029C6FD1C for ; Mon, 6 Mar 2023 18:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbjCFSdo (ORCPT ); Mon, 6 Mar 2023 13:33:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbjCFSdk (ORCPT ); Mon, 6 Mar 2023 13:33:40 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200C53B3F4; Mon, 6 Mar 2023 10:33:06 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 326AxVIL008442; Mon, 6 Mar 2023 18:32:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id; s=qcppdkim1; bh=jX7TiP9sbtiAIjTOMCwck5/ZOER8fIpAIp2/bY4ZGIU=; b=mZ69QLb2E31aMxxz5ZSBMRyEl/GsArLIUMBWquQcRpxR4hrcRhWFoHSkGlfk2t8VbEyC hrBtRrIrF/GNvVr3tIStnxDm2SPktKCo2ooEXPx2Gzrzdg1Pdel98B9QPYkmOjRLVTp3 WvAN36Li9MogFXE7uUMrM1xNQ6+Nk+Avn5MajsyVL3XX/7u/TFpMsadlB2sfqX0FUyDE KLW8bydBy0akWYqGheem3caKie+fe9AOYL75hXoI+Xaub1BcN/hQgUPgHred6RA53vB2 KyOW0a3Y8kes8/vl2spU59WtwCoHZaZ+HE6v0ZmWb4/nlkqMvG5/3TSJJnuUh2GFGU73 VQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p417d5n2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 18:32:52 +0000 Received: from pps.filterd (NALASPPMTA04.qualcomm.com [127.0.0.1]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 326IWplg014331; Mon, 6 Mar 2023 18:32:51 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA04.qualcomm.com (PPS) with ESMTPS id 3p4few1h6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 06 Mar 2023 18:32:51 +0000 Received: from NALASPPMTA04.qualcomm.com (NALASPPMTA04.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 326ITW7n007846; Mon, 6 Mar 2023 18:32:51 GMT Received: from hu-devc-lv-c.qualcomm.com (hu-eserrao-lv.qualcomm.com [10.47.235.164]) by NALASPPMTA04.qualcomm.com (PPS) with ESMTP id 326IWo58014317; Mon, 06 Mar 2023 18:32:50 +0000 Received: by hu-devc-lv-c.qualcomm.com (Postfix, from userid 464172) id B24DB20E38; Mon, 6 Mar 2023 10:32:50 -0800 (PST) From: Elson Roy Serrao To: gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, balbi@kernel.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, Elson Roy Serrao Subject: [PATCH v6 0/5] Add function suspend/resume and remote wakeup support Date: Mon, 6 Mar 2023 10:32:43 -0800 Message-Id: <1678127568-10609-1-git-send-email-quic_eserrao@quicinc.com> X-Mailer: git-send-email 2.7.4 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: jimiZ_9kd9ZQbhN6o8_GkgwTI6kDNtgS X-Proofpoint-ORIG-GUID: jimiZ_9kd9ZQbhN6o8_GkgwTI6kDNtgS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_12,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxlogscore=752 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060163 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Changes in v6 - Combined usb_gadget_func_wakeup API with usb_func_wakeup API in composite layer so that there is only 1 API for triggering function remote wakeup for better error handling. Since function suspend is something specific to usb functions, better to keep the related APIs in composite layer and above. Also documented the usage and applicability of the usb_func_wakeup API. Changes in v5 - Add wakeup_armed check in patch2 in the link status change event handler so that resume gets triggeed only in the remote wakeup context. - Costmetic changes in patch3 and patch4 Changes in v4 - Moved the wakeup bit check to bind function for warning the user at an early stage itself. - Added the remote wakeup configured check to gadget_wakeup() and func_wakeup() routines so that wakeup can be triggered only if user has configured it. - Cosmetic changes with respect to renaming the variables to reflect the operation better. Changes in v3 - Modified rw_capable flag to reflect the gadgets capability for wakeup signalling. - Added a check to configure wakeup bit in bmAttributes only if gadget is capable of triggering wakeup. - Implemented a gadget op for composite layer to inform UDC whether device is configured for remote wakeup. - Added a check in __usb_gadget_wakeup() API to trigger wakeup only if the device is configured for it. - Cosmetic changes in dwc3_gadget_func_wakeup() API. Changes in v2 - Added a flag to indicate whether the device is remote wakeup capable. - Added an async parameter to _dwc3_gadget_wakeup() API and few cosmetic changes. - Added flags to reflect the state of function suspend and function remote wakeup to usb_function struct rather than function specific struct (f_ecm). - Changed the dwc3_gadget_func__wakeup() API to run synchronously by first checking the link state and then sending the device notification. Also added debug log for DEVICE_NOTIFICATION generic cmd. - Added changes to arm the device for remotewakeup/function remotewakeup only if device is capable. An usb device can initate a remote wakeup and bring the link out of suspend as dictated by the DEVICE_REMOTE_WAKEUP feature selector. To achieve this an interface can invoke gadget_wakeup op and wait for the device to come out of LPM. But the current polling based implementation fails if the host takes a long time to drive the resume signaling specially in high speed capable devices. Switching to an interrupt based approach is more robust and efficient. This can be leveraged by enabling link status change events and triggering a gadget resume when the link comes to active state. If the device is enhanced super-speed capable, individual interfaces can also be put into suspend state. An interface can be in function suspend state even when the device is not in suspend state. Function suspend state is retained throughout the device suspend entry and exit process. A function can be put to function suspend through FUNCTION_SUSPEND feature selector sent by the host. This setup packet also decides whether that function is capable of initiating a function remote wakeup. When the function sends a wakeup notification to the host the link must be first brought to a non-U0 state and then this notification is sent. This change adds the infrastructure needed to support the above functionalities. Elson Roy Serrao (5): usb: gadget: Properly configure the device for remote wakeup usb: dwc3: Add remote wakeup handling usb: gadget: Add function wakeup support usb: dwc3: Add function suspend and function wakeup support usb: gadget: f_ecm: Add suspend/resume and remote wakeup support drivers/usb/dwc3/core.h | 5 ++ drivers/usb/dwc3/debug.h | 2 + drivers/usb/dwc3/ep0.c | 16 ++--- drivers/usb/dwc3/gadget.c | 118 ++++++++++++++++++++++++++++++++-- drivers/usb/gadget/composite.c | 58 +++++++++++++++++ drivers/usb/gadget/configfs.c | 3 + drivers/usb/gadget/function/f_ecm.c | 68 ++++++++++++++++++++ drivers/usb/gadget/function/u_ether.c | 63 ++++++++++++++++++ drivers/usb/gadget/function/u_ether.h | 4 ++ drivers/usb/gadget/udc/core.c | 27 ++++++++ drivers/usb/gadget/udc/trace.h | 5 ++ include/linux/usb/composite.h | 8 +++ include/linux/usb/gadget.h | 9 +++ 13 files changed, 372 insertions(+), 14 deletions(-)