mbox series

[v2,0/2] USB Storage quirk for SMI SM3350

Message ID 20190103032618.9237-1-icenowy@aosc.io (mailing list archive)
Headers show
Series USB Storage quirk for SMI SM3350 | expand

Message

Icenowy Zheng Jan. 3, 2019, 3:26 a.m. UTC
SMI SM3350 UFS-USB bridge controller cannot handle REQUEST SENSE command
with long sense (96-bytes) well, and will even trap the controller into
a state that refuses to do read/write command.

Currently Linux uncondintionally set US_FL_SANE_SENSE for devices
claiming SPC3+, which makes simply add US_FL_BAD_SENSE for SM3350 fail
(as it claims SPC4).

Fix this conflicting quirk issue, and add the quirk for SM3350.

Icenowy Zheng (2):
  USB: storage: don't insert sane sense for SPC3+ when bad sense
    specified
  USB: storage: add quirk for SMI SM3350

 drivers/usb/storage/scsiglue.c     |  8 ++++++--
 drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

Comments

Alan Stern Jan. 3, 2019, 3:06 p.m. UTC | #1
On Thu, 3 Jan 2019, Icenowy Zheng wrote:

> SMI SM3350 UFS-USB bridge controller cannot handle REQUEST SENSE command
> with long sense (96-bytes) well, and will even trap the controller into
> a state that refuses to do read/write command.
> 
> Currently Linux uncondintionally set US_FL_SANE_SENSE for devices
> claiming SPC3+, which makes simply add US_FL_BAD_SENSE for SM3350 fail
> (as it claims SPC4).
> 
> Fix this conflicting quirk issue, and add the quirk for SM3350.
> 
> Icenowy Zheng (2):
>   USB: storage: don't insert sane sense for SPC3+ when bad sense
>     specified
>   USB: storage: add quirk for SMI SM3350
> 
>  drivers/usb/storage/scsiglue.c     |  8 ++++++--
>  drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)

For both patches:

Acked-by: Alan Stern <stern@rowland.harvard.edu>