| Message ID | 20190814132419.39759-1-heikki.krogerus@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: typec: fusb302: Small changes | expand |
Hi, On 14-08-19 15:24, Heikki Krogerus wrote: > Hi, > > This series removes the deprecated fusb302 specific properties, and > stops using struct tcpc_config in the driver. Series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> This has a small conflict with my "[PATCH] usb: typec: fusb302: Call fusb302_debugfs_init earlier" patch. Since we've agreed to do the rootdir leak fix as a separate patch (which I will write when I find some time probably tomorrow), I was wondering if we can merge my patch first. I would like to see a "Cc: stable@vger.kernel.org" added to my patch and then it would be good to have it merged first. Regardless we should probable prepare one series with all patches for Greg to make this easy to merge for him. Shall I combine this series + my fix + my to be written fix into 1 series, test that on actual hardware and then post that? Regards, Hans
On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 15:24, Heikki Krogerus wrote: > > Hi, > > > > This series removes the deprecated fusb302 specific properties, and > > stops using struct tcpc_config in the driver. > > Series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > This has a small conflict with my > "[PATCH] usb: typec: fusb302: Call fusb302_debugfs_init earlier" > patch. Oh, damn it. Sorry. > Since we've agreed to do the rootdir leak fix as a separate patch > (which I will write when I find some time probably tomorrow), I > was wondering if we can merge my patch first. I would like to see > a "Cc: stable@vger.kernel.org" added to my patch and then it would > be good to have it merged first. > > Regardless we should probable prepare one series with all patches > for Greg to make this easy to merge for him. > > Shall I combine this series + my fix + my to be written fix into > 1 series, test that on actual hardware and then post that? That works for me. thanks,
On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 15:24, Heikki Krogerus wrote: > > Hi, > > > > This series removes the deprecated fusb302 specific properties, and > > stops using struct tcpc_config in the driver. > > Series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > This has a small conflict with my > "[PATCH] usb: typec: fusb302: Call fusb302_debugfs_init earlier" > patch. > > Since we've agreed to do the rootdir leak fix as a separate patch > (which I will write when I find some time probably tomorrow), I > was wondering if we can merge my patch first. I would like to see > a "Cc: stable@vger.kernel.org" added to my patch and then it would > be good to have it merged first. > > Regardless we should probable prepare one series with all patches > for Greg to make this easy to merge for him. I'll take this series now, and you can redo your patch based on my usb-next branch with them in it. thanks, greg k-h
Hi, On 15-08-19 14:55, Greg Kroah-Hartman wrote: > On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote: >> Hi, >> >> On 14-08-19 15:24, Heikki Krogerus wrote: >>> Hi, >>> >>> This series removes the deprecated fusb302 specific properties, and >>> stops using struct tcpc_config in the driver. >> >> Series looks good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> >> This has a small conflict with my >> "[PATCH] usb: typec: fusb302: Call fusb302_debugfs_init earlier" >> patch. >> >> Since we've agreed to do the rootdir leak fix as a separate patch >> (which I will write when I find some time probably tomorrow), I >> was wondering if we can merge my patch first. I would like to see >> a "Cc: stable@vger.kernel.org" added to my patch and then it would >> be good to have it merged first. >> >> Regardless we should probable prepare one series with all patches >> for Greg to make this easy to merge for him. > > I'll take this series now, and you can redo your patch based on my > usb-next branch with them in it. Ok. Regards, Hans
Hi, On 14-08-19 15:24, Heikki Krogerus wrote: > Hi, > > This series removes the deprecated fusb302 specific properties, and > stops using struct tcpc_config in the driver. > > thanks, > > Heikki Krogerus (3): > usb: typec: fusb302: Remove unused properties > dt-bindings: usb: fusb302: Remove deprecated properties > usb: typec: fusb302: Always provide fwnode for the port I know this series is already in usb-testing, still I thought it would be a good idea to test it on my CHT hw with a fusb302 TypeC controller. So I've just completed testing this and it works as advertised: So FWIW: Tested-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans
On Thu, Aug 15, 2019 at 07:26:42PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 15:24, Heikki Krogerus wrote: > > Hi, > > > > This series removes the deprecated fusb302 specific properties, and > > stops using struct tcpc_config in the driver. > > > > thanks, > > > > Heikki Krogerus (3): > > usb: typec: fusb302: Remove unused properties > > dt-bindings: usb: fusb302: Remove deprecated properties > > usb: typec: fusb302: Always provide fwnode for the port > > I know this series is already in usb-testing, still I thought > it would be a good idea to test it on my CHT hw with a fusb302 > TypeC controller. So I've just completed testing this and it > works as advertised: > > So FWIW: > > Tested-by: Hans de Goede <hdegoede@redhat.com> Thanks, I'll go add this as I can rebase that branch... greg k-h