[0/2] usb: roles: intel: Use static mode by default

Message

Heikki Krogerus Aug. 26, 2019, 2:32 p.m. UTC

Hi Hans,

These have been in my queue for a while now. For some reason I've been
under the impression that there was still an issue with them, but that
was a misunderstanding. Saranya and Balaji, I'm really sorry about
that.

Hans, I don't know if you remember these, but they address an issue
where the device mode does not work (I think on APL). I believe static
mode is used always except on Cherrytrail. You had reported that using the
static mode creates a conflict on some CHT boards that have ACPI tables that
also write to the mux registers. To prevent the use of the static mode on
Cherrytrail the property is used.

thanks,

Saranya Gopal (2):
  usb: xhci: ext-caps: Add property to disable Intel SW switch
  usb: roles: intel: Enable static DRD mode for role switch

 drivers/usb/host/xhci-ext-caps.c              | 18 +++++++++++++
 .../usb/roles/intel-xhci-usb-role-switch.c    | 26 ++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletion(-)

Comments

Hans de Goede Aug. 27, 2019, 1:37 p.m. UTC | #1

Hi Heikki,

On 26-08-19 16:32, Heikki Krogerus wrote:
> Hi Hans,
> 
> These have been in my queue for a while now. For some reason I've been
> under the impression that there was still an issue with them, but that
> was a misunderstanding. Saranya and Balaji, I'm really sorry about
> that.
> 
> Hans, I don't know if you remember these, but they address an issue
> where the device mode does not work (I think on APL). I believe static
> mode is used always except on Cherrytrail. You had reported that using the
> static mode creates a conflict on some CHT boards that have ACPI tables that
> also write to the mux registers. To prevent the use of the static mode on
> Cherrytrail the property is used.

I've given this a test-run on a Cherry Trail device which used ACPI
_AEI handlers to do the mux switching as well as on 2 models (1 with
micro-usb id-pin, one with a Type-C fusb302 controller) where the
kernel does the switching.

I can confirm that with these patches applied things still work fine
on all 3 models.

With that said I do have some review remarks on the second patch
I will reply to that patch with my remarks.

Regards,

Hans



> Saranya Gopal (2):
>    usb: xhci: ext-caps: Add property to disable Intel SW switch
>    usb: roles: intel: Enable static DRD mode for role switch
> 
>   drivers/usb/host/xhci-ext-caps.c              | 18 +++++++++++++
>   .../usb/roles/intel-xhci-usb-role-switch.c    | 26 ++++++++++++++++++-
>   2 files changed, 43 insertions(+), 1 deletion(-)
>