| Message ID | 20191021112524.79550-1-heikki.krogerus@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: typec: API improvements | expand |
Hi Heikki, > -----Original Message----- > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> > On Behalf Of Heikki Krogerus > Sent: Monday, October 21, 2019 4:25 AM > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta <ajayg@nvidia.com>; > linux-usb@vger.kernel.org > Subject: [PATCH 00/18] usb: typec: API improvements > > Hi, > > The first patches in this series (patches 1-8) introduce a small change to the > USB Type-C Connector Class API. Guenter was kind enough to go over those > already. > > Patches 10-15 improve the ucsi driver API by introducing more traditional read > and write routines, and the rest is more generic optimisations and > improvements to the ucsi drivers. > > Let me know if there is anything you want to be changed. This patch set is not taking care of issues discussed at following thread. https://marc.info/?l=linux-usb&m=156995500624107&w=2 https://marc.info/?l=linux-usb&m=157012261301682&w=2 We need fixes for above issues so that we can easily manage ppms which has multiple DP altmodes as discussed in below link. https://marc.info/?l=linux-usb&m=156778906010780&w=2 Thanks > nvpublic > thanks, > > Heikki Krogerus (18): > usb: typec: Copy everything from struct typec_capability during > registration > usb: typec: Introduce typec_get_drvdata() > usb: typec: Separate the operations vector > usb: typec: tcpm: Start using struct typec_operations > usb: typec: tps6598x: Start using struct typec_operations > usb: typec: ucsi: Start using struct typec_operations > usb: typec: hd3ss3220: Start using struct typec_operations > usb: typec: Remove the callback members from struct typec_capability > usb: typec: Remove unused members from struct typec_capability > usb: typec: hd3ss3220: Give the connector fwnode to the port device > usb: typec: ucsi: Simplified registration and I/O API > usb: typec: ucsi: acpi: Move to the new API > usb: typec: ucsi: ccg: Move to the new API > usb: typec: ucsi: Remove the old API > usb: typec: ucsi: Remove struct ucsi_control > usb: typec: ucsi: Remove all bit-fields > usb: typec: ucsi: New error codes > usb: typec: ucsi: Optimise ucsi_unregister() > > drivers/usb/typec/class.c | 42 +- > drivers/usb/typec/hd3ss3220.c | 36 +- > drivers/usb/typec/tcpm/tcpm.c | 45 +- > drivers/usb/typec/tps6598x.c | 49 ++- > drivers/usb/typec/ucsi/displayport.c | 40 +- > drivers/usb/typec/ucsi/trace.c | 11 - > drivers/usb/typec/ucsi/trace.h | 79 +--- > drivers/usb/typec/ucsi/ucsi.c | 606 ++++++++++++++------------- > drivers/usb/typec/ucsi/ucsi.h | 417 +++++++----------- > drivers/usb/typec/ucsi/ucsi_acpi.c | 94 ++++- > drivers/usb/typec/ucsi/ucsi_ccg.c | 170 ++++---- > include/linux/usb/typec.h | 41 +- > 12 files changed, 774 insertions(+), 856 deletions(-) > > -- > 2.23.0
On Mon, Oct 21, 2019 at 08:41:16PM +0000, Ajay Gupta wrote: > Hi Heikki, > > > -----Original Message----- > > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> > > On Behalf Of Heikki Krogerus > > Sent: Monday, October 21, 2019 4:25 AM > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta <ajayg@nvidia.com>; > > linux-usb@vger.kernel.org > > Subject: [PATCH 00/18] usb: typec: API improvements > > > > Hi, > > > > The first patches in this series (patches 1-8) introduce a small change to the > > USB Type-C Connector Class API. Guenter was kind enough to go over those > > already. > > > > Patches 10-15 improve the ucsi driver API by introducing more traditional read > > and write routines, and the rest is more generic optimisations and > > improvements to the ucsi drivers. > > > > Let me know if there is anything you want to be changed. > This patch set is not taking care of issues discussed at following thread. > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > We need fixes for above issues so that we can easily manage ppms > which has multiple DP altmodes as discussed in below link. > https://marc.info/?l=linux-usb&m=156778906010780&w=2 The goal of this series is not to solve that "issue". This series is the base work that really has to be done in any case before we add any kind of solution for the multi DP alt mode case. Rest assured that we will have support for that soon enough, but let's just move one step at a time. thanks,
Hi Heikki, > -----Original Message----- > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> > On Behalf Of Heikki Krogerus > Sent: Tuesday, October 22, 2019 12:41 AM > To: Ajay Gupta <ajayg@nvidia.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck > <linux@roeck-us.net>; linux-usb@vger.kernel.org > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > On Mon, Oct 21, 2019 at 08:41:16PM +0000, Ajay Gupta wrote: > > Hi Heikki, > > > > > -----Original Message----- > > > From: linux-usb-owner@vger.kernel.org > > > <linux-usb-owner@vger.kernel.org> On Behalf Of Heikki Krogerus > > > Sent: Monday, October 21, 2019 4:25 AM > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta > > > <ajayg@nvidia.com>; linux-usb@vger.kernel.org > > > Subject: [PATCH 00/18] usb: typec: API improvements > > > > > > Hi, > > > > > > The first patches in this series (patches 1-8) introduce a small > > > change to the USB Type-C Connector Class API. Guenter was kind > > > enough to go over those already. > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > traditional read and write routines, and the rest is more generic > > > optimisations and improvements to the ucsi drivers. > > > > > > Let me know if there is anything you want to be changed. > > This patch set is not taking care of issues discussed at following thread. > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > We need fixes for above issues so that we can easily manage ppms which > > has multiple DP altmodes as discussed in below link. > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > The goal of this series is not to solve that "issue". > > This series is the base work that really has to be done in any case before we > add any kind of solution for the multi DP alt mode case. > Rest assured that we will have support for that soon enough, but let's just > move one step at a time. Ok, sounds good. I tested the series on NVIDIA GPU for ucsi_ccg and it works fine. thanks > nvpublic > > thanks, > > -- > heikki
On Tue, Oct 22, 2019 at 08:43:40PM +0000, Ajay Gupta wrote: > Hi Heikki, > > > -----Original Message----- > > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> > > On Behalf Of Heikki Krogerus > > Sent: Tuesday, October 22, 2019 12:41 AM > > To: Ajay Gupta <ajayg@nvidia.com> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck > > <linux@roeck-us.net>; linux-usb@vger.kernel.org > > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > > > On Mon, Oct 21, 2019 at 08:41:16PM +0000, Ajay Gupta wrote: > > > Hi Heikki, > > > > > > > -----Original Message----- > > > > From: linux-usb-owner@vger.kernel.org > > > > <linux-usb-owner@vger.kernel.org> On Behalf Of Heikki Krogerus > > > > Sent: Monday, October 21, 2019 4:25 AM > > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta > > > > <ajayg@nvidia.com>; linux-usb@vger.kernel.org > > > > Subject: [PATCH 00/18] usb: typec: API improvements > > > > > > > > Hi, > > > > > > > > The first patches in this series (patches 1-8) introduce a small > > > > change to the USB Type-C Connector Class API. Guenter was kind > > > > enough to go over those already. > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > > traditional read and write routines, and the rest is more generic > > > > optimisations and improvements to the ucsi drivers. > > > > > > > > Let me know if there is anything you want to be changed. > > > This patch set is not taking care of issues discussed at following thread. > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > We need fixes for above issues so that we can easily manage ppms which > > > has multiple DP altmodes as discussed in below link. > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > The goal of this series is not to solve that "issue". > > > > This series is the base work that really has to be done in any case before we > > add any kind of solution for the multi DP alt mode case. > > Rest assured that we will have support for that soon enough, but let's just > > move one step at a time. > Ok, sounds good. I tested the series on NVIDIA GPU for ucsi_ccg and it works fine. Thanks Ajay. So can I use your "Tested-by" tag? Br,
Hi Heikki > -----Original Message----- > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> > On Behalf Of Heikki Krogerus > Sent: Wednesday, October 23, 2019 1:06 AM > To: Ajay Gupta <ajayg@nvidia.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck > <linux@roeck-us.net>; linux-usb@vger.kernel.org > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > On Tue, Oct 22, 2019 at 08:43:40PM +0000, Ajay Gupta wrote: > > Hi Heikki, > > > > > -----Original Message----- > > > From: linux-usb-owner@vger.kernel.org > > > <linux-usb-owner@vger.kernel.org> On Behalf Of Heikki Krogerus > > > Sent: Tuesday, October 22, 2019 12:41 AM > > > To: Ajay Gupta <ajayg@nvidia.com> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck > > > <linux@roeck-us.net>; linux-usb@vger.kernel.org > > > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > > > > > On Mon, Oct 21, 2019 at 08:41:16PM +0000, Ajay Gupta wrote: > > > > Hi Heikki, > > > > > > > > > -----Original Message----- > > > > > From: linux-usb-owner@vger.kernel.org > > > > > <linux-usb-owner@vger.kernel.org> On Behalf Of Heikki Krogerus > > > > > Sent: Monday, October 21, 2019 4:25 AM > > > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > Cc: Guenter Roeck <linux@roeck-us.net>; Ajay Gupta > > > > > <ajayg@nvidia.com>; linux-usb@vger.kernel.org > > > > > Subject: [PATCH 00/18] usb: typec: API improvements > > > > > > > > > > Hi, > > > > > > > > > > The first patches in this series (patches 1-8) introduce a small > > > > > change to the USB Type-C Connector Class API. Guenter was kind > > > > > enough to go over those already. > > > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > > > traditional read and write routines, and the rest is more > > > > > generic optimisations and improvements to the ucsi drivers. > > > > > > > > > > Let me know if there is anything you want to be changed. > > > > This patch set is not taking care of issues discussed at following thread. > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > > > We need fixes for above issues so that we can easily manage ppms > > > > which has multiple DP altmodes as discussed in below link. > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > > > The goal of this series is not to solve that "issue". > > > > > > This series is the base work that really has to be done in any case > > > before we add any kind of solution for the multi DP alt mode case. > > > Rest assured that we will have support for that soon enough, but > > > let's just move one step at a time. > > Ok, sounds good. I tested the series on NVIDIA GPU for ucsi_ccg and it works > fine. > > Thanks Ajay. So can I use your "Tested-by" tag? Sure, I will add it in v2 series. thanks > nvpublic > Br, > > -- > heikki
Hi Heikki, > > > > > > The first patches in this series (patches 1-8) introduce a > > > > > > small change to the USB Type-C Connector Class API. Guenter > > > > > > was kind enough to go over those already. > > > > > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > > > > traditional read and write routines, and the rest is more > > > > > > generic optimisations and improvements to the ucsi drivers. > > > > > > > > > > > > Let me know if there is anything you want to be changed. > > > > > This patch set is not taking care of issues discussed at following thread. > > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > > > > > We need fixes for above issues so that we can easily manage ppms > > > > > which has multiple DP altmodes as discussed in below link. > > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > > > > > The goal of this series is not to solve that "issue". > > > > > > > > This series is the base work that really has to be done in any > > > > case before we add any kind of solution for the multi DP alt mode case. > > > > Rest assured that we will have support for that soon enough, but > > > > let's just move one step at a time. Since this series is gone so what is the plan for updated changes as discussed at https://marc.info/?l=linux-usb&m=157079026214073&w=2 This is needed to support ppms which has multiple DP altmodes as discussed at https://marc.info/?l=linux-usb&m=156778906010780&w=2 Thanks > nvpublic > > > Ok, sounds good. I tested the series on NVIDIA GPU for ucsi_ccg and > > > it works > > fine. > > > > Thanks Ajay. So can I use your "Tested-by" tag? > Sure, I will add it in v2 series. > > thanks > > nvpublic > > Br, > > > > -- > > heikki
Hi Ajay, On Mon, Nov 11, 2019 at 04:51:05PM +0000, Ajay Gupta wrote: > Hi Heikki, > > > > > > > The first patches in this series (patches 1-8) introduce a > > > > > > > small change to the USB Type-C Connector Class API. Guenter > > > > > > > was kind enough to go over those already. > > > > > > > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > > > > > traditional read and write routines, and the rest is more > > > > > > > generic optimisations and improvements to the ucsi drivers. > > > > > > > > > > > > > > Let me know if there is anything you want to be changed. > > > > > > This patch set is not taking care of issues discussed at following thread. > > > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > > > > > > > We need fixes for above issues so that we can easily manage ppms > > > > > > which has multiple DP altmodes as discussed in below link. > > > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > > > > > > > The goal of this series is not to solve that "issue". > > > > > > > > > > This series is the base work that really has to be done in any > > > > > case before we add any kind of solution for the multi DP alt mode case. > > > > > Rest assured that we will have support for that soon enough, but > > > > > let's just move one step at a time. > Since this series is gone so what is the plan for updated changes as > discussed at > https://marc.info/?l=linux-usb&m=157079026214073&w=2 > > This is needed to support ppms which has multiple DP altmodes as > discussed at > https://marc.info/?l=linux-usb&m=156778906010780&w=2 Give me a few more weeks. I'm sorry for the delay, but I have to finish some other tasks. Can you work on this in the mean time? thanks,
On Tue, Nov 12, 2019 at 01:00:34PM +0200, Heikki Krogerus wrote: > Hi Ajay, > > On Mon, Nov 11, 2019 at 04:51:05PM +0000, Ajay Gupta wrote: > > Hi Heikki, > > > > > > > > The first patches in this series (patches 1-8) introduce a > > > > > > > > small change to the USB Type-C Connector Class API. Guenter > > > > > > > > was kind enough to go over those already. > > > > > > > > > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing more > > > > > > > > traditional read and write routines, and the rest is more > > > > > > > > generic optimisations and improvements to the ucsi drivers. > > > > > > > > > > > > > > > > Let me know if there is anything you want to be changed. > > > > > > > This patch set is not taking care of issues discussed at following thread. > > > > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > > > > > > > > > We need fixes for above issues so that we can easily manage ppms > > > > > > > which has multiple DP altmodes as discussed in below link. > > > > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > > > > > > > > > The goal of this series is not to solve that "issue". > > > > > > > > > > > > This series is the base work that really has to be done in any > > > > > > case before we add any kind of solution for the multi DP alt mode case. > > > > > > Rest assured that we will have support for that soon enough, but > > > > > > let's just move one step at a time. > > Since this series is gone so what is the plan for updated changes as > > discussed at > > https://marc.info/?l=linux-usb&m=157079026214073&w=2 > > > > This is needed to support ppms which has multiple DP altmodes as > > discussed at > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > Give me a few more weeks. I'm sorry for the delay, but I have to > finish some other tasks. Can you work on this in the mean time? Actually, if you can prepare the proposal you had earlier, I think we can just go ahead with it now. If I have some "better" idea how to handle the multi-DP alt modes, then I can prepare a separate proposal for it after we have your initial solution. I do have an idea for a solution, but I don't want to block this any longer. thanks,
Hi Heikki, > -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Sent: Tuesday, November 12, 2019 3:07 AM > To: Ajay Gupta <ajayg@nvidia.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Guenter Roeck > <linux@roeck-us.net>; linux-usb@vger.kernel.org > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > On Tue, Nov 12, 2019 at 01:00:34PM +0200, Heikki Krogerus wrote: > > Hi Ajay, > > > > On Mon, Nov 11, 2019 at 04:51:05PM +0000, Ajay Gupta wrote: > > > Hi Heikki, > > > > > > > > > The first patches in this series (patches 1-8) introduce > > > > > > > > > a small change to the USB Type-C Connector Class API. > > > > > > > > > Guenter was kind enough to go over those already. > > > > > > > > > > > > > > > > > > Patches 10-15 improve the ucsi driver API by introducing > > > > > > > > > more traditional read and write routines, and the rest > > > > > > > > > is more generic optimisations and improvements to the ucsi > drivers. > > > > > > > > > > > > > > > > > > Let me know if there is anything you want to be changed. > > > > > > > > This patch set is not taking care of issues discussed at following > thread. > > > > > > > > https://marc.info/?l=linux-usb&m=156995500624107&w=2 > > > > > > > > https://marc.info/?l=linux-usb&m=157012261301682&w=2 > > > > > > > > > > > > > > > > We need fixes for above issues so that we can easily > > > > > > > > manage ppms which has multiple DP altmodes as discussed in > below link. > > > > > > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > > > > > > > > > > > The goal of this series is not to solve that "issue". > > > > > > > > > > > > > > This series is the base work that really has to be done in > > > > > > > any case before we add any kind of solution for the multi DP alt > mode case. > > > > > > > Rest assured that we will have support for that soon enough, > > > > > > > but let's just move one step at a time. > > > Since this series is gone so what is the plan for updated changes as > > > discussed at > > > https://marc.info/?l=linux-usb&m=157079026214073&w=2 > > > > > > This is needed to support ppms which has multiple DP altmodes as > > > discussed at > > > https://marc.info/?l=linux-usb&m=156778906010780&w=2 > > > > Give me a few more weeks. I'm sorry for the delay, but I have to > > finish some other tasks. Can you work on this in the mean time? > > Actually, if you can prepare the proposal you had earlier, I think we can just go > ahead with it now. My idea is proposed at https://marc.info/?l=linux-usb&m=156875897316318&w=2 Are you referring to it? If yes, I can rebase the change and post it. Thanks > nvpublic > If I have some "better" idea how to handle the multi-DP alt > modes, then I can prepare a separate proposal for it after we have your initial > solution. I do have an idea for a solution, but I don't want to block this any > longer. > > > thanks, > > -- > heikki
Hi, The first patches in this series (patches 1-8) introduce a small change to the USB Type-C Connector Class API. Guenter was kind enough to go over those already. Patches 10-15 improve the ucsi driver API by introducing more traditional read and write routines, and the rest is more generic optimisations and improvements to the ucsi drivers. Let me know if there is anything you want to be changed. thanks, Heikki Krogerus (18): usb: typec: Copy everything from struct typec_capability during registration usb: typec: Introduce typec_get_drvdata() usb: typec: Separate the operations vector usb: typec: tcpm: Start using struct typec_operations usb: typec: tps6598x: Start using struct typec_operations usb: typec: ucsi: Start using struct typec_operations usb: typec: hd3ss3220: Start using struct typec_operations usb: typec: Remove the callback members from struct typec_capability usb: typec: Remove unused members from struct typec_capability usb: typec: hd3ss3220: Give the connector fwnode to the port device usb: typec: ucsi: Simplified registration and I/O API usb: typec: ucsi: acpi: Move to the new API usb: typec: ucsi: ccg: Move to the new API usb: typec: ucsi: Remove the old API usb: typec: ucsi: Remove struct ucsi_control usb: typec: ucsi: Remove all bit-fields usb: typec: ucsi: New error codes usb: typec: ucsi: Optimise ucsi_unregister() drivers/usb/typec/class.c | 42 +- drivers/usb/typec/hd3ss3220.c | 36 +- drivers/usb/typec/tcpm/tcpm.c | 45 +- drivers/usb/typec/tps6598x.c | 49 ++- drivers/usb/typec/ucsi/displayport.c | 40 +- drivers/usb/typec/ucsi/trace.c | 11 - drivers/usb/typec/ucsi/trace.h | 79 +--- drivers/usb/typec/ucsi/ucsi.c | 606 ++++++++++++++------------- drivers/usb/typec/ucsi/ucsi.h | 417 +++++++----------- drivers/usb/typec/ucsi/ucsi_acpi.c | 94 ++++- drivers/usb/typec/ucsi/ucsi_ccg.c | 170 ++++---- include/linux/usb/typec.h | 41 +- 12 files changed, 774 insertions(+), 856 deletions(-)