| Message ID | 20200226210414.28133-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: dwc2: Fixes and improvements | expand |
Hi Guenter, Thank you for your work on this. I tested this series on my usual setup, discussed on a previous thread (kenzo + veyron), and your patchset fixes the crashes I was seeing. I also did some testing with usb-storage, everything works as expected. Best, Boris. Guenter Roeck wrote: >This series addresses the following problems: > >- Fix receive buffer corruptions >- Fix receive transfers with 0 byte transfer length >- Abort transactions after unknown receive errors > if the receive buffer is full >- Reduce "trimming xfer length" logging noise > >The problems fixed with this series were observed when connecting >a DM9600 Ethernet adapter to Veyron Chromebooks such as the ASUS >Chromebook C201PA. The series was tested extensively with this and >other adapters. > >The observed problems are also reported when tethering various >phones, so test coverage with such phones would be very appreciated. > >---------------------------------------------------------------- >Guenter Roeck (4): > usb: dwc2: Simplify and fix DMA alignment code > usb: dwc2: Do not update data length if it is 0 on inbound transfers > usb: dwc2: Abort transaction after errors with unknown reason > usb: dwc2: Make "trimming xfer length" a debug message > > drivers/usb/dwc2/hcd.c | 82 ++++++++++++++++++++++++--------------------- > drivers/usb/dwc2/hcd_intr.c | 14 +++++++- > 2 files changed, 56 insertions(+), 40 deletions(-)
Regards, Nicolas
Hi Guenter, I found patches #2 and #3 fixed an issue for us at suse. Are you planning on sending a v2? Do you mind if I give it a try? Regards, Nicolas
H Nicolas, On 1/12/21 11:44 AM, Nicolas Saenz Julienne wrote: > Hi Guenter, > I found patches #2 and #3 fixed an issue for us at suse. Are you planning on > sending a v2? Do you mind if I give it a try? > I don't plan a v2. The pandemic put a big hole into both my plans and my ability to test the patch series. I don't plan to follow up on it, sorry. Please feel free to do with it whatever you like. Guenter
This series addresses the following problems: - Fix receive buffer corruptions - Fix receive transfers with 0 byte transfer length - Abort transactions after unknown receive errors if the receive buffer is full - Reduce "trimming xfer length" logging noise The problems fixed with this series were observed when connecting a DM9600 Ethernet adapter to Veyron Chromebooks such as the ASUS Chromebook C201PA. The series was tested extensively with this and other adapters. The observed problems are also reported when tethering various phones, so test coverage with such phones would be very appreciated. ---------------------------------------------------------------- Guenter Roeck (4): usb: dwc2: Simplify and fix DMA alignment code usb: dwc2: Do not update data length if it is 0 on inbound transfers usb: dwc2: Abort transaction after errors with unknown reason usb: dwc2: Make "trimming xfer length" a debug message drivers/usb/dwc2/hcd.c | 82 ++++++++++++++++++++++++--------------------- drivers/usb/dwc2/hcd_intr.c | 14 +++++++- 2 files changed, 56 insertions(+), 40 deletions(-)