mbox series

[REPOST,v13,0/4] usb: xhci: Add support for Renesas USB controllers

Message ID 20200514122039.300417-1-vkoul@kernel.org (mailing list archive)
Headers show
Series usb: xhci: Add support for Renesas USB controllers | expand

Message

Vinod Koul May 14, 2020, 12:20 p.m. UTC
This series add support for Renesas USB controllers uPD720201 and uPD720202.
These require firmware to be loaded and in case devices have ROM those can
also be programmed if empty. If ROM is programmed, it runs from ROM as well.

This includes patches from Christian which supported these controllers w/o
ROM and later my patches for ROM support and debugfs hook for rom erase and
export of xhci-pci functions.

Changes in v13-repost:
 - drop debugfs patch 5 and repost

Changes in v13:
 - Make rensesas as independent module invoke by xhci-pci which can be
   selected by users of such hardware

Changes in v12:
  - Restore back module name for xhci-pci, so now renesas is a separate
    module, export init/exit routines from renesas modules
  - Update changelog on patch2

Changes in v11:
  - update xhci->quirks and use that in remove function
  - remove error return renesas_verify_fw_version()
  - remove renesas_download_rom() and modify renesas_fw_download_image() for
  reuse
Changes in v10:
  remove renesas_xhci_pci_probe and call renesas_xhci_check_request_fw and
  also cleanup exit code along with it.

Changes in v9:
 Make fw load a sync call and have single instance of probe execute,
   elimating probe/remove races
 Add quirk for renesas and use that for loading

Changes in v8:
 Fix compile error reported by Kbuild-bot by making usb_hcd_pci_probe() take
 const struct hc_driver * as argument

Changes in v7:
 Make a single module which removes issues with module loading
 Keep the renesas code in renesas file
 Add hc_driver as argument for usb_hcd_pci_probe and modify hdc drivers to
   pass this and not use driver_data
 Use driver data for fw name
 Remove code to check if we need to load firmware or not
 remove multiple fw version support, we can do that with symlink in
   userspace

Changes in v6:
 Move the renesas code into a separate driver which invokes xhci-pci functions.

Changes in v5:
 Added a debugfs rom erase patch, helps in debugging
 Squashed patch 1 & 2 as requested by Mathias

Changes in v4:
 Rollback the delay values as we got device failures

Changes in v3:
  Dropped patch 2 as discussed with Christian
  Removed aligned 8 bytes check
  Change order for firmware search from highest version to lowest
  Added entry for new firmware for device 0x14 as well
  Add tested by Christian

Changes in v2:
  used macros for timeout count and delay
  removed renesas_fw_alive_check
  cleaned renesas_fw_callback
  removed recurion for renesas_fw_download
  added MODULE_FIRMWARE
  added comment for multip

Christian Lamparter (1):
  usb: renesas-xhci: Add the renesas xhci driver

Vinod Koul (3):
  usb: hci: add hc_driver as argument for usb_hcd_pci_probe
  usb: xhci: Add support for Renesas controller with memory
  usb: renesas-xhci: Add ROM loader for uPD720201

 drivers/usb/core/hcd-pci.c          |   7 +-
 drivers/usb/host/Kconfig            |   9 +
 drivers/usb/host/Makefile           |   1 +
 drivers/usb/host/ehci-pci.c         |   6 +-
 drivers/usb/host/ohci-pci.c         |   9 +-
 drivers/usb/host/uhci-pci.c         |   8 +-
 drivers/usb/host/xhci-pci-renesas.c | 645 ++++++++++++++++++++++++++++
 drivers/usb/host/xhci-pci.c         |  47 +-
 drivers/usb/host/xhci-pci.h         |  28 ++
 drivers/usb/host/xhci.h             |   1 +
 include/linux/usb/hcd.h             |   3 +-
 11 files changed, 742 insertions(+), 22 deletions(-)
 create mode 100644 drivers/usb/host/xhci-pci-renesas.c
 create mode 100644 drivers/usb/host/xhci-pci.h

Comments

Mathias Nyman May 14, 2020, 2:14 p.m. UTC | #1
On 14.5.2020 15.20, Vinod Koul wrote:
> This series add support for Renesas USB controllers uPD720201 and uPD720202.
> These require firmware to be loaded and in case devices have ROM those can
> also be programmed if empty. If ROM is programmed, it runs from ROM as well.
> 
> This includes patches from Christian which supported these controllers w/o
> ROM and later my patches for ROM support and debugfs hook for rom erase and
> export of xhci-pci functions.
> 
> Changes in v13-repost:
>  - drop debugfs patch 5 and repost
> 
> Changes in v13:
>  - Make rensesas as independent module invoke by xhci-pci which can be
>    selected by users of such hardware
> 
> Changes in v12:
>   - Restore back module name for xhci-pci, so now renesas is a separate
>     module, export init/exit routines from renesas modules
>   - Update changelog on patch2
> 
> Changes in v11:
>   - update xhci->quirks and use that in remove function
>   - remove error return renesas_verify_fw_version()
>   - remove renesas_download_rom() and modify renesas_fw_download_image() for
>   reuse
> Changes in v10:
>   remove renesas_xhci_pci_probe and call renesas_xhci_check_request_fw and
>   also cleanup exit code along with it.
> 
> Changes in v9:
>  Make fw load a sync call and have single instance of probe execute,
>    elimating probe/remove races
>  Add quirk for renesas and use that for loading
> 
> Changes in v8:
>  Fix compile error reported by Kbuild-bot by making usb_hcd_pci_probe() take
>  const struct hc_driver * as argument
> 
> Changes in v7:
>  Make a single module which removes issues with module loading
>  Keep the renesas code in renesas file
>  Add hc_driver as argument for usb_hcd_pci_probe and modify hdc drivers to
>    pass this and not use driver_data
>  Use driver data for fw name
>  Remove code to check if we need to load firmware or not
>  remove multiple fw version support, we can do that with symlink in
>    userspace
> 
> Changes in v6:
>  Move the renesas code into a separate driver which invokes xhci-pci functions.
> 
> Changes in v5:
>  Added a debugfs rom erase patch, helps in debugging
>  Squashed patch 1 & 2 as requested by Mathias
> 
> Changes in v4:
>  Rollback the delay values as we got device failures
> 
> Changes in v3:
>   Dropped patch 2 as discussed with Christian
>   Removed aligned 8 bytes check
>   Change order for firmware search from highest version to lowest
>   Added entry for new firmware for device 0x14 as well
>   Add tested by Christian
> 
> Changes in v2:
>   used macros for timeout count and delay
>   removed renesas_fw_alive_check
>   cleaned renesas_fw_callback
>   removed recurion for renesas_fw_download
>   added MODULE_FIRMWARE
>   added comment for multip
> 
> Christian Lamparter (1):
>   usb: renesas-xhci: Add the renesas xhci driver
> 
> Vinod Koul (3):
>   usb: hci: add hc_driver as argument for usb_hcd_pci_probe
>   usb: xhci: Add support for Renesas controller with memory
>   usb: renesas-xhci: Add ROM loader for uPD720201
> 
>  drivers/usb/core/hcd-pci.c          |   7 +-
>  drivers/usb/host/Kconfig            |   9 +
>  drivers/usb/host/Makefile           |   1 +
>  drivers/usb/host/ehci-pci.c         |   6 +-
>  drivers/usb/host/ohci-pci.c         |   9 +-
>  drivers/usb/host/uhci-pci.c         |   8 +-
>  drivers/usb/host/xhci-pci-renesas.c | 645 ++++++++++++++++++++++++++++
>  drivers/usb/host/xhci-pci.c         |  47 +-
>  drivers/usb/host/xhci-pci.h         |  28 ++
>  drivers/usb/host/xhci.h             |   1 +
>  include/linux/usb/hcd.h             |   3 +-
>  11 files changed, 742 insertions(+), 22 deletions(-)
>  create mode 100644 drivers/usb/host/xhci-pci-renesas.c
>  create mode 100644 drivers/usb/host/xhci-pci.h
> 

For all 4 patches:
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>