[00/32] Fix the final bunch of W=1 issues in USB

Message

Lee Jones July 6, 2020, 1:33 p.m. UTC

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

After these patches are applied, the build system no longer
complains about any W=0 nor W=1 level warnings in drivers/usb.

Hurrah!

Lee Jones (32):
  usb: misc: legousbtower: Demote obvious misuse of kerneldoc to
    standard comment blocks
  usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format
  usb: gadget: legacy: printer: Remove unused variable 'driver_desc'
  usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc'
  usb: gadget: function: u_ether:  Downgrade kerneldoc headers which to
    not make the mark
  usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues
  usb: misc: legousbtower: Demote function header which is clearly not
    kerneldoc
  usb: typec: tcpm: tcpm: Remove dangling unused 'struct
    tcpm_altmode_ops'
  usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp'
  usb: gadget: legacy: nokia: Remove unused static variable
    'product_nokia'
  usb: gadget: function: f_fs: Demote function header which is clearly
    not kerneldoc
  usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions
  usb: host: r8a66597-hcd: Remove set, then over-written, but never used
    variable 'tmp'
  usb: gadget: udc: mv_udc_core: Remove unused static const variable
    'driver_desc'
  usb: gadget: udc: pch_udc: Fix a plethora of function documentation
    related issues
  usb: host: imx21-hcd: Demote function header which is clearly not
    kerneldoc
  usb: host: ehci-fsl: Fix incorrectly named function argument
  usb: host: fotg210-hcd: Remove unused variable 'hcc_params'
  usb: gadget: function: u_uac1_legacy: Demote obvious misuse of
    kerneldoc to standard comment blocks
  usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard
    comment blocks
  usb: host: fotg210-hcd: Demote obvious misuse of kerneldoc to standard
    comment blocks
  usb: gadget: udc: mv_u3d_core: Remove unused static const
    'driver_desc'
  usb: gadget: udc: max3420_udc: Remove set, but never checked variable
    'addr'
  usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init()
  usb: early: ehci-dbgp: Remove set but never checked variable 'ret'
  usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile
  usb: early: xhci-dbc: File headers are not good candidates for
    kerneldoc
  usb: host: ehci-platform: Do not define 'struct acpi_device_id' when
    !CONFIG_ACPI
  usb: dwc3: dwc3-qcom: Do not define 'struct acpi_device_id' when
    !CONFIG_ACPI
  usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data'
  usb: host: fhci-sched: Remove unused variable 'td'
  usb: host: xhci-plat: Do not define 'struct acpi_device_id' when
    !CONFIG_ACPI

 drivers/usb/chipidea/ci_hdrc_pci.c          |  2 +-
 drivers/usb/dwc3/dwc3-qcom.c                | 22 +++++----
 drivers/usb/early/ehci-dbgp.c               |  6 +--
 drivers/usb/early/xhci-dbc.c                |  3 +-
 drivers/usb/gadget/function/f_fs.c          |  2 +-
 drivers/usb/gadget/function/u_ether.c       |  4 +-
 drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++---
 drivers/usb/gadget/legacy/nokia.c           |  1 -
 drivers/usb/gadget/legacy/printer.c         |  1 -
 drivers/usb/gadget/udc/amd5536udc_pci.c     |  1 -
 drivers/usb/gadget/udc/atmel_usba_udc.c     |  3 --
 drivers/usb/gadget/udc/lpc32xx_udc.c        |  4 +-
 drivers/usb/gadget/udc/max3420_udc.c        |  3 +-
 drivers/usb/gadget/udc/mv_u3d_core.c        |  1 -
 drivers/usb/gadget/udc/mv_udc_core.c        |  1 -
 drivers/usb/gadget/udc/pch_udc.c            | 36 +++++++--------
 drivers/usb/gadget/udc/pxa27x_udc.c         | 15 +++---
 drivers/usb/host/bcma-hcd.c                 |  4 +-
 drivers/usb/host/ehci-fsl.c                 |  2 +-
 drivers/usb/host/ehci-platform.c            |  2 +
 drivers/usb/host/fhci-sched.c               | 19 ++++----
 drivers/usb/host/fhci-tds.c                 | 11 ++---
 drivers/usb/host/fotg210-hcd.c              |  7 ++-
 drivers/usb/host/imx21-hcd.c                |  2 +-
 drivers/usb/host/r8a66597-hcd.c             |  8 ++--
 drivers/usb/host/xhci-plat.c                |  2 +
 drivers/usb/misc/legousbtower.c             | 26 +++++------
 drivers/usb/typec/tcpm/tcpm.c               | 51 ---------------------
 drivers/usb/typec/ucsi/ucsi.c               |  3 +-
 29 files changed, 96 insertions(+), 160 deletions(-)