mbox series

[00/10] USB: serial: break and sysrq fixes and cleanups

Message ID 20200708125000.15659-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: break and sysrq fixes and cleanups | expand

Message

Johan Hovold July 8, 2020, 12:49 p.m. UTC 
This series fixes the break and sysrq handling in the ftdi driver (which
have never really worked) and optimises the sysrq handling somewhat.

Included are also some related clean ups.

Johan


Johan Hovold (10):
  USB: serial: ftdi_sio: make process-packet buffer unsigned
  USB: serial: ftdi_sio: clean up receive processing
  USB: serial: ftdi_sio: fix break and sysrq handling
  USB: serial: only set sysrq timestamp for consoles
  USB: serial: only process sysrq when enabled
  USB: serial: inline sysrq dummy function
  USB: serial: add sysrq break-handler dummy
  USB: serial: drop unnecessary sysrq include
  USB: serial: drop extern keyword from function declarations
  USB: serial: drop redundant transfer-buffer casts

 drivers/usb/serial/aircable.c |  2 +-
 drivers/usb/serial/f81232.c   |  4 +-
 drivers/usb/serial/f81534.c   |  2 +-
 drivers/usb/serial/ftdi_sio.c | 59 +++++++++++++---------
 drivers/usb/serial/generic.c  | 22 ++++----
 drivers/usb/serial/mxuport.c  |  6 +--
 drivers/usb/serial/option.c   |  3 +-
 drivers/usb/serial/pl2303.c   |  2 +-
 drivers/usb/serial/sierra.c   |  3 +-
 drivers/usb/serial/ssu100.c   |  7 +--
 include/linux/usb/serial.h    | 95 ++++++++++++++++++-----------------
 11 files changed, 107 insertions(+), 98 deletions(-)

Comments

Greg KH July 8, 2020, 3:45 p.m. UTC | #1 
On Wed, Jul 08, 2020 at 02:49:50PM +0200, Johan Hovold wrote:
> This series fixes the break and sysrq handling in the ftdi driver (which
> have never really worked) and optimises the sysrq handling somewhat.
> 
> Included are also some related clean ups.

Nice!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold July 9, 2020, 7:23 a.m. UTC | #2 
On Wed, Jul 08, 2020 at 05:45:35PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 08, 2020 at 02:49:50PM +0200, Johan Hovold wrote:
> > This series fixes the break and sysrq handling in the ftdi driver (which
> > have never really worked) and optimises the sysrq handling somewhat.
> > 
> > Included are also some related clean ups.
> 
> Nice!
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Now applied.

Johan