mbox series

[v10,00/15] TCPM support for FRS and AutoDischarge Disconnect

Message ID 20201008061556.1402293-1-badhri@google.com (mailing list archive)
Headers show
Series TCPM support for FRS and AutoDischarge Disconnect | expand

Message

Badhri Jagan Sridharan Oct. 8, 2020, 6:15 a.m. UTC 
Hi,

Made two changes:

1. Added "additionalProperties: false" as suggested by Rob Herring in
https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/

2. Removed FRS dts binding constants to address Rob Herring's comment in
https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/

Thanks,
Badhri

Badhri Jagan Sridharan (15):
  usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference
  usb: typec: tcpci: Add set_vbus tcpci callback
  dt-bindings: usb: Maxim type-c controller device tree binding document
  usb: typec: tcpci_maxim: Chip level TCPC driver
  dt-bindings: connector: Add property to set initial current cap for
    FRS
  usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS)
  usb: typec: tcpci: Implement callbacks for FRS
  usb: typec: tcpci_maxim: Add support for Sink FRS
  usb: typec: tcpm: frs sourcing vbus callback
  usb: typec: tcpci: frs sourcing vbus callback
  usb: typec: tcpci_max77759: Fix vbus stuck on upon diconnecting sink
  usb: typec: tcpm: Parse frs type-c current from device tree
  usb: typec: tcpm: Implement enabling Auto Discharge disconnect support
  usb: typec: tcpci: Implement Auto discharge disconnect callbacks
  usb: typec: tcpci_maxim: Enable auto discharge disconnect

 .../bindings/connector/usb-connector.yaml     |  26 +
 .../devicetree/bindings/usb/maxim,tcpci.yaml  |  70 +++
 drivers/usb/typec/tcpm/Kconfig                |   6 +
 drivers/usb/typec/tcpm/Makefile               |  15 +-
 drivers/usb/typec/tcpm/tcpci.c                | 102 +++-
 drivers/usb/typec/tcpm/tcpci.h                |  30 +-
 drivers/usb/typec/tcpm/tcpci_maxim.c          | 504 ++++++++++++++++++
 drivers/usb/typec/tcpm/tcpm.c                 | 299 ++++++++++-
 include/linux/usb/pd.h                        |  19 +-
 include/linux/usb/tcpm.h                      |  27 +-
 include/linux/usb/typec.h                     |  12 +
 11 files changed, 1085 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.yaml
 create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c

Comments

Greg KH Oct. 8, 2020, 7:46 a.m. UTC | #1 
On Wed, Oct 07, 2020 at 11:15:41PM -0700, Badhri Jagan Sridharan wrote:
> Hi,
> 
> Made two changes:
> 
> 1. Added "additionalProperties: false" as suggested by Rob Herring in
> https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/
> 
> 2. Removed FRS dts binding constants to address Rob Herring's comment in
> https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/

That worked better.  I've applied the patches that Heikki had reviewed
to my usb-testing branch now.

thanks,

greg k-h
Badhri Jagan Sridharan Oct. 8, 2020, 5:54 p.m. UTC | #2 
Thanks Greg !

On Thu, Oct 8, 2020 at 12:45 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Oct 07, 2020 at 11:15:41PM -0700, Badhri Jagan Sridharan wrote:
> > Hi,
> >
> > Made two changes:
> >
> > 1. Added "additionalProperties: false" as suggested by Rob Herring in
> > https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/
> >
> > 2. Removed FRS dts binding constants to address Rob Herring's comment in
> > https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/
>
> That worked better.  I've applied the patches that Heikki had reviewed
> to my usb-testing branch now.
>
> thanks,
>
> greg k-h
Rob Herring Oct. 13, 2020, 2:11 p.m. UTC | #3 
On Thu, Oct 8, 2020 at 2:45 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Oct 07, 2020 at 11:15:41PM -0700, Badhri Jagan Sridharan wrote:
> > Hi,
> >
> > Made two changes:
> >
> > 1. Added "additionalProperties: false" as suggested by Rob Herring in
> > https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/
> >
> > 2. Removed FRS dts binding constants to address Rob Herring's comment in
> > https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/

And didn't address my other comments...

> That worked better.  I've applied the patches that Heikki had reviewed
> to my usb-testing branch now.

Why is the driver being applied without the binding? Bindings come
first. The binding and driver don't even agree on the compatible
string (maxim,tcpci vs. maxim,tcpc), neither of which are right.

The FRS bindings need to be sorted out too as we have multiple folks
proposing bindings for it. I wish someone would review all these TypeC
related bindings because I'm getting a continual stream of piecemeal
additions with no coordination and I don't have knowledge on TypeC nor
bandwidth to review it all.

Rob
Heikki Krogerus Oct. 19, 2020, 1:55 p.m. UTC | #4 
On Wed, Oct 07, 2020 at 11:15:41PM -0700, Badhri Jagan Sridharan wrote:
> Hi,
> 
> Made two changes:
> 
> 1. Added "additionalProperties: false" as suggested by Rob Herring in
> https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/
> 
> 2. Removed FRS dts binding constants to address Rob Herring's comment in
> https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/

I skipped 12/15. I thought that we better wait for Rob's approval for
the device property.

> Thanks,
> Badhri
> 
> Badhri Jagan Sridharan (15):
>   usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference
>   usb: typec: tcpci: Add set_vbus tcpci callback
>   dt-bindings: usb: Maxim type-c controller device tree binding document
>   usb: typec: tcpci_maxim: Chip level TCPC driver
>   dt-bindings: connector: Add property to set initial current cap for
>     FRS
>   usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS)
>   usb: typec: tcpci: Implement callbacks for FRS
>   usb: typec: tcpci_maxim: Add support for Sink FRS
>   usb: typec: tcpm: frs sourcing vbus callback
>   usb: typec: tcpci: frs sourcing vbus callback
>   usb: typec: tcpci_max77759: Fix vbus stuck on upon diconnecting sink
>   usb: typec: tcpm: Parse frs type-c current from device tree
>   usb: typec: tcpm: Implement enabling Auto Discharge disconnect support
>   usb: typec: tcpci: Implement Auto discharge disconnect callbacks
>   usb: typec: tcpci_maxim: Enable auto discharge disconnect
> 
>  .../bindings/connector/usb-connector.yaml     |  26 +
>  .../devicetree/bindings/usb/maxim,tcpci.yaml  |  70 +++
>  drivers/usb/typec/tcpm/Kconfig                |   6 +
>  drivers/usb/typec/tcpm/Makefile               |  15 +-
>  drivers/usb/typec/tcpm/tcpci.c                | 102 +++-
>  drivers/usb/typec/tcpm/tcpci.h                |  30 +-
>  drivers/usb/typec/tcpm/tcpci_maxim.c          | 504 ++++++++++++++++++
>  drivers/usb/typec/tcpm/tcpm.c                 | 299 ++++++++++-
>  include/linux/usb/pd.h                        |  19 +-
>  include/linux/usb/tcpm.h                      |  27 +-
>  include/linux/usb/typec.h                     |  12 +
>  11 files changed, 1085 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.yaml
>  create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c

thanks,