mbox series

[v2,00/10] thunderbolt: Add DMA traffic test driver

Message ID 20201110091957.17472-1-mika.westerberg@linux.intel.com (mailing list archive)
Headers show
Series thunderbolt: Add DMA traffic test driver | expand

Message

Mika Westerberg Nov. 10, 2020, 9:19 a.m. UTC 
Hi all,

This series adds a new Thunderbolt service driver that can be used on
manufacturing floor to test that each Thunderbolt/USB4 port is functional.
It can be done either using a special loopback dongle that has RX and TX
lanes crossed, or by connecting a cable back to the host (for those who
don't have these dongles).

This takes advantage of the existing XDomain protocol and creates XDomain
devices for the loops back to the host where the DMA traffic test driver
can bind to.

The DMA traffic test driver creates a tunnel through the fabric and then
sends and receives data frames over the tunnel checking for different
errors.

The previous version can be found here:

  https://lore.kernel.org/linux-usb/20201104140030.6853-1-mika.westerberg@linux.intel.com/

Changes from the previous version:

  * Fix resource leak in tb_xdp_handle_request() (patch 2/10)
  * Use debugfs_remove_recursive() in tb_service_debugfs_remove() (patch 6/10)
  * Add tags from Yehezkel

Isaac Hazan (4):
  thunderbolt: Add link_speed and link_width to XDomain
  thunderbolt: Add functions for enabling and disabling lane bonding on XDomain
  thunderbolt: Add DMA traffic test driver
  MAINTAINERS: Add Isaac as maintainer of Thunderbolt DMA traffic test driver

Mika Westerberg (6):
  thunderbolt: Do not clear USB4 router protocol adapter IFC and ISE bits
  thunderbolt: Find XDomain by route instead of UUID
  thunderbolt: Create XDomain devices for loops back to the host
  thunderbolt: Create debugfs directory automatically for services
  thunderbolt: Make it possible to allocate one directional DMA tunnel
  thunderbolt: Add support for end-to-end flow control

 .../ABI/testing/sysfs-bus-thunderbolt         |  28 +
 MAINTAINERS                                   |   6 +
 drivers/net/thunderbolt.c                     |   2 +-
 drivers/thunderbolt/Kconfig                   |  13 +
 drivers/thunderbolt/Makefile                  |   3 +
 drivers/thunderbolt/ctl.c                     |   4 +-
 drivers/thunderbolt/debugfs.c                 |  24 +
 drivers/thunderbolt/dma_test.c                | 736 ++++++++++++++++++
 drivers/thunderbolt/nhi.c                     |  36 +-
 drivers/thunderbolt/path.c                    |  13 +-
 drivers/thunderbolt/switch.c                  |  33 +-
 drivers/thunderbolt/tb.h                      |   8 +
 drivers/thunderbolt/tunnel.c                  |  50 +-
 drivers/thunderbolt/xdomain.c                 | 148 +++-
 include/linux/thunderbolt.h                   |  18 +-
 15 files changed, 1080 insertions(+), 42 deletions(-)
 create mode 100644 drivers/thunderbolt/dma_test.c

Comments

Greg KH Nov. 10, 2020, 9:30 a.m. UTC | #1 
On Tue, Nov 10, 2020 at 12:19:47PM +0300, Mika Westerberg wrote:
> Hi all,
> 
> This series adds a new Thunderbolt service driver that can be used on
> manufacturing floor to test that each Thunderbolt/USB4 port is functional.
> It can be done either using a special loopback dongle that has RX and TX
> lanes crossed, or by connecting a cable back to the host (for those who
> don't have these dongles).
> 
> This takes advantage of the existing XDomain protocol and creates XDomain
> devices for the loops back to the host where the DMA traffic test driver
> can bind to.
> 
> The DMA traffic test driver creates a tunnel through the fabric and then
> sends and receives data frames over the tunnel checking for different
> errors.
> 
> The previous version can be found here:
> 
>   https://lore.kernel.org/linux-usb/20201104140030.6853-1-mika.westerberg@linux.intel.com/
> 
> Changes from the previous version:
> 
>   * Fix resource leak in tb_xdp_handle_request() (patch 2/10)
>   * Use debugfs_remove_recursive() in tb_service_debugfs_remove() (patch 6/10)
>   * Add tags from Yehezkel

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mika Westerberg Nov. 11, 2020, 7:23 a.m. UTC | #2 
On Tue, Nov 10, 2020 at 10:30:45AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 10, 2020 at 12:19:47PM +0300, Mika Westerberg wrote:
> > Hi all,
> > 
> > This series adds a new Thunderbolt service driver that can be used on
> > manufacturing floor to test that each Thunderbolt/USB4 port is functional.
> > It can be done either using a special loopback dongle that has RX and TX
> > lanes crossed, or by connecting a cable back to the host (for those who
> > don't have these dongles).
> > 
> > This takes advantage of the existing XDomain protocol and creates XDomain
> > devices for the loops back to the host where the DMA traffic test driver
> > can bind to.
> > 
> > The DMA traffic test driver creates a tunnel through the fabric and then
> > sends and receives data frames over the tunnel checking for different
> > errors.
> > 
> > The previous version can be found here:
> > 
> >   https://lore.kernel.org/linux-usb/20201104140030.6853-1-mika.westerberg@linux.intel.com/
> > 
> > Changes from the previous version:
> > 
> >   * Fix resource leak in tb_xdp_handle_request() (patch 2/10)
> >   * Use debugfs_remove_recursive() in tb_service_debugfs_remove() (patch 6/10)
> >   * Add tags from Yehezkel
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks!

Applied the series to thunderbolt.git/next.