| Message ID | 20201218120246.7759-1-digetx@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support Runtime PM and host mode by Tegra ChipIdea USB driver | expand |
On 20-12-18 15:02:37, Dmitry Osipenko wrote: > This series implements Runtime PM support for the Tegra ChipIdea USB driver. > It also squashes the older ehci-tegra driver into the ChipIdea driver, hence > the RPM is supported by both UDC and host controllers, secondly this opens > opportunity for implementing OTG support in the future. > > Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. > Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for > helping with the extensive and productive testing! > > Changelog: > > v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. > > - Improved wording of the deprecated Kconfig entry as was suggested > by Alan Stern. > > - Added ACKs from Thierry Reding and Alan Stern. > > - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" > just for completeness, since we can now switch OTG to host mode in > the ChipIdea driver. Although, OTG support remains a work-in-progress > for now. > > v2: - Improved comments in the code as it was suggested by Peter Chen and > Sergei Shtylyov for v1. > > - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in > a error code path, like it was suggested by Peter Chen. > > - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA > as was suggested by Alan Stern. > > - Improved commit message and added ACK from Thierry Reding to the patch > that removes MODULE_ALIAS. > > - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing > additional VBUS sensor. This was reported and tested by Ion Agorria. > > - Added t-b from Ion Agorria. > > Dmitry Osipenko (8): > usb: phy: tegra: Add delay after power up > usb: phy: tegra: Support waking up from a low power mode > usb: chipidea: tegra: Remove MODULE_ALIAS > usb: chipidea: tegra: Rename UDC to USB > usb: chipidea: tegra: Support runtime PM > usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info > usb: host: ehci-tegra: Remove the driver > ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove > USB_EHCI_TEGRA > > Peter Geis (1): > usb: chipidea: tegra: Support host mode Chipidea related (patch 3-7) are applied, thanks. Peter > > arch/arm/configs/tegra_defconfig | 3 +- > drivers/usb/chipidea/Kconfig | 3 +- > drivers/usb/chipidea/ci_hdrc_tegra.c | 344 ++++++++++++--- > drivers/usb/chipidea/core.c | 10 +- > drivers/usb/chipidea/host.c | 104 ++++- > drivers/usb/host/Kconfig | 10 +- > drivers/usb/host/Makefile | 1 - > drivers/usb/host/ehci-tegra.c | 604 --------------------------- > drivers/usb/phy/phy-tegra-usb.c | 103 ++++- > include/linux/usb/chipidea.h | 6 + > include/linux/usb/tegra_usb_phy.h | 2 + > 11 files changed, 518 insertions(+), 672 deletions(-) > delete mode 100644 drivers/usb/host/ehci-tegra.c > > -- > 2.29.2 >
29.12.2020 08:16, Peter Chen пишет: > On 20-12-18 15:02:37, Dmitry Osipenko wrote: >> This series implements Runtime PM support for the Tegra ChipIdea USB driver. >> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence >> the RPM is supported by both UDC and host controllers, secondly this opens >> opportunity for implementing OTG support in the future. >> >> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. >> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for >> helping with the extensive and productive testing! >> >> Changelog: >> >> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. >> >> - Improved wording of the deprecated Kconfig entry as was suggested >> by Alan Stern. >> >> - Added ACKs from Thierry Reding and Alan Stern. >> >> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" >> just for completeness, since we can now switch OTG to host mode in >> the ChipIdea driver. Although, OTG support remains a work-in-progress >> for now. >> >> v2: - Improved comments in the code as it was suggested by Peter Chen and >> Sergei Shtylyov for v1. >> >> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in >> a error code path, like it was suggested by Peter Chen. >> >> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA >> as was suggested by Alan Stern. >> >> - Improved commit message and added ACK from Thierry Reding to the patch >> that removes MODULE_ALIAS. >> >> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing >> additional VBUS sensor. This was reported and tested by Ion Agorria. >> >> - Added t-b from Ion Agorria. >> >> Dmitry Osipenko (8): >> usb: phy: tegra: Add delay after power up >> usb: phy: tegra: Support waking up from a low power mode >> usb: chipidea: tegra: Remove MODULE_ALIAS >> usb: chipidea: tegra: Rename UDC to USB >> usb: chipidea: tegra: Support runtime PM >> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info >> usb: host: ehci-tegra: Remove the driver >> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove >> USB_EHCI_TEGRA >> >> Peter Geis (1): >> usb: chipidea: tegra: Support host mode > > Chipidea related (patch 3-7) are applied, thanks. Hello Peter, Thank you for applying the patches. Who will apply the remaining patches? The Chipidea patch #6 depends on the PHY changes, otherwise USB will suspend and never resume.
29.12.2020 17:26, Dmitry Osipenko пишет: > 29.12.2020 08:16, Peter Chen пишет: >> On 20-12-18 15:02:37, Dmitry Osipenko wrote: >>> This series implements Runtime PM support for the Tegra ChipIdea USB driver. >>> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence >>> the RPM is supported by both UDC and host controllers, secondly this opens >>> opportunity for implementing OTG support in the future. >>> >>> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. >>> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for >>> helping with the extensive and productive testing! >>> >>> Changelog: >>> >>> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. >>> >>> - Improved wording of the deprecated Kconfig entry as was suggested >>> by Alan Stern. >>> >>> - Added ACKs from Thierry Reding and Alan Stern. >>> >>> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" >>> just for completeness, since we can now switch OTG to host mode in >>> the ChipIdea driver. Although, OTG support remains a work-in-progress >>> for now. >>> >>> v2: - Improved comments in the code as it was suggested by Peter Chen and >>> Sergei Shtylyov for v1. >>> >>> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in >>> a error code path, like it was suggested by Peter Chen. >>> >>> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA >>> as was suggested by Alan Stern. >>> >>> - Improved commit message and added ACK from Thierry Reding to the patch >>> that removes MODULE_ALIAS. >>> >>> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing >>> additional VBUS sensor. This was reported and tested by Ion Agorria. >>> >>> - Added t-b from Ion Agorria. >>> >>> Dmitry Osipenko (8): >>> usb: phy: tegra: Add delay after power up >>> usb: phy: tegra: Support waking up from a low power mode >>> usb: chipidea: tegra: Remove MODULE_ALIAS >>> usb: chipidea: tegra: Rename UDC to USB >>> usb: chipidea: tegra: Support runtime PM >>> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info >>> usb: host: ehci-tegra: Remove the driver >>> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove >>> USB_EHCI_TEGRA >>> >>> Peter Geis (1): >>> usb: chipidea: tegra: Support host mode >> >> Chipidea related (patch 3-7) are applied, thanks. > > Hello Peter, > > Thank you for applying the patches. > > Who will apply the remaining patches? > > The Chipidea patch #6 depends on the PHY changes, otherwise USB will > suspend and never resume. > Peter, could you please apply the PHY and defconfig patches along with the CI patches to -next? I.e. the whole series. Preferentially in original ordering of patches should be preserved. Thanks in advance.
On 21-01-12 09:56:37, Dmitry Osipenko wrote: > 29.12.2020 17:26, Dmitry Osipenko пишет: > > 29.12.2020 08:16, Peter Chen пишет: > >> On 20-12-18 15:02:37, Dmitry Osipenko wrote: > >>> This series implements Runtime PM support for the Tegra ChipIdea USB driver. > >>> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence > >>> the RPM is supported by both UDC and host controllers, secondly this opens > >>> opportunity for implementing OTG support in the future. > >>> > >>> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. > >>> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for > >>> helping with the extensive and productive testing! > >>> > >>> Changelog: > >>> > >>> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. > >>> > >>> - Improved wording of the deprecated Kconfig entry as was suggested > >>> by Alan Stern. > >>> > >>> - Added ACKs from Thierry Reding and Alan Stern. > >>> > >>> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" > >>> just for completeness, since we can now switch OTG to host mode in > >>> the ChipIdea driver. Although, OTG support remains a work-in-progress > >>> for now. > >>> > >>> v2: - Improved comments in the code as it was suggested by Peter Chen and > >>> Sergei Shtylyov for v1. > >>> > >>> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in > >>> a error code path, like it was suggested by Peter Chen. > >>> > >>> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA > >>> as was suggested by Alan Stern. > >>> > >>> - Improved commit message and added ACK from Thierry Reding to the patch > >>> that removes MODULE_ALIAS. > >>> > >>> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing > >>> additional VBUS sensor. This was reported and tested by Ion Agorria. > >>> > >>> - Added t-b from Ion Agorria. > >>> > >>> Dmitry Osipenko (8): > >>> usb: phy: tegra: Add delay after power up > >>> usb: phy: tegra: Support waking up from a low power mode > >>> usb: chipidea: tegra: Remove MODULE_ALIAS > >>> usb: chipidea: tegra: Rename UDC to USB > >>> usb: chipidea: tegra: Support runtime PM > >>> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info > >>> usb: host: ehci-tegra: Remove the driver > >>> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove > >>> USB_EHCI_TEGRA > >>> > >>> Peter Geis (1): > >>> usb: chipidea: tegra: Support host mode > >> > >> Chipidea related (patch 3-7) are applied, thanks. > > > > Hello Peter, > > > > Thank you for applying the patches. > > > > Who will apply the remaining patches? > > > > The Chipidea patch #6 depends on the PHY changes, otherwise USB will > > suspend and never resume. > > > > Peter, could you please apply the PHY and defconfig patches along with > the CI patches to -next? I.e. the whole series. Preferentially in > original ordering of patches should be preserved. > Hi Dmitry, Usually, Greg could apply all USB patches, if I apply other USB related patches, it may cause conflict with other patches in other's tree. Greg, free feel to apply this series with Acked-by: Peter Chen <peter.chen@kernel.org> for chipidea part. For ARM defconfig patch, I think it should go ARM's tree.
13.01.2021 04:20, Peter Chen пишет: > On 21-01-12 09:56:37, Dmitry Osipenko wrote: >> 29.12.2020 17:26, Dmitry Osipenko пишет: >>> 29.12.2020 08:16, Peter Chen пишет: >>>> On 20-12-18 15:02:37, Dmitry Osipenko wrote: >>>>> This series implements Runtime PM support for the Tegra ChipIdea USB driver. >>>>> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence >>>>> the RPM is supported by both UDC and host controllers, secondly this opens >>>>> opportunity for implementing OTG support in the future. >>>>> >>>>> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. >>>>> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for >>>>> helping with the extensive and productive testing! >>>>> >>>>> Changelog: >>>>> >>>>> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. >>>>> >>>>> - Improved wording of the deprecated Kconfig entry as was suggested >>>>> by Alan Stern. >>>>> >>>>> - Added ACKs from Thierry Reding and Alan Stern. >>>>> >>>>> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" >>>>> just for completeness, since we can now switch OTG to host mode in >>>>> the ChipIdea driver. Although, OTG support remains a work-in-progress >>>>> for now. >>>>> >>>>> v2: - Improved comments in the code as it was suggested by Peter Chen and >>>>> Sergei Shtylyov for v1. >>>>> >>>>> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in >>>>> a error code path, like it was suggested by Peter Chen. >>>>> >>>>> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA >>>>> as was suggested by Alan Stern. >>>>> >>>>> - Improved commit message and added ACK from Thierry Reding to the patch >>>>> that removes MODULE_ALIAS. >>>>> >>>>> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing >>>>> additional VBUS sensor. This was reported and tested by Ion Agorria. >>>>> >>>>> - Added t-b from Ion Agorria. >>>>> >>>>> Dmitry Osipenko (8): >>>>> usb: phy: tegra: Add delay after power up >>>>> usb: phy: tegra: Support waking up from a low power mode >>>>> usb: chipidea: tegra: Remove MODULE_ALIAS >>>>> usb: chipidea: tegra: Rename UDC to USB >>>>> usb: chipidea: tegra: Support runtime PM >>>>> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info >>>>> usb: host: ehci-tegra: Remove the driver >>>>> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove >>>>> USB_EHCI_TEGRA >>>>> >>>>> Peter Geis (1): >>>>> usb: chipidea: tegra: Support host mode >>>> >>>> Chipidea related (patch 3-7) are applied, thanks. >>> >>> Hello Peter, >>> >>> Thank you for applying the patches. >>> >>> Who will apply the remaining patches? >>> >>> The Chipidea patch #6 depends on the PHY changes, otherwise USB will >>> suspend and never resume. >>> >> >> Peter, could you please apply the PHY and defconfig patches along with >> the CI patches to -next? I.e. the whole series. Preferentially in >> original ordering of patches should be preserved. >> > > Hi Dmitry, > > Usually, Greg could apply all USB patches, if I apply other USB related > patches, it may cause conflict with other patches in other's tree. > Greg, free feel to apply this series with > Acked-by: Peter Chen <peter.chen@kernel.org> > for chipidea part. > > For ARM defconfig patch, I think it should go ARM's tree. > Thank you for the answer! It's not the ARM defconfig, but a local tegra_defconfig. It should be fine to take the patch via the USB tree since Thierry already acked it and asked to do so. Greg, please take this whole series. Thanks in advance!
On Wed, Jan 13, 2021 at 12:01:51PM +0300, Dmitry Osipenko wrote: > 13.01.2021 04:20, Peter Chen пишет: > > On 21-01-12 09:56:37, Dmitry Osipenko wrote: > >> 29.12.2020 17:26, Dmitry Osipenko пишет: > >>> 29.12.2020 08:16, Peter Chen пишет: > >>>> On 20-12-18 15:02:37, Dmitry Osipenko wrote: > >>>>> This series implements Runtime PM support for the Tegra ChipIdea USB driver. > >>>>> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence > >>>>> the RPM is supported by both UDC and host controllers, secondly this opens > >>>>> opportunity for implementing OTG support in the future. > >>>>> > >>>>> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. > >>>>> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for > >>>>> helping with the extensive and productive testing! > >>>>> > >>>>> Changelog: > >>>>> > >>>>> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. > >>>>> > >>>>> - Improved wording of the deprecated Kconfig entry as was suggested > >>>>> by Alan Stern. > >>>>> > >>>>> - Added ACKs from Thierry Reding and Alan Stern. > >>>>> > >>>>> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" > >>>>> just for completeness, since we can now switch OTG to host mode in > >>>>> the ChipIdea driver. Although, OTG support remains a work-in-progress > >>>>> for now. > >>>>> > >>>>> v2: - Improved comments in the code as it was suggested by Peter Chen and > >>>>> Sergei Shtylyov for v1. > >>>>> > >>>>> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in > >>>>> a error code path, like it was suggested by Peter Chen. > >>>>> > >>>>> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA > >>>>> as was suggested by Alan Stern. > >>>>> > >>>>> - Improved commit message and added ACK from Thierry Reding to the patch > >>>>> that removes MODULE_ALIAS. > >>>>> > >>>>> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing > >>>>> additional VBUS sensor. This was reported and tested by Ion Agorria. > >>>>> > >>>>> - Added t-b from Ion Agorria. > >>>>> > >>>>> Dmitry Osipenko (8): > >>>>> usb: phy: tegra: Add delay after power up > >>>>> usb: phy: tegra: Support waking up from a low power mode > >>>>> usb: chipidea: tegra: Remove MODULE_ALIAS > >>>>> usb: chipidea: tegra: Rename UDC to USB > >>>>> usb: chipidea: tegra: Support runtime PM > >>>>> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info > >>>>> usb: host: ehci-tegra: Remove the driver > >>>>> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove > >>>>> USB_EHCI_TEGRA > >>>>> > >>>>> Peter Geis (1): > >>>>> usb: chipidea: tegra: Support host mode > >>>> > >>>> Chipidea related (patch 3-7) are applied, thanks. > >>> > >>> Hello Peter, > >>> > >>> Thank you for applying the patches. > >>> > >>> Who will apply the remaining patches? > >>> > >>> The Chipidea patch #6 depends on the PHY changes, otherwise USB will > >>> suspend and never resume. > >>> > >> > >> Peter, could you please apply the PHY and defconfig patches along with > >> the CI patches to -next? I.e. the whole series. Preferentially in > >> original ordering of patches should be preserved. > >> > > > > Hi Dmitry, > > > > Usually, Greg could apply all USB patches, if I apply other USB related > > patches, it may cause conflict with other patches in other's tree. > > Greg, free feel to apply this series with > > Acked-by: Peter Chen <peter.chen@kernel.org> > > for chipidea part. > > > > For ARM defconfig patch, I think it should go ARM's tree. > > > > Thank you for the answer! > > It's not the ARM defconfig, but a local tegra_defconfig. It should be > fine to take the patch via the USB tree since Thierry already acked it > and asked to do so. > > Greg, please take this whole series. Thanks in advance! All now applied, thanks! greg k-h
13.01.2021 13:27, Greg Kroah-Hartman пишет: > On Wed, Jan 13, 2021 at 12:01:51PM +0300, Dmitry Osipenko wrote: >> 13.01.2021 04:20, Peter Chen пишет: >>> On 21-01-12 09:56:37, Dmitry Osipenko wrote: >>>> 29.12.2020 17:26, Dmitry Osipenko пишет: >>>>> 29.12.2020 08:16, Peter Chen пишет: >>>>>> On 20-12-18 15:02:37, Dmitry Osipenko wrote: >>>>>>> This series implements Runtime PM support for the Tegra ChipIdea USB driver. >>>>>>> It also squashes the older ehci-tegra driver into the ChipIdea driver, hence >>>>>>> the RPM is supported by both UDC and host controllers, secondly this opens >>>>>>> opportunity for implementing OTG support in the future. >>>>>>> >>>>>>> Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. >>>>>>> Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for >>>>>>> helping with the extensive and productive testing! >>>>>>> >>>>>>> Changelog: >>>>>>> >>>>>>> v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. >>>>>>> >>>>>>> - Improved wording of the deprecated Kconfig entry as was suggested >>>>>>> by Alan Stern. >>>>>>> >>>>>>> - Added ACKs from Thierry Reding and Alan Stern. >>>>>>> >>>>>>> - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" >>>>>>> just for completeness, since we can now switch OTG to host mode in >>>>>>> the ChipIdea driver. Although, OTG support remains a work-in-progress >>>>>>> for now. >>>>>>> >>>>>>> v2: - Improved comments in the code as it was suggested by Peter Chen and >>>>>>> Sergei Shtylyov for v1. >>>>>>> >>>>>>> - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in >>>>>>> a error code path, like it was suggested by Peter Chen. >>>>>>> >>>>>>> - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA >>>>>>> as was suggested by Alan Stern. >>>>>>> >>>>>>> - Improved commit message and added ACK from Thierry Reding to the patch >>>>>>> that removes MODULE_ALIAS. >>>>>>> >>>>>>> - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing >>>>>>> additional VBUS sensor. This was reported and tested by Ion Agorria. >>>>>>> >>>>>>> - Added t-b from Ion Agorria. >>>>>>> >>>>>>> Dmitry Osipenko (8): >>>>>>> usb: phy: tegra: Add delay after power up >>>>>>> usb: phy: tegra: Support waking up from a low power mode >>>>>>> usb: chipidea: tegra: Remove MODULE_ALIAS >>>>>>> usb: chipidea: tegra: Rename UDC to USB >>>>>>> usb: chipidea: tegra: Support runtime PM >>>>>>> usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info >>>>>>> usb: host: ehci-tegra: Remove the driver >>>>>>> ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove >>>>>>> USB_EHCI_TEGRA >>>>>>> >>>>>>> Peter Geis (1): >>>>>>> usb: chipidea: tegra: Support host mode >>>>>> >>>>>> Chipidea related (patch 3-7) are applied, thanks. >>>>> >>>>> Hello Peter, >>>>> >>>>> Thank you for applying the patches. >>>>> >>>>> Who will apply the remaining patches? >>>>> >>>>> The Chipidea patch #6 depends on the PHY changes, otherwise USB will >>>>> suspend and never resume. >>>>> >>>> >>>> Peter, could you please apply the PHY and defconfig patches along with >>>> the CI patches to -next? I.e. the whole series. Preferentially in >>>> original ordering of patches should be preserved. >>>> >>> >>> Hi Dmitry, >>> >>> Usually, Greg could apply all USB patches, if I apply other USB related >>> patches, it may cause conflict with other patches in other's tree. >>> Greg, free feel to apply this series with >>> Acked-by: Peter Chen <peter.chen@kernel.org> >>> for chipidea part. >>> >>> For ARM defconfig patch, I think it should go ARM's tree. >>> >> >> Thank you for the answer! >> >> It's not the ARM defconfig, but a local tegra_defconfig. It should be >> fine to take the patch via the USB tree since Thierry already acked it >> and asked to do so. >> >> Greg, please take this whole series. Thanks in advance! > > All now applied, thanks! Thank you!
This series implements Runtime PM support for the Tegra ChipIdea USB driver. It also squashes the older ehci-tegra driver into the ChipIdea driver, hence the RPM is supported by both UDC and host controllers, secondly this opens opportunity for implementing OTG support in the future. Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices. Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for helping with the extensive and productive testing! Changelog: v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding. - Improved wording of the deprecated Kconfig entry as was suggested by Alan Stern. - Added ACKs from Thierry Reding and Alan Stern. - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info" just for completeness, since we can now switch OTG to host mode in the ChipIdea driver. Although, OTG support remains a work-in-progress for now. v2: - Improved comments in the code as it was suggested by Peter Chen and Sergei Shtylyov for v1. - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in a error code path, like it was suggested by Peter Chen. - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA as was suggested by Alan Stern. - Improved commit message and added ACK from Thierry Reding to the patch that removes MODULE_ALIAS. - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing additional VBUS sensor. This was reported and tested by Ion Agorria. - Added t-b from Ion Agorria. Dmitry Osipenko (8): usb: phy: tegra: Add delay after power up usb: phy: tegra: Support waking up from a low power mode usb: chipidea: tegra: Remove MODULE_ALIAS usb: chipidea: tegra: Rename UDC to USB usb: chipidea: tegra: Support runtime PM usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info usb: host: ehci-tegra: Remove the driver ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove USB_EHCI_TEGRA Peter Geis (1): usb: chipidea: tegra: Support host mode arch/arm/configs/tegra_defconfig | 3 +- drivers/usb/chipidea/Kconfig | 3 +- drivers/usb/chipidea/ci_hdrc_tegra.c | 344 ++++++++++++--- drivers/usb/chipidea/core.c | 10 +- drivers/usb/chipidea/host.c | 104 ++++- drivers/usb/host/Kconfig | 10 +- drivers/usb/host/Makefile | 1 - drivers/usb/host/ehci-tegra.c | 604 --------------------------- drivers/usb/phy/phy-tegra-usb.c | 103 ++++- include/linux/usb/chipidea.h | 6 + include/linux/usb/tegra_usb_phy.h | 2 + 11 files changed, 518 insertions(+), 672 deletions(-) delete mode 100644 drivers/usb/host/ehci-tegra.c