mbox series

[v4,00/12] usb: usbip: serialize attach/detach operations

Message ID 20210304152455.3685-1-penguin-kernel@I-love.SAKURA.ne.jp (mailing list archive)
Headers show
Series usb: usbip: serialize attach/detach operations | expand

Message

Tetsuo Handa March 4, 2021, 3:24 p.m. UTC
On 2021/02/27 0:04, Shuah Khan wrote:
> I will send it out later on today.

Since I haven't received it, here comes an update.

Changes since v1:

  Tetsuo Handa found that the PTR_ERR() access in usbip_prepare_threads()
  in v1 was wrong, and fixed it in v2.

Changes since v2:

  The kernel test robot <lkp@intel.com> found the same error using
  scripts/coccinelle/tests/odd_ptr_err.cocci and
  Julia Lawall <julia.lawall@inria.fr> sent us a patch, but nothing
  changed because that error was already fixed in v2.

Changes since v3:

  Reduce lines changed in drivers/usb/usbip/stub_dev.c .
  Split into 12 patches.

Tetsuo Handa (12):
  usb: usbip: introduce usbip_event_mutex for serialization
  usb: usbip: vhci: serialize attach_store()/detach_store() against event_handler()
  usb: usbip: vudc: serialize usbip_sockfd_store() against event_handler()
  usb: usbip: stub: serialize usbip_sockfd_store() against event_handler()
  usb: usbip: don't reset tcp_socket at vhci_device_reset()
  usb: usbip: fix error handling of kthread_get_run()
  usb: usbip: preallocate kernel threads for consistent attach operation
  usb: usbip: check that stream socket is used
  usb: usbip: vhci: add automatic recovery to attach_store()
  usb: usbip: vudc: add automatic recovery to usbip_sockfd_store()
  usb: usbip: stub: add automatic recovery to usbip_sockfd_store()
  usb: usbip: remove unused kthread_get_run()

 drivers/usb/usbip/stub_dev.c     | 44 ++++++++++++++-----------
 drivers/usb/usbip/usbip_common.c | 55 ++++++++++++++++++++++++++++++++
 drivers/usb/usbip/usbip_common.h | 25 ++++++++-------
 drivers/usb/usbip/usbip_event.c  | 15 +++++++++
 drivers/usb/usbip/vhci_hcd.c     |  6 ----
 drivers/usb/usbip/vhci_sysfs.c   | 50 +++++++++++++++++++++--------
 drivers/usb/usbip/vudc_sysfs.c   | 50 +++++++++++++++++------------
 7 files changed, 176 insertions(+), 69 deletions(-)

Comments

Shuah Khan March 4, 2021, 3:52 p.m. UTC | #1
On 3/4/21 8:24 AM, Tetsuo Handa wrote:
> On 2021/02/27 0:04, Shuah Khan wrote:
>> I will send it out later on today.
> 
> Since I haven't received it, here comes an update.
> 

Thanks for you the update.

I have a patch series that works well to go into stables.

As I said, it uses a simpler approach and reduces the number
of changes. I would rather go with what I am working on.

These fixes have to go all the way into Linux 4.4. I will handle
this series.

thanks,
-- Shuah
Tetsuo Handa March 5, 2021, 10:06 a.m. UTC | #2
On 2021/03/05 0:52, Shuah Khan wrote:
> As I said, it uses a simpler approach and reduces the number
> of changes. I would rather go with what I am working on.

Will you post it to ML so that people can review?
Shuah Khan March 5, 2021, 2:44 p.m. UTC | #3
On 3/5/21 3:06 AM, Tetsuo Handa wrote:
> On 2021/03/05 0:52, Shuah Khan wrote:
>> As I said, it uses a simpler approach and reduces the number
>> of changes. I would rather go with what I am working on.
> 
> Will you post it to ML so that people can review?
> 

Yes. All my patches go through mailing lists. :)

thanks,
-- Shuah