[v2,0/8] USB: cdc-acm: probe fixes

Message

Johan Hovold March 22, 2021, 3:53 p.m. UTC

This series fixes a couple of bugs in the probe errors paths and does
some clean up in preparation for adding the missing error handling when
claiming the data interface.

The first two should probably go into 5.12-rc, while the rest could be
held off for 5.13 if preferred.

Johan


Changes in v2
 - clarify that the driver already had a check for a bound data
   interface and remove the now redundant check (Oliver) (7/8)
 - add Oliver's ack to patches 1 through 6
 - add new to avoid logging a successful probe message on late errors
   (8/8)

Johan Hovold (8):
  USB: cdc-acm: fix double free on probe failure
  USB: cdc-acm: fix use-after-free after probe failure
  USB: cdc-acm: drop redundant driver-data assignment
  USB: cdc-acm: drop redundant driver-data reset
  USB: cdc-acm: clean up probe error labels
  USB: cdc-acm: use negation for NULL checks
  USB: cdc-acm: always claim data interface
  USB: cdc-acm: do not log successful probe on later errors

 drivers/usb/class/cdc-acm.c | 65 +++++++++++++++++++------------------
 1 file changed, 33 insertions(+), 32 deletions(-)

Comments

Greg Kroah-Hartman March 23, 2021, 12:27 p.m. UTC | #1

On Mon, Mar 22, 2021 at 04:53:10PM +0100, Johan Hovold wrote:
> This series fixes a couple of bugs in the probe errors paths and does
> some clean up in preparation for adding the missing error handling when
> claiming the data interface.
> 
> The first two should probably go into 5.12-rc, while the rest could be
> held off for 5.13 if preferred.

I'll just take them all for 5.12-rc, thanks!

greg k-h