mbox series

[0/4] USB: serial: add support for multi-interface functions

Message ID 20210330143820.9103-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: add support for multi-interface functions | expand

Message

Johan Hovold March 30, 2021, 2:38 p.m. UTC
A single USB function can be implemented using a group of interfaces and
this is for example commonly used for Communication Class devices.
    
This series adds support for multi-interface functions to USB serial
core and exports an interface that allows drivers to claim a second
sibling interface. The interface could easily be extended to allow
claiming further interfaces if ever needed.

The final patch uses the new interface to properly claim both the
control and data interface of Maxlinear/Exar devices.

Johan


Johan Hovold (4):
  USB: serial: drop unused suspending flag
  USB: serial: refactor endpoint classification
  USB: serial: add support for multi-interface functions
  USB: serial: xr: claim both interfaces

 drivers/usb/serial/usb-serial.c | 135 ++++++++++++++++++++++++--------
 drivers/usb/serial/xr_serial.c  |  26 +++++-
 include/linux/usb/serial.h      |   8 +-
 3 files changed, 131 insertions(+), 38 deletions(-)

Comments

Greg Kroah-Hartman March 30, 2021, 2:50 p.m. UTC | #1
On Tue, Mar 30, 2021 at 04:38:16PM +0200, Johan Hovold wrote:
> A single USB function can be implemented using a group of interfaces and
> this is for example commonly used for Communication Class devices.
>     
> This series adds support for multi-interface functions to USB serial
> core and exports an interface that allows drivers to claim a second
> sibling interface. The interface could easily be extended to allow
> claiming further interfaces if ever needed.
> 
> The final patch uses the new interface to properly claim both the
> control and data interface of Maxlinear/Exar devices.

Looks good, thanks for adding this:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold April 1, 2021, 8:09 a.m. UTC | #2
On Tue, Mar 30, 2021 at 04:50:02PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Mar 30, 2021 at 04:38:16PM +0200, Johan Hovold wrote:
> > A single USB function can be implemented using a group of interfaces and
> > this is for example commonly used for Communication Class devices.
> >     
> > This series adds support for multi-interface functions to USB serial
> > core and exports an interface that allows drivers to claim a second
> > sibling interface. The interface could easily be extended to allow
> > claiming further interfaces if ever needed.
> > 
> > The final patch uses the new interface to properly claim both the
> > control and data interface of Maxlinear/Exar devices.
> 
> Looks good, thanks for adding this:
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Now applied.

Johan