mbox series

[0/2] USB: serial: cp210x: provide gpio valid mask

Message ID 20210409155216.31867-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: cp210x: provide gpio valid mask | expand

Message

Johan Hovold April 9, 2021, 3:52 p.m. UTC
Use the new GPIO valid-mask feature to inform gpiolib which pins are
available for use instead of handling that in a request callback.
    
This also allows user space to figure out which pins are available
through the chardev interface without having to request each pin in
turn.

Johan


Johan Hovold (2):
  USB: serial: cp210x: provide gpio valid mask
  USB: serial: cp210x: add gpio-configuration debug printk

 drivers/usb/serial/cp210x.c | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

Comments

Andy Shevchenko April 9, 2021, 4:23 p.m. UTC | #1
On Fri, Apr 9, 2021 at 6:52 PM Johan Hovold <johan@kernel.org> wrote:
>
> Use the new GPIO valid-mask feature to inform gpiolib which pins are
> available for use instead of handling that in a request callback.
>
> This also allows user space to figure out which pins are available
> through the chardev interface without having to request each pin in
> turn.

Thanks! I like the series.
Independently on reaction on my comments:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Johan
>
>
> Johan Hovold (2):
>   USB: serial: cp210x: provide gpio valid mask
>   USB: serial: cp210x: add gpio-configuration debug printk
>
>  drivers/usb/serial/cp210x.c | 31 +++++++++++++++++++------------
>  1 file changed, 19 insertions(+), 12 deletions(-)
>
> --
> 2.26.3
>
Johan Hovold April 12, 2021, 10 a.m. UTC | #2
On Fri, Apr 09, 2021 at 07:23:11PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 9, 2021 at 6:52 PM Johan Hovold <johan@kernel.org> wrote:
> >
> > Use the new GPIO valid-mask feature to inform gpiolib which pins are
> > available for use instead of handling that in a request callback.
> >
> > This also allows user space to figure out which pins are available
> > through the chardev interface without having to request each pin in
> > turn.
> 
> Thanks! I like the series.
> Independently on reaction on my comments:
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Thanks for reviewing. Now applied.

Johan