mbox series

[v4,0/3] Fix cold plugged USB device on certain PCIe USB cards

Message ID 20210909064200.16216-1-kishon@ti.com (mailing list archive)
Headers show
Series Fix cold plugged USB device on certain PCIe USB cards | expand

Message

Kishon Vijay Abraham I Sept. 9, 2021, 6:41 a.m. UTC 
Cold plugged USB device was not detected on certain PCIe USB cards
(like Inateck card connected to AM64 EVM or connected to J7200 EVM).

Re-plugging the USB device always gets it enumerated.

This issue was discussed in
https://lore.kernel.org/r/772e4001-178e-4918-032c-6e625bdded24@ti.com
and
https://bugzilla.kernel.org/show_bug.cgi?id=214021

So the suggested solution is to register both root hubs along with the
second hcd for xhci.

RFC Patch series can be found at [1]
v1 Patch series can be found at [3]
v2 Patch series can be found at [4]
v3 Patch series can be found at [5]

Changes from RFC:
1) Mathias identified potential issues with the RFC patch [2] and suggested
   the solution to use HCD flags. This series implements it.

Changes from v1:
1) Fixed code comments pointed out by Alan Stern
2) Renamed the HCD flag variable to "HCD_FLAG_DEFER_RH_REGISTER" from
   "HCD_FLAG_DEFER_PRI_RH_REGISTER"

Changes from v2:
1) Fixed issue in error path handling pointed by Alan

Changes from v3:
1) Fix un-initialized variable usb_remove_hcd() and did some cleanup
suggested by Alan

[1] -> https://lore.kernel.org/linux-usb/20210824105302.25382-1-kishon@ti.com/
[2] -> https://lore.kernel.org/linux-usb/06693934-28f2-d59e-b004-62cabd3f9e8e@linux.intel.com
[3] -> https://lore.kernel.org/r/20210825105132.10420-1-kishon@ti.com
[4] -> https://lore.kernel.org/r/20210826111426.751-1-kishon@ti.com
[5] -> https://lore.kernel.org/r/20210908145146.GB603644@rowland.harvard.edu

Kishon Vijay Abraham I (3):
  usb: core: hcd: Add support for deferring roothub registration
  xhci: Set HCD flag to defer primary roothub registration
  usb: core: hcd: Modularize HCD stop configuration in usb_stop_hcd()

 drivers/usb/core/hcd.c  | 68 +++++++++++++++++++++++++++--------------
 drivers/usb/host/xhci.c |  1 +
 include/linux/usb/hcd.h |  2 ++
 3 files changed, 48 insertions(+), 23 deletions(-)