From patchwork Thu Sep 1 18:43:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wesley Cheng X-Patchwork-Id: 12963110 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9A7ECAAD1 for ; Thu, 1 Sep 2022 18:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234474AbiIASn5 (ORCPT ); Thu, 1 Sep 2022 14:43:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234217AbiIASni (ORCPT ); Thu, 1 Sep 2022 14:43:38 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E716057576; Thu, 1 Sep 2022 11:43:37 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 281G3R2o023463; Thu, 1 Sep 2022 18:43:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=wQg5lM5NIBdQXGGHQVaw+J/9CounQFBRQW/JKOyBH8U=; b=K9xA7v3rLqklzflVmtq/5NfkYoEqRN0tWLKi2vPNv8yCU8MsEeLMwKvm4VOVuzT1fC9q P3yi4VAeTPMV1WZjUVEHeaT3itLbBv33IilaYugYIn8L15EhPMfgYzdond6jOtSaK130 2McU+V4R5fRZoniz045zmSojyAP8z/prSxKd3pFLhiKcSy9VewKxpFHzlEi4AsLeBWi2 OHgROM6puDnA2x4WKsVipBV8/k8z5QbSfP6C+a/DVC9ziibA+y85TSKmGxLqVun6fN1k AFvZIC7oL+H0WDbNNuf5kAIHDfbRvYG5EM6hDSb7GD19qoCBwH4mQ+uVHcylYHQ0TT5e Yg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3javjc1ewk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Sep 2022 18:43:27 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 281IhQS3003522 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Sep 2022 18:43:26 GMT Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 1 Sep 2022 11:43:25 -0700 From: Wesley Cheng To: , , CC: , , , Wesley Cheng Subject: [PATCH v6 0/5] Fix controller halt and endxfer timeout issues Date: Thu, 1 Sep 2022 11:43:09 -0700 Message-ID: <20220901184314.30481-1-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 86QITRb23w9AnHXRKoae4rejx9hfx0XN X-Proofpoint-ORIG-GUID: 86QITRb23w9AnHXRKoae4rejx9hfx0XN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 bulkscore=0 mlxlogscore=652 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209010080 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Changes in v6: - Fix kernel bot errors/warnings. Changes in v5: - Rebased series on usb-testing from patch #5 onwards. Changes in v4: - Split the increase timeout patch into separate patches. #1 for the gadget suspend/resume locking changes #2 for the increased timeout - Modified msleep to usleep_range w/ an interval of 1-2ms and a max timeout of 4s. Changes in v3: - Modified the msleep() duration to ~2s versus ~10s due to the minimum mdelay() value. - Removed patch to modify DEP flags during dwc3_stop_active_transfer(). This was not required after fixing the logic to allow EP xfercomplete events to be handled on EP0. - Added some changes to account for a cable disconnect scenario, where dwc3_gadget_pullup() would not be executed to stop active transfers. Needed to add some logic to the disconnect interrupt to ensure that we cleanup/restart any pending SETUP transaction, so that we can clear the EP0 delayed stop status. (if pending) - Added patch to ensure that we don't proceed with umapping buffers until the endxfer was actually sent. Changes in v2: - Moved msleep() to before reading status register for halted state - Fixed kernel bot errors - Clearing DEP flags in __dwc3_stop_active_transfers() - Added Suggested-by tags and link references to previous discussions This patch series addresses some issues seen while testing with the latest soft disconnect implementation where EP events are allowed to process while the controller halt is occurring. #1 Since routines can now interweave, we can see that the soft disconnect can occur while conndone is being serviced. This leads to a controller halt timeout, as the soft disconnect clears the DEP flags, for which conndone interrupt handler will issue a __dwc3_ep_enable(ep0), that leads to re-issuing the set ep config command for every endpoint. #2 Function drivers can ask for a delayed_status phase, while it processes the received SETUP packet. This can lead to large delays when handling the soft disconnect routine. To improve the timing, forcefully send the status phase, as we are going to disconnect from the host. #3 Ensure that local interrupts are left enabled, so that EP0 events can be processed while the soft disconnect/dequeue is happening. #4 Since EP0 events can occur during controller halt, it may increase the time needed for the controller to fully stop. #5 Account for cable disconnect scenarios where nothing may cause the endxfer retry if DWC3_EP_DELAY_STOP is set. #6 Avoid unmapping pending USB requests that were never stopped. This would lead to a potential SMMU fault. Wesley Cheng (5): usb: dwc3: Avoid unmapping USB requests if endxfer is not complete usb: dwc3: Remove DWC3 locking during gadget suspend/resume usb: dwc3: Increase DWC3 controller halt timeout usb: dwc3: gadget: Skip waiting for CMDACT cleared during endxfer usb: dwc3: gadget: Submit endxfer command if delayed during disconnect drivers/usb/dwc3/core.c | 4 ---- drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/ep0.c | 5 ++++- drivers/usb/dwc3/gadget.c | 31 +++++++++++++++++++++++++++---- 4 files changed, 34 insertions(+), 9 deletions(-)