mbox series

[PATCHv1,0/3] generic-ohci/ehci: add RK3588 support

Message ID 20230406135552.23980-1-sebastian.reichel@collabora.com (mailing list archive)
Headers show
Series generic-ohci/ehci: add RK3588 support | expand

Message

Sebastian Reichel April 6, 2023, 1:55 p.m. UTC 
Hi,

This increases the max. allowed clocks for generic-ohci from 3 to 4.
On RK3588 a total of 4 clocks is required to access the OHCI registers.
EHCI already supports 4 clocks.

Changes since PATCHv2:
 * https://lore.kernel.org/all/20230404145350.45388-1-sebastian.reichel@collabora.com/
 * Added Krzysztof's Ack to the EHCI binding update
 * Changed OHCI binding update according to Krzysztof's feedback

Changes since PATCHv1:
 * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
 * changed cover-letter subject
 * Add Alan's Acked-by to the driver patch increasing the clock count
 * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles

-- Sebastian

Sebastian Reichel (3):
  dt-bindings: usb: Add RK3588 OHCI
  dt-bindings: usb: Add RK3588 EHCI
  usb: host: ohci-platform: increase max clock number to 4

 .../devicetree/bindings/usb/generic-ehci.yaml  |  1 +
 .../devicetree/bindings/usb/generic-ohci.yaml  | 18 +++++++++++++++++-
 drivers/usb/host/ohci-platform.c               |  2 +-
 3 files changed, 19 insertions(+), 2 deletions(-)

Comments

Sebastian Reichel April 6, 2023, 2:09 p.m. UTC | #1 
Hi,

On Thu, Apr 06, 2023 at 03:55:49PM +0200, Sebastian Reichel wrote:
> This increases the max. allowed clocks for generic-ohci from 3 to 4.
> On RK3588 a total of 4 clocks is required to access the OHCI registers.
> EHCI already supports 4 clocks.
> 
> Changes since PATCHv2:
>  * https://lore.kernel.org/all/20230404145350.45388-1-sebastian.reichel@collabora.com/
>  * Added Krzysztof's Ack to the EHCI binding update
>  * Changed OHCI binding update according to Krzysztof's feedback
> 
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
>  * changed cover-letter subject
>  * Add Alan's Acked-by to the driver patch increasing the clock count
>  * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles

Sorry, this is PATCHv3. I somehow missed the point from Greg last
time (and thought it was about the subject) and even forgot to
increase the patch version yet another time :(

I will give some time for DT people to review the OHCI binding patch
and then send it again with version increased to v4, so that it can
easily be applied with b4. Sorry for the confusion.

-- Sebastian