mbox series

[v3,0/2] Handle core soft reset failure in pullup

Message ID 20230510075252.31023-1-quic_kriskura@quicinc.com (mailing list archive)
Headers show
Series Handle core soft reset failure in pullup | expand

Message

Krishna Kurapati May 10, 2023, 7:52 a.m. UTC 
When core soft reset timeout happens, pullup doesn't check for the
return value and proceeds setting up of event buffers and starts the
controller.

In this scneario, it is observed sometimes that the GEVTADDR LO/HI
registers read zero while we are setting the run stop bit and we end
up accessing address 0x00 leading to a crash. This series tries to
address this issue by handling the timeout and return back appropriate
error code to configfs for it to retry enumeration if it chooses to.

Link to v1: https://lore.kernel.org/all/20230322092740.28491-1-quic_kriskura@quicinc.com/
Link to v2: https://lore.kernel.org/all/20230328160756.30520-1-quic_kriskura@quicinc.com/

changes in v3:
Rebased on top of latest usb-next to resolve merge issues
Fixed comments from v2 related to code styling

changes in v2:
Fixed comments addressing incomplete error handling in udc core

Krishna Kurapati (2):
  usb: dwc3: gadget: Bail out in pullup if soft reset timeout happens
  usb: gadget: udc: Handle gadget_connect failure during bind operation

 drivers/usb/dwc3/gadget.c     |  5 ++++-
 drivers/usb/gadget/udc/core.c | 21 +++++++++++++++++----
 2 files changed, 21 insertions(+), 5 deletions(-)