| Message ID | 20231004165922.25642-1-quic_kriskura@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add multiport support for DWC3 controllers | expand |
On Wed, Oct 04, 2023 at 10:29:19PM +0530, Krishna Kurapati wrote: > This series is a set of picked up acks and split from larger series [1] > The series is rebased on top of: > Repo: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > Branch: usb-testing > commit 03cf2af41b37 ("Revert "phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support"") > > The patches present in series have been reviewed and acked by respective > maintainers. They dont break any existing implementation and is just a > subset of merge ready multiport code. The rest of the patches will be > rebased on top of the usb branch once this series is merged. > > [1]: https://patchwork.kernel.org/project/linux-usb/cover/20230828133033.11988-1-quic_kriskura@quicinc.com/ > > Krishna Kurapati (3): > usb: dwc3: core: Access XHCI address space temporarily to read port > info > usb: dwc3: core: Skip setting event buffers for host only controllers > usb: dwc3: qcom: Add helper function to request threaded IRQ NAK. These patches make very little sense on their own and can't really be evaluated without the context of the larger series. Just work on getting the multiport series in shape and include any acks you've received so far when submitting new revisions. Johan
On 10/5/2023 12:06 PM, Johan Hovold wrote: > On Wed, Oct 04, 2023 at 10:29:19PM +0530, Krishna Kurapati wrote: >> This series is a set of picked up acks and split from larger series [1] >> The series is rebased on top of: >> Repo: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> Branch: usb-testing >> commit 03cf2af41b37 ("Revert "phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support"") >> >> The patches present in series have been reviewed and acked by respective >> maintainers. They dont break any existing implementation and is just a >> subset of merge ready multiport code. The rest of the patches will be >> rebased on top of the usb branch once this series is merged. >> >> [1]: https://patchwork.kernel.org/project/linux-usb/cover/20230828133033.11988-1-quic_kriskura@quicinc.com/ >> >> Krishna Kurapati (3): >> usb: dwc3: core: Access XHCI address space temporarily to read port >> info >> usb: dwc3: core: Skip setting event buffers for host only controllers >> usb: dwc3: qcom: Add helper function to request threaded IRQ > > NAK. > > These patches make very little sense on their own and can't really be > evaluated without the context of the larger series. > > Just work on getting the multiport series in shape and include any acks > you've received so far when submitting new revisions. > Hi Johan, This may be partially true for first patch of this series, (where we read num_ports), but the other two patches are self explanatory and are applicable for non-mp controllers as well. Intention was to ensure we make the next rebase easy. Will try to address all comments and send v12 again as a whole series this week. I am actually blocked on [1]. Not able to repro the compile error on my end. That's what stopped me from sending all at once. [1]: https://lore.kernel.org/all/202309200156.CxQ3yaLY-lkp@intel.com/ Thanks, Krishna,
On 10/5/2023 12:06 PM, Johan Hovold wrote: > On Wed, Oct 04, 2023 at 10:29:19PM +0530, Krishna Kurapati wrote: >> This series is a set of picked up acks and split from larger series [1] >> The series is rebased on top of: >> Repo: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> Branch: usb-testing >> commit 03cf2af41b37 ("Revert "phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support"") >> >> The patches present in series have been reviewed and acked by respective >> maintainers. They dont break any existing implementation and is just a >> subset of merge ready multiport code. The rest of the patches will be >> rebased on top of the usb branch once this series is merged. >> >> [1]: https://patchwork.kernel.org/project/linux-usb/cover/20230828133033.11988-1-quic_kriskura@quicinc.com/ >> >> Krishna Kurapati (3): >> usb: dwc3: core: Access XHCI address space temporarily to read port >> info >> usb: dwc3: core: Skip setting event buffers for host only controllers >> usb: dwc3: qcom: Add helper function to request threaded IRQ > > NAK. > > These patches make very little sense on their own and can't really be > evaluated without the context of the larger series. > > Just work on getting the multiport series in shape and include any acks > you've received so far when submitting new revisions Hi Johan, This may be partially true for first patch of this series, (where we read num_ports), but the other two patches are self explanatory and are applicable for non-mp controllers as well. Intention was to ensure we make the next rebase easy. Will try to address all comments and send v12 again as a whole series this week. I am actually blocked on [1]. Not able to repro the compile error on my end. That's what stopped me from sending all at once. [1]: https://lore.kernel.org/all/202309200156.CxQ3yaLY-lkp@intel.com/ PS: I sent this mail once but some issue with my mail client and the mail didn't reach the mailing list. If two copies of same mail comes up, pls ignore it. Thanks, Krishna,
On Thu, Oct 05, 2023 at 02:32:54PM +0530, Krishna Kurapati PSSNV wrote: > On 10/5/2023 12:06 PM, Johan Hovold wrote: > > On Wed, Oct 04, 2023 at 10:29:19PM +0530, Krishna Kurapati wrote: > >> Krishna Kurapati (3): > >> usb: dwc3: core: Access XHCI address space temporarily to read port > >> info > >> usb: dwc3: core: Skip setting event buffers for host only controllers > >> usb: dwc3: qcom: Add helper function to request threaded IRQ > > > > NAK. > > > > These patches make very little sense on their own and can't really be > > evaluated without the context of the larger series. > > > > Just work on getting the multiport series in shape and include any acks > > you've received so far when submitting new revisions. > This may be partially true for first patch of this series, (where we > read num_ports), but the other two patches are self explanatory and are > applicable for non-mp controllers as well. Intention was to ensure we > make the next rebase easy. No, just send the whole series at once. > Will try to address all comments and send v12 again as a whole series > this week. I am actually blocked on [1]. Not able to repro the compile > error on my end. That's what stopped me from sending all at once. Looks like your buffer is too small for a u8 index. Should be easy to fix. Johan > [1]: https://lore.kernel.org/all/202309200156.CxQ3yaLY-lkp@intel.com/
This series is a set of picked up acks and split from larger series [1] The series is rebased on top of: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git Branch: usb-testing commit 03cf2af41b37 ("Revert "phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support"") The patches present in series have been reviewed and acked by respective maintainers. They dont break any existing implementation and is just a subset of merge ready multiport code. The rest of the patches will be rebased on top of the usb branch once this series is merged. [1]: https://patchwork.kernel.org/project/linux-usb/cover/20230828133033.11988-1-quic_kriskura@quicinc.com/ Krishna Kurapati (3): usb: dwc3: core: Access XHCI address space temporarily to read port info usb: dwc3: core: Skip setting event buffers for host only controllers usb: dwc3: qcom: Add helper function to request threaded IRQ drivers/usb/dwc3/core.c | 74 ++++++++++++++++++++++++++++++++++++ drivers/usb/dwc3/core.h | 5 +++ drivers/usb/dwc3/dwc3-qcom.c | 59 +++++++++++++--------------- 3 files changed, 105 insertions(+), 33 deletions(-)