| Message ID | 20231204104534.1335903-1-mathias.nyman@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xhci features for usb-next | expand |
On Mon, Dec 04, 2023 at 12:45:16PM +0200, Mathias Nyman wrote: > Hi Greg > > V2 of xhci features and cleanups for usb-next, including xhci dbc > cleanups, MSI rework, and fixing how we reconfigure max packet size > for xhc. > > One patch fixes a null pointer deref issue, but this hasn't been seen > in real life. It's a theoretical case triggered by adding a 3 second > delay in the driver. > So I don't think it should go to stable. > > v2 drops one small cleanup patch as it turned out to not really clarify or > simplify things. This was [PATCH 08/19] "xhci: dbc: Use sizeof_field() > where it makes sense" in previous series. > Link: https://lore.kernel.org/linux-usb/20231201150647.1307406-9-mathias.nyman@linux.intel.com Ick, I just applied all of the v1 series, we crossed emails, sorry, my fault. But, to be fair, I think your patch is correct, so let me leave it in, if it's not buggy. thanks, greg k-h
On 4.12.2023 15.20, Greg KH wrote: > On Mon, Dec 04, 2023 at 12:45:16PM +0200, Mathias Nyman wrote: >> Hi Greg >> >> V2 of xhci features and cleanups for usb-next, including xhci dbc >> cleanups, MSI rework, and fixing how we reconfigure max packet size >> for xhc. >> >> One patch fixes a null pointer deref issue, but this hasn't been seen >> in real life. It's a theoretical case triggered by adding a 3 second >> delay in the driver. >> So I don't think it should go to stable. >> >> v2 drops one small cleanup patch as it turned out to not really clarify or >> simplify things. This was [PATCH 08/19] "xhci: dbc: Use sizeof_field() >> where it makes sense" in previous series. >> Link: https://lore.kernel.org/linux-usb/20231201150647.1307406-9-mathias.nyman@linux.intel.com > > Ick, I just applied all of the v1 series, we crossed emails, sorry, my > fault. > > But, to be fair, I think your patch is correct, so let me leave it in, > if it's not buggy. > Yes, it should work just fine. It can be optimized later if someone is still interested. Thanks Mathias
Hi Greg V2 of xhci features and cleanups for usb-next, including xhci dbc cleanups, MSI rework, and fixing how we reconfigure max packet size for xhc. One patch fixes a null pointer deref issue, but this hasn't been seen in real life. It's a theoretical case triggered by adding a 3 second delay in the driver. So I don't think it should go to stable. v2 drops one small cleanup patch as it turned out to not really clarify or simplify things. This was [PATCH 08/19] "xhci: dbc: Use sizeof_field() where it makes sense" in previous series. Link: https://lore.kernel.org/linux-usb/20231201150647.1307406-9-mathias.nyman@linux.intel.com Thanks Mathias Andy Shevchenko (9): xhci: dbc: Drop duplicate checks for dma_free_coherent() xhci: dbc: Convert to use sysfs_streq() xhci: dbc: Use sysfs_emit() to instead of scnprintf() xhci: dbc: Use ATTRIBUTE_GROUPS() xhci: dbc: Check for errors first in xhci_dbc_stop() xhci: dbc: Don't shadow error codes in store() functions xhci: dbc: Replace custom return value with proper Linux error code xhci: dbc: Use sizeof(*pointer) instead of sizeof(type) xhci: dbc: Add missing headers Mathias Nyman (2): xhci: Reconfigure endpoint 0 max packet size only during endpoint reset xhci: fix possible null pointer deref during xhci urb enqueue Niklas Neronin (7): xhci: check if legacy irq is available before using it as fallback xhci: add handler for only one interrupt line xhci: refactor static MSI-X function xhci: refactor static MSI function xhci: change 'msix_count' to encompass MSI or MSI-X vectors xhci: rework 'xhci_try_enable_msi()' MSI and MSI-X setup code xhci: minor coding style cleanup in 'xhci_try_enable_msi()' drivers/usb/host/xhci-dbgcap.c | 130 +++++++++++++++--------------- drivers/usb/host/xhci-dbgcap.h | 1 + drivers/usb/host/xhci-pci.c | 140 +++++++++------------------------ drivers/usb/host/xhci.c | 123 +++++++++++++++-------------- drivers/usb/host/xhci.h | 4 +- 5 files changed, 174 insertions(+), 224 deletions(-)