mbox series

[v3,0/2] Do not read the IO hints VPD page from USB storage devices

Message ID 20240613211828.2077477-1-bvanassche@acm.org (mailing list archive)
Headers show
Series Do not read the IO hints VPD page from USB storage devices | expand

Message

Bart Van Assche June 13, 2024, 9:18 p.m. UTC
Hi Martin,

Recently it was reported that reading the IO hints VPD page makes at least two
USB storage devices crash. Hence this patch series that disables reading the IO
hints VPD page from USB storage devices. Please consider this patch series for
your scsi-fixes branch.

Thanks,

Bart.

Changes compared to v2:
 - Changed "IO hints VPD page" into "IO Advice Hints Grouping mode page".
 - Changed "scsi: core: " prefix for patch 2/2 into "usb: ".
 - Removed redundant Cc-tags.

Changes compared to v1:
 - Also set the BLIST_SKIP_IO_HINTS for USB Attached SCSI devices.

Bart Van Assche (2):
  scsi: core: Introduce the BLIST_SKIP_IO_HINTS flag
  usb: Do not query the IO advice hints grouping mode page for USB
    devices

 drivers/scsi/sd.c              | 4 ++++
 drivers/usb/storage/scsiglue.c | 6 ++++++
 drivers/usb/storage/uas.c      | 7 +++++++
 include/scsi/scsi_devinfo.h    | 4 +++-
 4 files changed, 20 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen June 14, 2024, 2:23 a.m. UTC | #1
On Thu, 13 Jun 2024 14:18:25 -0700, Bart Van Assche wrote:

> Recently it was reported that reading the IO hints VPD page makes at least two
> USB storage devices crash. Hence this patch series that disables reading the IO
> hints VPD page from USB storage devices. Please consider this patch series for
> your scsi-fixes branch.
> 
> Thanks,
> 
> [...]

Applied to 6.10/scsi-fixes, thanks!

[1/2] scsi: core: Introduce the BLIST_SKIP_IO_HINTS flag
      https://git.kernel.org/mkp/scsi/c/633aeefafc9c
[2/2] usb: Do not query the IO advice hints grouping mode page for USB devices
      https://git.kernel.org/mkp/scsi/c/57619f3cdeb5