| Message ID | 20240826081900.2284-1-liulei.rjpt@vivo.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb drivers use devm_clk_get_enabled() helpers | expand |
On Mon, 26 Aug 2024 at 10:19, Lei Liu <liulei.rjpt@vivo.com> wrote: > > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). As I stated on another thread too [1], using devm_clk_get_enabled() isn't solely a nice cleanup of the code. It may actually introduce a change in behaviour. Therefore, I would not recommend applying that kind of changes, unless some of the maintainers acks it or it gets tested on real HW. Kind regards Uffe [1] https://lore.kernel.org/all/20240827074857.2671808-1-xirui.zhang@vivo.com/ > > --- > version 3 changes > Fix the email thread. > > --- > version 2 changes > > The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of > certain interfaces due to the lack of synchronization during the > commit updates. These issues have been corrected in the v1 version. > > 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to > devm_clk_get_enabled(). > 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to > devm_clk_get_enabled(). > 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be > corrected to devm_clk_get_enabled(). > > Lei Liu (5): > usb: aspeed_udc: Use devm_clk_get_enabled() helpers > usb: pxa27x_udc: Use devm_clk_get_enabled() helpers > usb: r8a66597-udc: Use devm_clk_get_enabled() helpers > usb: mpfs: Use devm_clk_get_enabled() helpers > sb: ux500: Use devm_clk_get_enabled() helpers > > drivers/usb/gadget/udc/aspeed_udc.c | 9 +-------- > drivers/usb/gadget/udc/pxa27x_udc.c | 6 +----- > drivers/usb/gadget/udc/r8a66597-udc.c | 16 ++++------------ > drivers/usb/musb/mpfs.c | 22 ++++++---------------- > drivers/usb/musb/ux500.c | 18 ++++-------------- > 5 files changed, 16 insertions(+), 55 deletions(-) > > -- > 2.34.1 > >
The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids calls to clk_disable_unprepare(). --- version 3 changes Fix the email thread. --- version 2 changes The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of certain interfaces due to the lack of synchronization during the commit updates. These issues have been corrected in the v1 version. 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to devm_clk_get_enabled(). 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to devm_clk_get_enabled(). 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be corrected to devm_clk_get_enabled(). Lei Liu (5): usb: aspeed_udc: Use devm_clk_get_enabled() helpers usb: pxa27x_udc: Use devm_clk_get_enabled() helpers usb: r8a66597-udc: Use devm_clk_get_enabled() helpers usb: mpfs: Use devm_clk_get_enabled() helpers sb: ux500: Use devm_clk_get_enabled() helpers drivers/usb/gadget/udc/aspeed_udc.c | 9 +-------- drivers/usb/gadget/udc/pxa27x_udc.c | 6 +----- drivers/usb/gadget/udc/r8a66597-udc.c | 16 ++++------------ drivers/usb/musb/mpfs.c | 22 ++++++---------------- drivers/usb/musb/ux500.c | 18 ++++-------------- 5 files changed, 16 insertions(+), 55 deletions(-)