mbox series

[0/2] Fix sum_trb_lengths()

Message ID 20240910160114.50b77a91@foxbook (mailing list archive)
Headers show
Series Fix sum_trb_lengths() | expand

Message

Michał Pecio Sept. 10, 2024, 2:01 p.m. UTC 
Hi,

This function sums from ring->dequeue instead of td->first_trb, and
this is even documented. Makes no sense and doesn't work right.

I searched xhci-ring.c and this appears to be the last such abuse of
'dequeue' still surviving to this day.

Regards,
Michal

Comments

Mathias Nyman Sept. 11, 2024, 3:48 p.m. UTC | #1 
On 10.9.2024 17.01, Michal Pecio wrote:
> Hi,
> 
> This function sums from ring->dequeue instead of td->first_trb, and
> this is even documented. Makes no sense and doesn't work right.
> 
> I searched xhci-ring.c and this appears to be the last such abuse of
> 'dequeue' still surviving to this day.
> 
> Regards,
> Michal
> 

Thanks, both patches added to queue

-Mathias