| Message ID | 20240925031135.1101048-1-amitsd@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for time DT property in TCPM | expand |
Hi, I had a process related question. Once an RFC patchset gets a Reviewed-by tag, do I need to send a formal [PATCH] or is an RFC patch sufficient for being accepted? I tried to look for it in the Kernel documentation but couldn't find. Please can you help me on the next steps. Thanks, Amit On 9/24/24 8:11 PM, Amit Sunil Dhamne wrote: > USB PD specification defines a bunch of timers that can have a range of > acceptable values instead of specific values. These values have to be > tuned based on the platform. However, TCPM currently sets them to a > default value without providing a mechanism to set platform specific > values. > > This patchset adds new DT properties per timer to allow users to define > platform specific values. > > Changes compared to v3: > - nit: removed an extra newline that got added in tcpm_register_port() > > Changes compared to v2: > - Added min, max & default values to DT property in Documentation. > - Changed return type of tcpm_fw_get_timings to void instead of int. > > Changes compared to v1: > - Defined new properties per timer that we are interested in rather > than defining a single pd-timers u32 array property. > - Better description of the timer properties. > - Since subject has changed, adding link for previous patchset for > posterity: > https://lore.kernel.org/all/20240911000715.554184-1-amitsd@google.com/ > > Amit Sunil Dhamne (2): > dt-bindings: connector: Add properties to define time values > usb: typec: tcpm: Add support for parsing time dt properties > > .../bindings/connector/usb-connector.yaml | 35 ++++++++- > drivers/usb/typec/tcpm/tcpm.c | 73 +++++++++++++++---- > 2 files changed, 91 insertions(+), 17 deletions(-) > > > base-commit: 68d4209158f43a558c5553ea95ab0c8975eab18c
On Mon, Oct 21, 2024 at 04:01:10PM -0700, Amit Sunil Dhamne wrote: > Hi, > > I had a process related question. Once an RFC patchset gets a Reviewed-by > tag, do I need to send a formal [PATCH] or is an RFC patch sufficient for > being accepted? You need to send a real series (and please do not top-post), for it to be considered for being accepted. thanks, greg k-h
USB PD specification defines a bunch of timers that can have a range of acceptable values instead of specific values. These values have to be tuned based on the platform. However, TCPM currently sets them to a default value without providing a mechanism to set platform specific values. This patchset adds new DT properties per timer to allow users to define platform specific values. Changes compared to v3: - nit: removed an extra newline that got added in tcpm_register_port() Changes compared to v2: - Added min, max & default values to DT property in Documentation. - Changed return type of tcpm_fw_get_timings to void instead of int. Changes compared to v1: - Defined new properties per timer that we are interested in rather than defining a single pd-timers u32 array property. - Better description of the timer properties. - Since subject has changed, adding link for previous patchset for posterity: https://lore.kernel.org/all/20240911000715.554184-1-amitsd@google.com/ Amit Sunil Dhamne (2): dt-bindings: connector: Add properties to define time values usb: typec: tcpm: Add support for parsing time dt properties .../bindings/connector/usb-connector.yaml | 35 ++++++++- drivers/usb/typec/tcpm/tcpm.c | 73 +++++++++++++++---- 2 files changed, 91 insertions(+), 17 deletions(-) base-commit: 68d4209158f43a558c5553ea95ab0c8975eab18c