mbox series

[00/14] usb: dwc2: Fix Partial Power down issues.

Message ID cover.1617782102.git.Arthur.Petrosyan@synopsys.com (mailing list archive)
Headers show
Series usb: dwc2: Fix Partial Power down issues. | expand

Message

Artur Petrosyan April 7, 2021, 10 a.m. UTC
This patch set fixes and improves the Partial Power Down mode for
dwc2 core.
It adds support for the following cases
    1. Entering and exiting partial power down when a port is
       suspended, resumed, port reset is asserted.
    2. Exiting the partial power down mode before removing driver.
    3. Exiting partial power down in wakeup detected interrupt handler.
    4. Exiting from partial power down mode when connector ID.
       status changes to "connId B

It updates and fixes the implementation of dwc2 entering and
exiting partial power down mode when the system (PC) is suspended.

The patch set also improves the implementation of function handlers
for entering and exiting host or device partial power down.

NOTE: This is the second patch set in the power saving mode fixes
series.
This patch set is part of multiple series and is continuation
of the "usb: dwc2: Fix and improve power saving modes" patch set.
(Patch set link: https://marc.info/?l=linux-usb&m=160379622403975&w=2).
The patches that were included in the "usb: dwc2:
Fix and improve power saving modes" which was submitted
earlier was too large and needed to be split up into
smaller patch sets. 


Artur Petrosyan (14):
  usb: dwc2: Add device partial power down functions
  usb: dwc2: Add host partial power down functions
  usb: dwc2: Update enter and exit partial power down functions
  usb: dwc2: Add partial power down exit flow in wakeup intr.
  usb: dwc2: Update port suspend/resume function definitions.
  usb: dwc2: Add enter partial power down when port is suspended
  usb: dwc2: Add exit partial power down when port is resumed
  usb: dwc2: Add exit partial power down when port reset is asserted
  usb: dwc2: Add part. power down exit from
    dwc2_conn_id_status_change().
  usb: dwc2: Allow exit partial power down in urb enqueue
  usb: dwc2: Fix session request interrupt handler
  usb: dwc2: Update partial power down entering by system suspend
  usb: dwc2: Fix partial power down exiting by system resume
  usb: dwc2: Add exit partial power down before removing driver

 drivers/usb/dwc2/core.c      | 113 ++-------
 drivers/usb/dwc2/core.h      |  27 ++-
 drivers/usb/dwc2/core_intr.c |  46 ++--
 drivers/usb/dwc2/gadget.c    | 148 ++++++++++-
 drivers/usb/dwc2/hcd.c       | 458 +++++++++++++++++++++++++----------
 drivers/usb/dwc2/hw.h        |   1 +
 drivers/usb/dwc2/platform.c  |  11 +-
 7 files changed, 558 insertions(+), 246 deletions(-)


base-commit: e9fcb07704fcef6fa6d0333fd2b3a62442eaf45b

Comments

Artur Petrosyan April 8, 2021, 5:57 a.m. UTC | #1
Hi Greg,

On 4/7/2021 14:00, Artur Petrosyan wrote:
> This patch set fixes and improves the Partial Power Down mode for
> dwc2 core.
> It adds support for the following cases
>      1. Entering and exiting partial power down when a port is
>         suspended, resumed, port reset is asserted.
>      2. Exiting the partial power down mode before removing driver.
>      3. Exiting partial power down in wakeup detected interrupt handler.
>      4. Exiting from partial power down mode when connector ID.
>         status changes to "connId B
> 
> It updates and fixes the implementation of dwc2 entering and
> exiting partial power down mode when the system (PC) is suspended.
> 
> The patch set also improves the implementation of function handlers
> for entering and exiting host or device partial power down.
> 
> NOTE: This is the second patch set in the power saving mode fixes
> series.
> This patch set is part of multiple series and is continuation
> of the "usb: dwc2: Fix and improve power saving modes" patch set.
> (Patch set link: https://marc.info/?l=linux-usb&m=160379622403975&w=2).
> The patches that were included in the "usb: dwc2:
> Fix and improve power saving modes" which was submitted
> earlier was too large and needed to be split up into
> smaller patch sets.
> 
> 
> Artur Petrosyan (14):
>    usb: dwc2: Add device partial power down functions
>    usb: dwc2: Add host partial power down functions
>    usb: dwc2: Update enter and exit partial power down functions
>    usb: dwc2: Add partial power down exit flow in wakeup intr.
>    usb: dwc2: Update port suspend/resume function definitions.
>    usb: dwc2: Add enter partial power down when port is suspended
>    usb: dwc2: Add exit partial power down when port is resumed
>    usb: dwc2: Add exit partial power down when port reset is asserted
>    usb: dwc2: Add part. power down exit from
>      dwc2_conn_id_status_change().
>    usb: dwc2: Allow exit partial power down in urb enqueue
>    usb: dwc2: Fix session request interrupt handler
>    usb: dwc2: Update partial power down entering by system suspend
>    usb: dwc2: Fix partial power down exiting by system resume
>    usb: dwc2: Add exit partial power down before removing driver
> 
>   drivers/usb/dwc2/core.c      | 113 ++-------
>   drivers/usb/dwc2/core.h      |  27 ++-
>   drivers/usb/dwc2/core_intr.c |  46 ++--
>   drivers/usb/dwc2/gadget.c    | 148 ++++++++++-
>   drivers/usb/dwc2/hcd.c       | 458 +++++++++++++++++++++++++----------
>   drivers/usb/dwc2/hw.h        |   1 +
>   drivers/usb/dwc2/platform.c  |  11 +-
>   7 files changed, 558 insertions(+), 246 deletions(-)
> 
> 
> base-commit: e9fcb07704fcef6fa6d0333fd2b3a62442eaf45b
> 
I have submitted this patch set yesterday. It contains 14 patches. But 
only 2 of those patches were received by LKML only the cover letter and 
the 13th patch. 
(https://lore.kernel.org/linux-usb/cover.1617782102.git.Arthur.Petrosyan@synopsys.com/T/#t)

I checked here at Synopsys, Minas did receive all the patches as his 
email is in To list. Could this be an issue of vger.kernel.org mailing 
server?

Because I checked every local possibility that could result to such 
behavior. The patch 13 which was received by LKML has the similar 
content as the other patches.

The mailing tool that was used is ssmtp, checked all the configurations 
everything is fine.

Could you please suggest what should I do in this situation?

Regards,
Artur
Greg Kroah-Hartman April 8, 2021, 6:09 a.m. UTC | #2
On Thu, Apr 08, 2021 at 05:57:57AM +0000, Artur Petrosyan wrote:
> Hi Greg,
> 
> On 4/7/2021 14:00, Artur Petrosyan wrote:
> > This patch set fixes and improves the Partial Power Down mode for
> > dwc2 core.
> > It adds support for the following cases
> >      1. Entering and exiting partial power down when a port is
> >         suspended, resumed, port reset is asserted.
> >      2. Exiting the partial power down mode before removing driver.
> >      3. Exiting partial power down in wakeup detected interrupt handler.
> >      4. Exiting from partial power down mode when connector ID.
> >         status changes to "connId B
> > 
> > It updates and fixes the implementation of dwc2 entering and
> > exiting partial power down mode when the system (PC) is suspended.
> > 
> > The patch set also improves the implementation of function handlers
> > for entering and exiting host or device partial power down.
> > 
> > NOTE: This is the second patch set in the power saving mode fixes
> > series.
> > This patch set is part of multiple series and is continuation
> > of the "usb: dwc2: Fix and improve power saving modes" patch set.
> > (Patch set link: https://marc.info/?l=linux-usb&m=160379622403975&w=2).
> > The patches that were included in the "usb: dwc2:
> > Fix and improve power saving modes" which was submitted
> > earlier was too large and needed to be split up into
> > smaller patch sets.
> > 
> > 
> > Artur Petrosyan (14):
> >    usb: dwc2: Add device partial power down functions
> >    usb: dwc2: Add host partial power down functions
> >    usb: dwc2: Update enter and exit partial power down functions
> >    usb: dwc2: Add partial power down exit flow in wakeup intr.
> >    usb: dwc2: Update port suspend/resume function definitions.
> >    usb: dwc2: Add enter partial power down when port is suspended
> >    usb: dwc2: Add exit partial power down when port is resumed
> >    usb: dwc2: Add exit partial power down when port reset is asserted
> >    usb: dwc2: Add part. power down exit from
> >      dwc2_conn_id_status_change().
> >    usb: dwc2: Allow exit partial power down in urb enqueue
> >    usb: dwc2: Fix session request interrupt handler
> >    usb: dwc2: Update partial power down entering by system suspend
> >    usb: dwc2: Fix partial power down exiting by system resume
> >    usb: dwc2: Add exit partial power down before removing driver
> > 
> >   drivers/usb/dwc2/core.c      | 113 ++-------
> >   drivers/usb/dwc2/core.h      |  27 ++-
> >   drivers/usb/dwc2/core_intr.c |  46 ++--
> >   drivers/usb/dwc2/gadget.c    | 148 ++++++++++-
> >   drivers/usb/dwc2/hcd.c       | 458 +++++++++++++++++++++++++----------
> >   drivers/usb/dwc2/hw.h        |   1 +
> >   drivers/usb/dwc2/platform.c  |  11 +-
> >   7 files changed, 558 insertions(+), 246 deletions(-)
> > 
> > 
> > base-commit: e9fcb07704fcef6fa6d0333fd2b3a62442eaf45b
> > 
> I have submitted this patch set yesterday. It contains 14 patches. But 
> only 2 of those patches were received by LKML only the cover letter and 
> the 13th patch. 
> (https://lore.kernel.org/linux-usb/cover.1617782102.git.Arthur.Petrosyan@synopsys.com/T/#t)
> 
> I checked here at Synopsys, Minas did receive all the patches as his 
> email is in To list. Could this be an issue of vger.kernel.org mailing 
> server?
> 
> Because I checked every local possibility that could result to such 
> behavior. The patch 13 which was received by LKML has the similar 
> content as the other patches.
> 
> The mailing tool that was used is ssmtp, checked all the configurations 
> everything is fine.
> 
> Could you please suggest what should I do in this situation?

Odd, I got them here, but lore seems to not have them :(

Can you just resend them as a "v2" series so we know which to review and
let's see if that works better...

thanks,

greg k-h