| Message ID | 055de764-c422-4c22-a79b-dd4db56122ce@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h | expand |
On Fri, Oct 27, 2023 at 03:15:46PM +0300, LihaSika wrote: > On 27.10.2023 4.27, Bagas Sanjaya wrote: > > On Thu, Oct 26, 2023 at 10:39:14PM +0300, LihaSika wrote: > > > On 26.10.2023 22.14, Greg KH wrote: > > > > Please submit a proper patch to the linux-usb@vger.kernel.org mailing > > > > list and we will be glad to take it from there. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > OK, here it is! > > > > > > Best regards, > > > L. > > > -- > > > > > > $ cat lihasika-unusual_cypress.patch > > > diff --git a/drivers/usb/storage/unusual_cypress.h > > > b/drivers/usb/storage/unusual_cypress.h > > > index 0547daf..7b3d5f0 100644 > > > --- a/drivers/usb/storage/unusual_cypress.h > > > +++ b/drivers/usb/storage/unusual_cypress.h > > > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > > > "Cypress ISD-300LP", > > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > > > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > > > "Super Top", > > > "USB 2.0 SATA BRIDGE", > > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > > Hi LihaSika, > > > > Please follow proper patch submission process in order to get above patch > > accepted. See Documentation/process/submitting-patches.rst in the kernel > > sources for how to do that properly. You may also consider adding > > `Cc: stable@vger.kernel.org` trailer in your patch to mark it to be > > backported to stable kernels (including one you use). > > > > Thanks. > > > > All right, here's a new attempt. Is it OK now? > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h > b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
> - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > and can not be applied. Please read the file, > Documentation/process/email-clients.rst in order to fix this. > Oh right, Thunderbird wrapped the first line of the patch file -.- Disabled wrapping, another attempt: Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > and can not be applied. Please read the file, > > Documentation/process/email-clients.rst in order to fix this. > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > Disabled wrapping, another attempt: > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- Sorry, still needs a valid changelog and subject line. read all the errors that my patch-bot sent you. thanks, greg k-h
On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > and can not be applied. Please read the file, > > Documentation/process/email-clients.rst in order to fix this. > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > Disabled wrapping, another attempt: > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > Hi, You have to use git-send-email(1) for the purpose of sending patches instead. Please see Documentation/process/email-clients.rst in the kernel sources for more information. And don't forget to address reviews from Greg's bot. Thanks.
On Fri, Oct 27, 2023 at 07:56:53PM +0700, Bagas Sanjaya wrote: > On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > > and can not be applied. Please read the file, > > > Documentation/process/email-clients.rst in order to fix this. > > > > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > > > Disabled wrapping, another attempt: > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > > --- > > > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > > index 0547daf..7b3d5f0 100644 > > --- a/drivers/usb/storage/unusual_cypress.h > > +++ b/drivers/usb/storage/unusual_cypress.h > > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > > "Cypress ISD-300LP", > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > > "Super Top", > > "USB 2.0 SATA BRIDGE", > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > > > Hi, > > You have to use git-send-email(1) for the purpose of sending patches > instead. Please see Documentation/process/email-clients.rst in the kernel > sources for more information. And don't forget to address reviews from > Greg's bot. You don't have to use git send-email, that's not required at all, it's just there to make things easier for some people. thanks, greg k-h
On 27/10/2023 20:05, Greg KH wrote: > On Fri, Oct 27, 2023 at 07:56:53PM +0700, Bagas Sanjaya wrote: >> On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: >>>> - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) >>>> and can not be applied. Please read the file, >>>> Documentation/process/email-clients.rst in order to fix this. >>>> >>> >>> Oh right, Thunderbird wrapped the first line of the patch file -.- >>> >>> Disabled wrapping, another attempt: >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Liha Sikanen <lihasika@gmail.com> >>> --- >>> >>> diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h >>> index 0547daf..7b3d5f0 100644 >>> --- a/drivers/usb/storage/unusual_cypress.h >>> +++ b/drivers/usb/storage/unusual_cypress.h >>> @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, >>> "Cypress ISD-300LP", >>> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >>> >>> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, >>> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, >>> "Super Top", >>> "USB 2.0 SATA BRIDGE", >>> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >>> >>> >>> >> >> Hi, >> >> You have to use git-send-email(1) for the purpose of sending patches >> instead. Please see Documentation/process/email-clients.rst in the kernel >> sources for more information. And don't forget to address reviews from >> Greg's bot. > > You don't have to use git send-email, that's not required at all, it's > just there to make things easier for some people. > Thanks for the tip. IMO, this is the submitter's first patch submission where he had to set up appropriate tooling.
diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),