From patchwork Fri May 4 18:09:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 10381277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AC0B76038F for ; Fri, 4 May 2018 18:45:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9BA5929598 for ; Fri, 4 May 2018 18:45:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8CFC429599; Fri, 4 May 2018 18:45:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F419D2957F for ; Fri, 4 May 2018 18:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751729AbeEDSKD (ORCPT ); Fri, 4 May 2018 14:10:03 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:37339 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbeEDSKC (ORCPT ); Fri, 4 May 2018 14:10:02 -0400 Received: from localhost.localdomain ([37.4.249.136]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MFVyq-1f99Ms0p9w-00EPrZ; Fri, 04 May 2018 20:09:38 +0200 From: Stefan Wahren To: Minas Harutyunyan , Grigor Tovmasyan Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Stefan Wahren , Mian Yousaf Kaukab Subject: [PATCH] usb: dwc2: debugfs: Don't touch RX FIFO during register dump Date: Fri, 4 May 2018 20:09:05 +0200 Message-Id: <1525457345-3901-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K1:daMEEUGtsRhzK4HsIToAt8/Z2FC3OzAVLlPK0R8Rd3xzS+1gowD dHvB8zmwKO4Mr2OF8rBDxfWdO+RgFjPUzVH19m2uvOoa+frtTwIdt7GeBx24iH8lsB/Hcai 0B8jlz82KESnn0oe7FG9MGE9lmHppr8O/Szs2Scl3Oq0/4lR5hlxgVX5Cbazcwes9sdhuBM TMcG9MMYfDwyqnf4xRZ+A== X-UI-Out-Filterresults: notjunk:1; V01:K0:qR+CyUyTDrw=:Swbg8dok5Oso/2RJhsQdo/ O1y/J9A92HSHcEfDmuo+bJ0Oo05PpMjFysQLpW3JCpRFFKoDRr8ZfPvFE0wLReWmgYMs/T7OB m0PB0hg+aPPqdp8VfngpfrK768zDiihXGT26pBvQWXaD+6tDidyFrZ3i92kxsi7FLjpWw7jDA aIv5UkiXQmXYt9wt6t1XCNiGfqufYfBE2NncNGFNTdSyAdPUV6oOykDpSZPet4Qz7ibTg+kd1 WZbE09efblMLIeudZGtm3KhRxBt+0sOnzL3NFToVMc8bh0LXhLHOh2639XU+lLkS5ZHiX6UCT DfhH6tF44NJ6uswdW9HD7rVB8KqlnmOIxQuQ+CpRiJPQR7uNw6HGkItppngVhbiDJ4Q8COg1b zHQqSwmBNfiXl5WRv1PXhCe1lBUw/hTQlhW11tNvO2fqZo0wPyTSa6aC1kq65TbR+E/UZ703T c0EEcSBa5jjP+ISIUNRoQ0AZk6OqcMAim26xVDjBY0X0W9n3JveXiuXeSc4I9/5ImGw80JqWf 1m8LNe32wvzXZpZdF081Xx5nGSkrN9P888reEOI2Oce5FGDtMs98mNxuZZs1M2KMYGqelug8k Zq4GYaMY37RZuT6scKaUfGGME/qQyKht58QjCYN8eolIv6IRkYugAFypjoplm+K7vkRFrJ/Bd Qxf2oYT2iC2dbx0Tz9n3sP99A8xtK+Xe6QuWbkc09wX2z3u8/rNx90+2eFHxOb7W/VGQ= Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dumping the registers via debugfs makes USB on Raspberry Pi completely unusable. The read of register GRXSTSP ("Receive Status Read and Pop Register") is responsible for this behaviour, because it pops the RX FIFO. So avoid this by omitting the relevant register. CC: Mian Yousaf Kaukab Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump") Signed-off-by: Stefan Wahren Acked-by: Minas Harutyunyan --- drivers/usb/dwc2/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 58c691f..d4c0589 100644 --- a/drivers/usb/dwc2/debugfs.c +++ b/drivers/usb/dwc2/debugfs.c @@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = { dump_register(GINTSTS), dump_register(GINTMSK), dump_register(GRXSTSR), - dump_register(GRXSTSP), + /* Omit GRXSTSP */ dump_register(GRXFSIZ), dump_register(GNPTXFSIZ), dump_register(GNPTXSTS),