From patchwork Thu Jun 14 09:23:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 10463709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 249CF603EE for ; Thu, 14 Jun 2018 09:24:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1590A28A91 for ; Thu, 14 Jun 2018 09:24:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A35B28A93; Thu, 14 Jun 2018 09:24:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A666128A91 for ; Thu, 14 Jun 2018 09:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777AbeFNJYM (ORCPT ); Thu, 14 Jun 2018 05:24:12 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:39979 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636AbeFNJYJ (ORCPT ); Thu, 14 Jun 2018 05:24:09 -0400 Received: by mail-pf0-f195.google.com with SMTP id z24-v6so2930828pfe.7 for ; Thu, 14 Jun 2018 02:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dqjm41uQFGyIBuhVvjEvCUQGdYLtHKXKmcpiOTiFgMk=; b=Cl1ufpYGpqsfrMnWqSD21rOPJjyxx7EfA9DAXIBRdNWD2Sw/91/dMM/0VkzrpcjZVv j6isQqvcQAKQjwXd2/sLaX6KMGLG/GmEkNGGRiCtkqpmnEX0ReNhyuRAW3jqBA4sghSp Tlwl/iQzcIPSAIaqZBWCeX8c86YsoWY4S/ZoZ8beB2ItF5Xboqes+pMLZCYLoUw/qqKJ FgKBuwOi7JiY7CWmu82l4qyeQapc+fseo49rHWSJm84Qgjo0M7gQ5TN6cMW6sK0MW5jg Fqik2GsbD3uyLNRXGOgJVvwfotHURsUnymXDNx+WFz+tL8gkKHuh6qJC/nuQjJf2xp0E wdzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dqjm41uQFGyIBuhVvjEvCUQGdYLtHKXKmcpiOTiFgMk=; b=QD26SazGz5jEfuNp2ZCOhndT+DkC78d3o0Lq3NNmGYYlmGK4mLQ2MJJdAXm1gDvu4j +zQbx6WGh46E5xH8+wnQSnJfyIunSGHtexJAF2Nw3NBSTrBLwL/qzjIeczgqb+VfXDpz suZIq2imY+7yantAZ15F48Rp4p+W1/BX6ZcfNPPsvyQ3c7wchzFEbLU9YT+0h1UHyf/F IWiGl4VTTks0XjSt+urvXop+nuukdIBMw2TteKEyKvjSu/6gjcq4NbqLh1OO83uQ/3bD Ap5Ve030SQOzqPGlNwIT2htQ+BUWnLbAMSLOOejJGw7nSuEIQdIMTI6EbWcpB8QeTUMI o5Kg== X-Gm-Message-State: APt69E0L12prRkvC/wJQKjH8DeeRyC2V0+9NgY8ZMmn5Kc4HryyzJzGq FdsQLcAuvEA1EeaPfHrxNmQ= X-Google-Smtp-Source: ADUXVKJUPNaYT4NC/6x5Hfhb8Wf4a5tCkBmioVkJBrrZiEKhCIU2Ys7HHhn+FAN4SqW50mFR+7lpcg== X-Received: by 2002:a63:7741:: with SMTP id s62-v6mr1628894pgc.103.1528968249178; Thu, 14 Jun 2018 02:24:09 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id m10-v6sm5512040pgq.89.2018.06.14.02.24.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jun 2018 02:24:08 -0700 (PDT) From: Jaejoong Kim To: Felipe Balbi , Greg Kroah-Hartman , Krzysztof Opasiak , Alan Stern Cc: linux-usb@vger.kernel.org Subject: [PATCH 1/3] usb: gadget: storage: Fix reference count if fsg_alloc_inst() failed Date: Thu, 14 Jun 2018 18:23:57 +0900 Message-Id: <1528968239-2447-2-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528968239-2447-1-git-send-email-climbbb.kim@gmail.com> References: <1528968239-2447-1-git-send-email-climbbb.kim@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The reference count is initialized in fsg_alloc_inst(). So if fsg_alloc_inst() fails, we need to add kref_put() to free an allocated memory. Signed-off-by: Jaejoong Kim --- drivers/usb/gadget/function/f_mass_storage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c index acecd13..83eeafe 100644 --- a/drivers/usb/gadget/function/f_mass_storage.c +++ b/drivers/usb/gadget/function/f_mass_storage.c @@ -3392,6 +3392,7 @@ static struct usb_function_instance *fsg_alloc_inst(void) release_buffers: fsg_common_free_buffers(opts->common); release_opts: + fsg_common_put(opts->common); kfree(opts); return ERR_PTR(rc); }