| Message ID | 1528968239-2447-3-git-send-email-climbbb.kim@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 14 Jun 2018, Jaejoong Kim wrote: > fsg_common_set_num_buffers() may fail due to ENOMEM. So add > error handling for fail case. > > Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> > --- > drivers/usb/gadget/function/f_mass_storage.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c > index 83eeafe..b6e2930 100644 > --- a/drivers/usb/gadget/function/f_mass_storage.c > +++ b/drivers/usb/gadget/function/f_mass_storage.c > @@ -3308,7 +3308,9 @@ static ssize_t fsg_opts_num_buffers_store(struct config_item *item, > if (ret) > goto end; > > - fsg_common_set_num_buffers(opts->common, num); > + ret = fsg_common_set_num_buffers(opts->common, num); > + if (ret) > + goto end; > ret = len; > > end: Acked-by: Alan Stern <stern@rowland.harvard.edu> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Michal Nazarewicz <mina86@mina86.com> (Does Gmail still hates LKML? Guess we’ll see…) 2018-06-14 15:50 GMT+01:00 Alan Stern <stern@rowland.harvard.edu>: > On Thu, 14 Jun 2018, Jaejoong Kim wrote: > >> fsg_common_set_num_buffers() may fail due to ENOMEM. So add >> error handling for fail case. >> >> Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> >> --- >> drivers/usb/gadget/function/f_mass_storage.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c >> index 83eeafe..b6e2930 100644 >> --- a/drivers/usb/gadget/function/f_mass_storage.c >> +++ b/drivers/usb/gadget/function/f_mass_storage.c >> @@ -3308,7 +3308,9 @@ static ssize_t fsg_opts_num_buffers_store(struct config_item *item, >> if (ret) >> goto end; >> >> - fsg_common_set_num_buffers(opts->common, num); >> + ret = fsg_common_set_num_buffers(opts->common, num); >> + if (ret) >> + goto end; >> ret = len; >> >> end: > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c index 83eeafe..b6e2930 100644 --- a/drivers/usb/gadget/function/f_mass_storage.c +++ b/drivers/usb/gadget/function/f_mass_storage.c @@ -3308,7 +3308,9 @@ static ssize_t fsg_opts_num_buffers_store(struct config_item *item, if (ret) goto end; - fsg_common_set_num_buffers(opts->common, num); + ret = fsg_common_set_num_buffers(opts->common, num); + if (ret) + goto end; ret = len; end:
fsg_common_set_num_buffers() may fail due to ENOMEM. So add error handling for fail case. Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> --- drivers/usb/gadget/function/f_mass_storage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)