From patchwork Mon Jun 25 08:08:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Li X-Patchwork-Id: 10485253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4A576031B for ; Mon, 25 Jun 2018 08:26:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DBCD28845 for ; Mon, 25 Jun 2018 08:26:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 822C0288EF; Mon, 25 Jun 2018 08:26:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C73828845 for ; Mon, 25 Jun 2018 08:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbeFYI0a (ORCPT ); Mon, 25 Jun 2018 04:26:30 -0400 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:14646 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753154AbeFYI02 (ORCPT ); Mon, 25 Jun 2018 04:26:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XUXnStOy8irvi0MXLqVhHtSJUFKTOR9r4vlScFratYg=; b=OoInWa+TaMgbthj7igO62n4sjxtNPhDOX4+oT6IXdxNlQJjNlVxKvkB3aClhPKVDM25ycDvRopycOY5b/xzBn8tsAfIJOjg+QIiRM8Y9okHhWRpNNun8INd+XcdKLAoBgokq+QahduFPkjL1yuODfsesf0/u+wOllrg/blvXMPA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jun.li@nxp.com; Received: from b47624-OptiPlex-7040.ap.freescale.net (92.121.68.129) by VI1PR0402MB3920.eurprd04.prod.outlook.com (2603:10a6:803:23::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Mon, 25 Jun 2018 08:26:20 +0000 From: Li Jun To: robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, jun.li@nxp.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH v7 08/14] staging: typec: tcpci: use IS_ERR() instead of PTR_ERR_OR_ZERO() Date: Mon, 25 Jun 2018 16:08:40 +0800 Message-Id: <1529914126-22550-9-git-send-email-jun.li@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529914126-22550-1-git-send-email-jun.li@nxp.com> References: <1529914126-22550-1-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 X-Originating-IP: [92.121.68.129] X-ClientProxiedBy: HK0PR04CA0004.apcprd04.prod.outlook.com (2603:1096:203:36::16) To VI1PR0402MB3920.eurprd04.prod.outlook.com (2603:10a6:803:23::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86550156-e388-4854-70fb-08d5da75571a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB3920; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB3920; 3:peJnqarzplf+UZ6vqJ10U+y/XTPmpPPZYyy4n+XHYrUFzHnKJTBpmUcJJnqBbhpBAB3N6AP1J8AzBFN77dKCrok6QAjb8wHJJYWOvvjEzdx3OWiQ771BavWk/U4BfzqUEM1sgNAj/9q9pojkHRtv4KodpncSjJv0bYGK++OHBpUL3SZiYs7rRENOis3MfRpn2PwWrqlFBr7WpItYIqbmwGqt0HILJYKR95ILPxWSxfIfz2/4iV35NZHRG3wxe6R2; 25:7BkiUNlaT05oavteM/wZDkwpuuSkahbP2GlKa1lHGSvlm8c9E7CaFjwsD4L29iL6jz8eSE4BofnXNrbKjOU0IOXOo87F7VYWThp4ItbuzfOPNGZvVurg5kXTz9KZYEyxXfW6Y+QJ6QZdfmQpIDpMWLyfk7zStcTcK15YMdSBAB/02BojLHV5VMfyNfpDqu0EH6Eeae2OcOh4hxdUxuUDCGzTYE8hvHfh1CQHGAptJGT2FDYM4jXz+pHJoALlBnX8PLToN3hYhnEq2YscejkhE6iYzB6cDRLani2PZV3eTPNdvGU65OTCLZs/+5OXNgBTrR5bf4xqaGtUKW4m9djNiw==; 31:nE96URBGvNFX0P0sCpcLS7DAo6Eoqc02y4n0FjBswVzVSuZbPbok0c+XXw6SvqRu9ugzgVTfE8hO4hKfYR90EBJCoOVbY/CHLD/FuNsCmsT5DrRoXnBtakZ2LHf5QXoIbs9H7rJdyMyjqFO/cDsbHeN1mD5CkM7weqGEnsclT2kvmRhxcN0BJzqbIDn7a3dGC8nyqsTaInqybytp38EhOOBsYAfGe4Xbc6r263zESTU= X-MS-TrafficTypeDiagnostic: VI1PR0402MB3920: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB3920; 20:gAdjnSrbzxYKy6cn2Il0876KaWLfVtEFVaWAavz8h+G7f//peGbqcXuc9iQkdhZjn3t3TztvTp6OOX+emEvUbVwC3Wni38SKqqy/Nmvj+F3mINxPLuju6u073UeXhuyvxaT81N0w7E2/jEwtrQd0gRDwZRXl1fHY5xBxnqSYQo68lbuIX12W8kOvYCb2Z66X8HM+rg/xklftsSPK3kCFZscPgbE11Ppv2qBOqbiq+Yx6DPKkhhcGzNa5Zw3+1uSRc/LJcDc7wLlkhqQyYSxgJ03PG1+y6CzEuxvbdRLcxkJEvx99nfsmnkvGQ3SvsGr1ddqkhTwjE1WloR7OndXpQFH7X5J9KvstbmfeGiTlhgWAUFSNNO2ApL+J3Q5gKMsUu89dYPLHiKWgXkFccxFKQzMWj112Eh3kuOQfu7l0zYlAZBEZcjaD2fUl4l9l5GqlVQXakGF4El4lIm9uG/NjQvGwtGxad53fwXAu7IBG9LFEd3nXG031qWax44ua4swS; 4:EGKI4jPgAI6hXugAwKdbGmvfuFkNf4ovU6X25lX4E/QFrgPn3KCaG99ABIt3Klq5TfIstkRHClpvcRWfloqM5AcD2geoL6i9WyUcndm2h1A2SmYa4mhTWJeWaHx+G6Zl/5Wg73Zlb4RAHxOUXmykH5pdOjuXFYN9k0IgznVs/VQI6RVkX6184xExqK6sIIonVyNqGeDkohK3gJxLMjqtWD1utBaEsv26EZqrFyCdebAslfv1FWTnd/Ngt2dQmUFZiAN/oh3IJiUSWu7cuzbc3ExTO+p7reHDWnpdUwFzbO38jqMMHyrmcbeV8YG1BdDIdFP1f1BG0BoHt8cOJYJJtbsoBPlb6UTJF9YI9/MJMXg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:VI1PR0402MB3920; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB3920; X-Forefront-PRVS: 0714841678 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(53936002)(25786009)(47776003)(316002)(2906002)(16586007)(6486002)(36756003)(4326008)(386003)(6506007)(186003)(6512007)(478600001)(26005)(16526019)(97736004)(8936002)(86362001)(50226002)(52116002)(476003)(81166006)(81156014)(486006)(76176011)(305945005)(51416003)(8676002)(2616005)(6666003)(105586002)(68736007)(446003)(11346002)(66066001)(5660300001)(7736002)(50466002)(3846002)(106356001)(48376002)(6116002)(956004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3920; H:b47624-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0402MB3920; 23:uT0MFEH46QEZqcX7FOV2FJcLO18vgdesXXfNoTH?= =?us-ascii?Q?QCaMQCxIZtkvkC3SD8x4I6IM7KRkcpwaYqAe90V1nm2/q08ryr2spjzAejSA?= =?us-ascii?Q?Ld53n007XsUN6CRcP22qfRgpyS0E8zLINC2sxhh4AcNErA7wmkMvJ6X/4DEV?= =?us-ascii?Q?RTZ9qPrh0FQQVsh6LIlg9NanaUwFbH0G8Adw9f59Y6L8t4e7QboYiO03k4Qr?= =?us-ascii?Q?I0JoD7wdKHlqmDx21EDthAE5OKMt8GgOaTluYNQgXMuZxjoFUMthiSgmZ1p4?= =?us-ascii?Q?j9sjj/mZSJW584CbkricJUYLLA3p9u5nME2zczTdjweSXz+HJ/wZAE+Gkpjb?= =?us-ascii?Q?8jIrUitDVgTCpUjpZwvmrFsskG4nc3eQOtmmp6eZkCWWq/XqFvqkDd/TwXyb?= =?us-ascii?Q?d2wL/d2p3pdSgyl+4Y24MKt/HzWJxM4/OuTVHu9T3MlfQnUdB+fmm69IRUYD?= =?us-ascii?Q?DJSNB0hic/nZk/vtswYHARgXLaS3/1vDfvgVvXlYRE6pPrV8LbJQjocltnvy?= =?us-ascii?Q?R4X8cHdr9OB2Rr+V3i9nj59QQrsr9f8V/g17cVUw5FA1RkuOgbDYREwrsIIk?= =?us-ascii?Q?fNCsscaC8Pt11C+Y54wNKntI3zxZC2/IAC56UvRUNp4sQXnXvc4xE5qBKbIy?= =?us-ascii?Q?7Um+Dy4aES1x/tdfMLFTL3R9B6jZXYEW2cPJKxO2RDnNdovGKpwuHbVFh+d9?= =?us-ascii?Q?VNmpIktMyyKcn99pSzdafqB6PHF3qTkNnKoSsnhJp8zZuNJuIOreu4NZDzTp?= =?us-ascii?Q?gvY1jY6g5o6ALP79ktGQ0lWK7DxLx/fvhxJL4DsRZ2dYAUqZpHFFAes+81SQ?= =?us-ascii?Q?eWjGnl3Ams4D9c7Z5b/+B/U96DH5UL3d/AAfgz+9W1N1TYCizRK1vaOAwV/5?= =?us-ascii?Q?qNviN1CGUb0m/CXQLW7Q8Lt42yTKEqMldEpfvZbogbqwND4nWV7sX+szd7E+?= =?us-ascii?Q?vYeipCuBc9D+3YOlH+S3j+y07f83K8bQ4uyrr/645WEjQoOBpUjlyoEWziUB?= =?us-ascii?Q?dAEwTO1JTRX0vyafaHjucD3Kfq3tud/louzohhJ7lQDEt/0hYRvY83gpK7Af?= =?us-ascii?Q?CEzmhiwGdEuw2WS9P9HfY5a0B0D/YP2zgp5Ezjj31ie8RT4yZKFSk3Xh95Mm?= =?us-ascii?Q?DQQ4x/nugjYNX9oC3/9AJ2ewQjhvJess6I3op2hANedaNgUKPg/W+nQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Antispam-Message-Info: PQbUVmcpXVVSNNhmpa/kjELxCTYWleJsRdh/gUYH4V7Ro5tA3N54wsZcTPH0grl4g+wp15jcAWNX2Kj3nzp3YxEUZ/IMKstKAJMNHO0OMjdL1WjSQlWYFYSmWLKkvUKrHxyIT6oJgTdXeCtOfFcjSZz1aWUqTPC5REuGb6jRush+ZOs5PLQ37J7uLFWjbnNolhtIRmMLKGz7EOFAcKMkiC6HW06aOc8arQWtnmTgcQ0do0krQLxgP7w8lSHOrFtsutQfglgTARRyb4aIUZmkStPfaeD1dPA81AGNxQT3Dh8HEn/fUh75zUoYFwn10Bq1fh/oXdyZgVLsLzl0Wx0fcDWnC+dTYtcmt3ykLcy1N0M= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB3920; 6:2H8xftvYiVI1R1ik3NMjmDryQNymkdGRaV8HU68RfMU7pHfVspjO23qNvqhLeassktWBBqtUYLgIqspIUEVkqNyo4a2KRv8wjH7O52D3xgngwdUneYglUDAkrstuqzj+chxg6w02AI39nSSyhKnzNISbJhKIXOcrYuRLyBb+tTfFecjahlEHSbCLStdSaBf68XaDrvBzcaklBZqKhJr5i94dBCXwpJpKzU248RMQ9+KtbFsqHuYxfXyMg0TnfQNVJs0mFp+/whe7Ulvw+DLJcVIoP5IN3SELz0qC2qvTlykEOSswXOk+Tu6VLoVBU+njZE/MauL8ifvEtRwVQXOW5XVYsNcVTm1dIT4Od8+6fmWP0aHYQ76RBUroazjJViFbKvpHCgQEDrq4DtrlDiHS7q5wdu9/Lmx6emuU1me6BB2rXL1QYbmYmr9qXhGXD2yukA9JEnhI1Hjq6Pw0U4gL/w==; 5:I3tFnYg0gUPkiMCND0Vjfd9/n8g4OKWvh2AfH8TYyewP9PHZy0YIYggYeJAfIwmTr1BpclwYP+zKeoINyEbpbKhR0NxxhcVygOAzLKGzT5APtp5fipaHDF8rcX6ICOijWJ2WFQxu08DDGsUMPClMTvEGOYjg6gN/rQ+L5tkuJG8=; 24:sm0QHB95LE8fg+ZiQL9PQKrPrGr9tBjvemuYTqEqn+I6a609kBn92z9Igo1TcZq5sZpi/1fMUEZvhv71tfNG/h5itt2TT8voF7XORJgf0jM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB3920; 7:U8BIX8yZcLNvN/iRzocSbEulSNfzNZNCdxs62ptG9PHtE2fdQbeKprnOU3fw6t2k3Hpn+OKPWcWr9fKLD78NUPXqYw+XfW1OqIGYjI9kLwXgGyUNQTb7C8dtRZv3HRzCFergXyszGJJAkVnPtto3vdsLXHfCLMNsq9qcrxPAnetJqrDUYzSDPBqQUgsOUT5VYuN+8AGRi02lZOgLSvbi0uSoZgA+mLAc+IBm9QV6ekw1fS24pvOusroNOo3r296U X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2018 08:26:20.4547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86550156-e388-4854-70fb-08d5da75571a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3920 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As tcpm_register_port() and tcpci_register_port() never return NULL and NULL is not a success in this case, use IS_ERR() to check the return value of both. Reviewed-by: Heikki Krogerus Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c index 076498a..b63f147 100644 --- a/drivers/staging/typec/tcpci.c +++ b/drivers/staging/typec/tcpci.c @@ -509,7 +509,7 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) return ERR_PTR(err); tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc); - if (PTR_ERR_OR_ZERO(tcpci->port)) + if (IS_ERR(tcpci->port)) return ERR_CAST(tcpci->port); return tcpci; @@ -551,7 +551,7 @@ static int tcpci_probe(struct i2c_client *client, return err; chip->tcpci = tcpci_register_port(&client->dev, &chip->data); - if (PTR_ERR_OR_ZERO(chip->tcpci)) + if (IS_ERR(chip->tcpci)) return PTR_ERR(chip->tcpci); i2c_set_clientdata(client, chip);