From patchwork Tue Jun 26 23:45:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Li X-Patchwork-Id: 10490339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5EC4A60386 for ; Wed, 27 Jun 2018 00:03:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53D251FF13 for ; Wed, 27 Jun 2018 00:03:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4847426E54; Wed, 27 Jun 2018 00:03:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D588A1FF13 for ; Wed, 27 Jun 2018 00:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934301AbeF0ADJ (ORCPT ); Tue, 26 Jun 2018 20:03:09 -0400 Received: from mail-he1eur01on0086.outbound.protection.outlook.com ([104.47.0.86]:50463 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932104AbeF0ADI (ORCPT ); Tue, 26 Jun 2018 20:03:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XUXnStOy8irvi0MXLqVhHtSJUFKTOR9r4vlScFratYg=; b=INgOOKxLXknkzTSn1cO4ep60XXnYGQ04YybayZx3PbJTU1O3yKNaJsrbW1Di7pvL3AaE6f7KvjJzw635gC4ijKwXRcpCrzHu64H/XqCo+xxyCNxSm1y0AZzHs3TO+T1a34x7jvzLtlRiNBXh/HHVpaBRyKVUuA63nWbCdIWlpNA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jun.li@nxp.com; Received: from b47624-OptiPlex-7040.ap.freescale.net (92.121.68.129) by AM0PR0402MB3908.eurprd04.prod.outlook.com (2603:10a6:208:f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.22; Wed, 27 Jun 2018 00:03:01 +0000 From: Li Jun To: robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, jun.li@nxp.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH v8 08/14] staging: typec: tcpci: use IS_ERR() instead of PTR_ERR_OR_ZERO() Date: Wed, 27 Jun 2018 07:45:26 +0800 Message-Id: <1530056732-9640-9-git-send-email-jun.li@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530056732-9640-1-git-send-email-jun.li@nxp.com> References: <1530056732-9640-1-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 X-Originating-IP: [92.121.68.129] X-ClientProxiedBy: HK0P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::23) To AM0PR0402MB3908.eurprd04.prod.outlook.com (2603:10a6:208:f::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 418eae19-ab06-4d02-5b3e-08d5dbc15bbd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM0PR0402MB3908; X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 3:gtjedy+nNXeEpqefHy/xBdg021LolzHQ3IjuwFczPJx2eoZAtpVdeyJrIl3w9WhTW8jmy/1i8LZy6n5hNShYitO5OyRrx6ouZ9U2QtdrmMYw4VdaSoLIlNHCunIdpEpsQaog598flL5uGeMM/4OBjEUTmv8gRpX1PC+AuUScgI0J0Ru66fxRY2dAf722fjC801lnvEHT2xH0X/wbdtsxTgkujSFik6zj9upNWGg88L1uJSImOX8Z2N+u3CvvhY7C; 25:DVvtHK6LMoq6Yo+p84dUE5YvG+EQNlUlcm2RIOzk8UjJ2lXV+LFXeRrfGFOTyW13KTeJ5qC41imVYNkO9FaJlga4OclN7eXTwV7tkWL9M1Gez+WWu3Znd+foWmZXunjvZKVRyo1okZUsbGcwF5m0NytZ5WRgo0KWr99VzZmB9ejIcIVFhZSIEWuY4CXFS76r9x/Hfa9jq1YgsdFnIIJr8xVqiJzd3CR3EQQtKa9T3nQq9wz4XLNc+ZQuAPaPomZKENttN7eG03DPceOWwey5Snj4a8v4GsMVHZ6CSGhZg7O+qC/YR9tWpAwtZLdwR3feqI5bdp1tx1pEaM/1fxIiWQ==; 31:IbDHu7v8yBRi/YZE3EhlZIFomQIkDWKmOVxU130ln+AtXQIKXUq4ZcrmezCBZRjtI4bL611X1Fvpf7tETH9jxa/PxfxF/mJENdH3syyYaJG5JM9/WbHuwJzzvxTDTOLBdYs0GaOUyPzF/A2X+7x/XzOBf1O81/dDx07qBulFzX98iYZ4jhPPLdgEJF2pkamHLvoD888VNtFRo3GvUUSQg+/EIIH2tK9erGuUWCm9Q7A= X-MS-TrafficTypeDiagnostic: AM0PR0402MB3908: X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 20:/yhHW4S1GXtW8EjTqU6S0+0Oo/CBfveSjoAlWk36s0Eq9IHeakL01Aim+pe08NoLOyJqMcaBFXuAavDVBvkXo04pRaZId1fvfKCC5s18hlr4JBcvogw4FC4bXqsmYcUpPqa4nLT+6s/4rZz/SY25WORvVtrkbDN9HKImlM6VTLmmb/vLpMjhwgz7ADlktXc2qwUOg+Sj0Mrxwwor8wDzq3L8metP/npNip+TBEEf3nsXAdk3lVn0Mtrs3UwdHaPmO+Eyf20RMhyIniV6SsZuJU8VpNFM3L6ASSiVTORLuBeyb3dNuBTWxvAU20vr6LCB+FMi1dwtrweXVo+8eSG5Bm/6DGxMEJxn2Ok054HTpQ/cJUNLNXx8jnOFv744eCvKShpuK8mNXEC1GKEFhObTdcZG1mXB6WmwnZOlvKpemnadMq9kCL2DGQvc9W+wotRLMOfZSulRL8H5xaCzHzHxg21PX+MdCAt9wU5IWzoQ2nmJ9A5LKIx175sbuulgic1a; 4:0fg/S+6n/+bP62eQY1ahE8aX9e9S354sno3ULoLjtSlbi44vyO0SlyKNo6kmtebwrOloPVf3ik/Gqrqe623jjIBfDDCRx+xBQUNJ86646M05l0VXs/ndLXFa30BPN3HjV5awpv4JTyTbawyzB4V8lmPZWI+hnp6xrhRweyTimci32NByWt+TA9vwPl3myUkzIPjB1jtrKGlEUZfvH8cxFRw+i9ksH0l5O6xdxJJxCKp00biUJamPm4d75t/jS40sXuaAy2+Yigz6Ty+LD9IyTdUZWQMyRRXdu/FmbAded6j0Mu3xHZL5edKGVStVI17YMJDvINzNjSnhUPqUnrKV7xW04HUVwd7ViuGuBc7YnvI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM0PR0402MB3908; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0402MB3908; X-Forefront-PRVS: 0716E70AB6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(366004)(39860400002)(396003)(189003)(199004)(2906002)(7736002)(26005)(6486002)(305945005)(486006)(48376002)(478600001)(86362001)(25786009)(4326008)(16526019)(186003)(36756003)(50466002)(16586007)(68736007)(6512007)(47776003)(51416003)(52116002)(53936002)(3846002)(386003)(6506007)(6116002)(76176011)(316002)(97736004)(50226002)(476003)(2616005)(956004)(6666003)(11346002)(446003)(106356001)(8936002)(81156014)(66066001)(5660300001)(81166006)(8676002)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0402MB3908; H:b47624-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR0402MB3908; 23:0PiPxaPa8OtLs3zkPrD4cU7V0NJ3dCSBCH7hmbB?= =?us-ascii?Q?3uWWnwEQ2nh0O+AX7/ZmE3I8PFzlhUtlZ60LS884idhxqZssF2YRwb55NVmA?= =?us-ascii?Q?GuZhyKDMUyzH6SWbpUHa5Q4PwW7CkMbPzMFEzef8+wrZpq7DJ9jZZKksYhya?= =?us-ascii?Q?MEAOhk8iFnSfBWItkGxz3C5qTjFD4AqtmCXAw+k8fW4Oa6eDg++C/V+LtvJW?= =?us-ascii?Q?SUBvY9OnT405Vch6bfxs+KF6oitVKwTndc6GmWs0SNrnii492XCjZSsxBGvh?= =?us-ascii?Q?G39v/LXU1btN4RFISpah0fQ0P9BxKNQ1fCc3FQpMNyaQvahKcCw0X61h+6Z/?= =?us-ascii?Q?w1CBkyBYljPAN9mSKreQw+B4WhUqBa0clgme9sHCTzhKP6ZimyDAO1P3V6jd?= =?us-ascii?Q?Y56h0EemzPW/nzWFQIk+xc9K9Kz8bngYYUQaw4Ph2OaMKF7AGcL6TttzNAzv?= =?us-ascii?Q?a6qFJeUhRIg1FH27bczNYU1p6AMshoyjQvnzbOxTAL2SATR4tRgB1ptHi2fU?= =?us-ascii?Q?rxlddpC20cPYlw/CkPM0mD0felIyQNsPiaRus0ZT45fXqcViJStNn6R6lohO?= =?us-ascii?Q?oTYE/vZZ/LobtVtxC85ev+nP2Iln7jShY2n6PWiQ9e6LwmxabzpcV7sgnt4Y?= =?us-ascii?Q?cUp5mKzVBDZSJMqRgHV5KzPmrUbshU5lqrgq99XHAlN0054zJ4d9sJ9lVSm2?= =?us-ascii?Q?Eiyv7OWcp3ho6q0xCSfzVMy2WMYAYfqRi60r+6g/2DtmDThM3b/D7ZxxrZe7?= =?us-ascii?Q?yYUD1xO6ckuJcAe5ty3lKU9EZ9NwQA2BOBYJyAl6oWKV01M3+dZakb+E59WC?= =?us-ascii?Q?UIc/vj7/YDOP1+XKJKXjln2uEMDhcz96Bzn4jKqwz131CAFZpVPR1bzL5aOG?= =?us-ascii?Q?XABGgk/ZRzts06ReqyqhXc4xZ7gwE5D0UQQbMV4dcEDChWIJxF7r2Vw6mdA/?= =?us-ascii?Q?nsc6eWiZSwV9XRt8qiuhWP0oJsbgHTN8lnovddDT+zGiq5T62imF7Q2pwNhC?= =?us-ascii?Q?AVCMZ8MDWd/WGmHBWb55GcGf/BAEwY5Wc4rGkE6bwe7Vh8qR2dktOCFDvkr+?= =?us-ascii?Q?xIuDEPOaTOwxOkBqBCFMC06vE4LpMs60/OxoSMKSrK4caoq0G0vaqkcToXgf?= =?us-ascii?Q?uPsIPWPpDLSldKSFm0B0Ku350CvFEWeJz?= X-Microsoft-Antispam-Message-Info: fFZIo88/HL83Z8nrmQYd8Qbomh9Y2cQorzlfj3/iWLvgGP7IcO0/uY3qXQFrLvTTwaPFNqT4/Vx9a1XjNjovXo18HIo0tTqhUy8aOokBaGU2eeMb2fRW8fjbvZx2wzk8gUWkcZq69h7jSsp+pGnShvCI8pBCmCdcMmXW1nF945vG/wzOhtin4x+rGjHwel8pIGFZJ4EtSZqQQDA1gNn0xK2m1TjbzluS64Jd2SS6FBswAyVtRJYtm/xykLtq8YxfPjF4VHNnwk2TxAbxySWZMwGT+XZQ5KdFMG6EUeT1BGFWdQMapG4tI9GThgjFV7eL7nvOidPnuFLh8Eg2sJBGyh5lb1WvDHtw9FPlUmCqvgY= X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 6:dZ6R2cPVl6BhRS/ZYkvL3McpgPyJhN/cVSSx6n5w4Ig5pOftuU9HXRma0jiPk27dwDY7dsCj0ZgNeaOJNKkCriT0X2g9p2BAYGlTne3aFmGAs2M8poWPTUZlm2W17W4EsTHAIfeGfyMKKnr4FOkLdcwLzRpyyzYaO0XNFh6uYdS78EDdqQhrr9poBNM2JqXz4iprEX4ZQxhF1Z4TWD/MYbysnvTeBmhn0SfVnkqaT4I68eEJ+zBlB1bs89NjW/xhvUdFqo1Myy0s9bHTpHZ4wzn35rW58QcFowkLWqemTyWt4dSMPFQp3cllwwXLbx7e2np85vN4p0LnU3dhAmOwlQoIkUaA/+mtQGDGwqGeuoECMdyq9SjSX23bfEHHfcceTuzH66Xmy9fk9WwYCnB2/z5z+n2nlwMilcnxvNnoV0jcjrq6flw+V0npI0wTMDPzavH6pBdjIMy5tbzfapGs4g==; 5:E3TYFxR/+vyLr17MaigJGZbwjpmPtJVUao5Q9U/LeTpxU3oW4LpNrO5rdBDXe3a6ZTcc0L3zykmpe+lrtTCzSCEO415OLKLkE+KD8OeLFCHBbFZY+t7Vgxs4lU3gPf2+1qUGbILGF3/b9NsD8hUOKRpki/ppe4VGvoSlaPTCXow=; 24:CwAj4Cc1frtmUmXJfHIWtQrZg98Z3ZDugkyCYUeOvxdpwrBu1FOnW9e/fiiYgaFrE3xFzhduhVcTIF9UYt+dlkmPSsh4bEU77pL5TUtQ49Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 7:GSUyBwrLUeO5QMYo6XZxplk+83t8IP/q7QuhhRXzsa6IqVUL56x0bHa8XOXc2NqsrGVMXAYglOqt3Tk9+NyQs7OjnfWa8blDbFNnpkarEmLi7wuiMO6UWvvW5bHcPfY0ovCrEz9xpZ/0+DY2LlQ7HpkqSDXkcJ2kw/Dgfzq1CP9e6LF7ZqBex1hVn7vxFUc8TyL1AP9IoBkTSqjglzoDiyO4cd07GfnT08eh/Px9ceR+2ClsluyxYlqG4iRTbnc+ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2018 00:03:01.1474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 418eae19-ab06-4d02-5b3e-08d5dbc15bbd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3908 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As tcpm_register_port() and tcpci_register_port() never return NULL and NULL is not a success in this case, use IS_ERR() to check the return value of both. Reviewed-by: Heikki Krogerus Signed-off-by: Li Jun Reviewed-by: Guenter Roeck --- drivers/staging/typec/tcpci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c index 076498a..b63f147 100644 --- a/drivers/staging/typec/tcpci.c +++ b/drivers/staging/typec/tcpci.c @@ -509,7 +509,7 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) return ERR_PTR(err); tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc); - if (PTR_ERR_OR_ZERO(tcpci->port)) + if (IS_ERR(tcpci->port)) return ERR_CAST(tcpci->port); return tcpci; @@ -551,7 +551,7 @@ static int tcpci_probe(struct i2c_client *client, return err; chip->tcpci = tcpci_register_port(&client->dev, &chip->data); - if (PTR_ERR_OR_ZERO(chip->tcpci)) + if (IS_ERR(chip->tcpci)) return PTR_ERR(chip->tcpci); i2c_set_clientdata(client, chip);