diff mbox series

[net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'

Message ID 1547777209-92367-1-git-send-email-yuehaibing@huawei.com (mailing list archive)
State Mainlined
Commit fa1115c6a249cd3fac5b00aba1be38533e501005
Headers show
Series [net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' | expand

Commit Message

Yue Haibing Jan. 18, 2019, 2:06 a.m. UTC 
From: Yue Haibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
drivers/net/usb/rtl8150.c:391:6: warning:
 variable 'rx_stat' set but not used [-Wunused-but-set-variable]

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/usb/rtl8150.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Petko Manolov Jan. 18, 2019, 2:30 p.m. UTC | #1 
On 19-01-18 02:06:49, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
>  variable 'rx_stat' set but not used [-Wunused-but-set-variable]

Good catch, thanks.


		Petko


> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  drivers/net/usb/rtl8150.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 80373a9..3f145e4 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb)
>  	unsigned pkt_len, res;
>  	struct sk_buff *skb;
>  	struct net_device *netdev;
> -	u16 rx_stat;
>  	int status = urb->status;
>  	int result;
>  	unsigned long flags;
> @@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb)
>  		goto goon;
>  
>  	res = urb->actual_length;
> -	rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4));
>  	pkt_len = res - 4;
>  
>  	skb_put(dev->rx_skb, pkt_len);
> 
> 
> 
>
David Miller Jan. 19, 2019, 6:30 p.m. UTC | #2 
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 18 Jan 2019 02:06:49 +0000

> From: Yue Haibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
>  variable 'rx_stat' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 80373a9..3f145e4 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -388,7 +388,6 @@  static void read_bulk_callback(struct urb *urb)
 	unsigned pkt_len, res;
 	struct sk_buff *skb;
 	struct net_device *netdev;
-	u16 rx_stat;
 	int status = urb->status;
 	int result;
 	unsigned long flags;
@@ -424,7 +423,6 @@  static void read_bulk_callback(struct urb *urb)
 		goto goon;
 
 	res = urb->actual_length;
-	rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4));
 	pkt_len = res - 4;
 
 	skb_put(dev->rx_skb, pkt_len);